aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Merge pull request #9332 from ↵Rafael Mendonça França2013-02-203-15/+45
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | wangjohn/adding_documentation_to_error_raising_in_query_methods Tests to make sure empty arguments in WhereChain raise errors
| * | | | | | Added comments about the check_empty_arguments method which is calledwangjohn2013-02-203-15/+45
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | for query methods in a where_clause. Also, modified the CHANGELOG entry because it had false information and added tests.
* | | | | | Merge pull request #9342 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-201-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
| * | | | | | make type_cast_value a class level methodTerence Lee2013-02-211-1/+1
| |/ / / / /
* | | | | | Merge pull request #9068 from wangjohn/transaction_callback_patchRafael Mendonça França2013-02-206-6/+89
|\ \ \ \ \ \ | | | | | | | | | | | | | | Reduced memory leak problem in transactions by lazily updating AR objects
| * | | | | | Reduced memory leak problem in transactions by lazily updating AR objects ↵wangjohn2013-02-206-6/+89
| |/ / / / / | | | | | | | | | | | | | | | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
* | | | | | Merge pull request #9341 from senny/move_precompiled_asset_config_to_applicationRafael Mendonça França2013-02-203-6/+10
|\ \ \ \ \ \ | |/ / / / / |/| | | | | move config.assets.precompile into config/application.rb
| * | | | | move config.assets.precompile into config/application.rbYves Senn2013-02-203-6/+10
| | | | | |
* | | | | | Merge pull request #9120 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-205-10/+24
|\ \ \ \ \ \ | |/ / / / / |/| | | | | fix rake db:migrate when used with ENV['DATABASE_URL']
| * | | | | update changelogTerence Lee2013-02-211-0/+3
| | | | | |
| * | | | | run the load_structure test in the test environmentTerence Lee2013-02-211-3/+10
| | | | | |
| * | | | | test DATABASE_URL without database.yml aroundTerence Lee2013-02-211-0/+2
| | | | | |
| * | | | | standardize database_configuration to a hashTerence Lee2013-02-213-7/+9
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does
* | | | | Merge pull request #9328 from sikachu/ps-remove-xml-parserGuillermo Iguaran2013-02-205-342/+31
|\ \ \ \ \ | | | | | | | | | | | | Remove XML Parser from ActionDispatch
| * | | | | Remove XML Parser from ActionDispatchPrem Sichanugrist2013-02-205-342/+31
|/ / / / / | | | | | | | | | | | | | | | | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem.
* | | | | Whitespace :heart: and hash syntax changeRafael Mendonça França2013-02-201-23/+22
| | | | |
* | | | | Merge pull request #8060 from ↵Xavier Noria2013-02-203-3/+20
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | senny/7313_descriptive_error_message_for_missing_adapter descriptive error message when AR adapter was not found. Closes #7313
| * | | | descriptive error message when AR adapter was not found. Closes #7313.Yves Senn2013-02-203-3/+20
|/ / / /
* | | | Merge pull request #9330 from bdmac/time_zone_select_dupAndrew White2013-02-193-1/+16
|\ \ \ \ | | | | | | | | | | Fix time_zone_options_for_select to not mutate TimeZones array
| * | | | Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-193-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* | | | | Merge pull request #9331 from robertomiranda/upgrading-guideGuillermo Iguaran2013-02-191-0/+10
|\ \ \ \ \ | |/ / / / |/| | | | Improve upgrading guide with ActionDispatch::BestStandardsSupport remova...
| * | | | Improve upgrading guide with ActionDispatch::BestStandardsSupport removalrobertomiranda2013-02-191-0/+10
|/ / / /
* | | | Better not use tab chars in the generator templateAkira Matsuda2013-02-201-5/+5
| | | |
* | | | Merge pull request #9324 from acapilleri/add_on_emptySteve Klabnik2013-02-191-0/+7
|\ \ \ \ | | | | | | | | | | added more accurate test for add_on_empty
| * | | | added more accurate test for add_on_emptyAngelo capilleri2013-02-191-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails
* | | | | s/revertible/reversible/Xavier Noria2013-02-191-1/+1
| | | | |
* | | | | fixes a typo in the migrations guideXavier Noria2013-02-191-1/+1
| | | | |
* | | | | Merge pull request #9315 from ↵Steve Klabnik2013-02-191-23/+0
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb delete duplicated tests in AR base_test.rb
| * | | | delete duplicated tests in AR base_test.rbTakehiro Adachi2013-02-191-23/+0
| | | | | | | | | | | | | | | | | | | | These are duplicated with the tests which are in relations_test.rb
* | | | | moves a CHANGELOG entry from AR to APXavier Noria2013-02-192-4/+4
| | | | |
* | | | | small tweaks in the AR CHANGELOGXavier Noria2013-02-191-4/+4
| | | | |
* | | | | Merge pull request #9258 from wangjohn/blank_argument_errors_in_arelRafael Mendonça França2013-02-192-9/+34
|\ \ \ \ \ | | | | | | | | | | | | Raising an error when query methods have blank arguments.
| * | | | | Raise an error when query methods have blank arguments, and when blank ↵John J Wang2013-02-192-9/+34
|/ / / / / | | | | | | | | | | | | | | | arguments are meaningless.
* | | | | InvalidMessage is in ActiveSupport::MessageEncryptor namespaceSantiago Pastorino2013-02-192-4/+19
| | | | | | | | | | | | | | | | | | | | Closes #9302
* | | | | Fix rake routes output in railties testCarlos Antonio da Silva2013-02-191-2/+4
| | | | |
* | | | | Fix AP tests related to routes inspector output and the new column titlesCarlos Antonio da Silva2013-02-191-20/+65
| | | | |
* | | | | Add missing require to routes inspectorCarlos Antonio da Silva2013-02-191-0/+1
| | | | |
* | | | | Merge pull request #9321 from mfilej/action-dispatch-http-url-requiresXavier Noria2013-02-191-0/+3
|\ \ \ \ \ | | | | | | | | | | | | Require ActiveSupport dependencies in ActionDispatch::Http::URL
| * | | | | Require AS deps in ActionDispatch::Http::URLMiha Filej2013-02-191-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Allows us to use url_for and friends in isolation.
* | | | | | Remove config.autoload_paths from config/application.rbAndrew White2013-02-191-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most application developers shouldn't be adding paths to `config.autoload_paths` as it won't be eagerly loaded so remove it from the generated config/application.rb file. If a developer does want to autoload from paths outside of the app directory then they should add the path to `config.eager_load_paths` as these paths are also autoloaded as well.
* | | | | | Don't unhook autoloading in productionAndrew White2013-02-191-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whilst autoloading is known to be not threadsafe, leaving it in place is a softer solution than failing hard when an application is deployed. Many older applications will have paths added to `autoload_paths` and ideally these should be eagerly loaded to be threadsafe. However one of these paths is quite often lib which could lead to unintended consequences due to the 'junk drawer' nature of this directory. Developers should refrain from adding paths to `autoload_paths` or `eager_load_paths` and use custom folders inside app for code that needs to be eagerly loaded and use `require` or `require_dependency` to explicitly load code from other locations.
* | | | | | Revert "Deprecate the `eager_load_paths` configuration"Andrew White2013-02-197-91/+66
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because of the possibility of lib being unintentionally eager loaded it's been agreed that we'll leave autoload paths and eager load paths separate for Rails 4.0. This reverts commit 0757b3388ffe4f44b60de950d40e18ef05055931. Conflicts: railties/CHANGELOG.md
* | | | | Duck typing is hard. Add header to HtmlTableFormatter.Steve Klabnik2013-02-181-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Somehow I missed this method, which was then throwing an error when viewing routes as HTML. Make @rubys happy: ✔
* | | | | editorial tweaksXavier Noria2013-02-192-4/+7
| | | | |
* | | | | Use strip_heredoc in the tests as well.Steve Klabnik2013-02-181-5/+6
| | | | | | | | | | | | | | | | | | | | Thanks @sikachu. :sweat_smile:
* | | | | use strip_heredoc to keep indentation consistent.Steve Klabnik2013-02-181-12/+12
| | | | | | | | | | | | | | | | | | | | Thanks @sikachu. :heart:
* | | | | Merge pull request #9316 from steveklabnik/no_routesXavier Noria2013-02-183-0/+46
|\ \ \ \ \ | | | | | | | | | | | | Print message on stderr when no routes are defined.
| * | | | | Add message when you have no routes defined.Steve Klabnik2013-02-183-0/+46
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic.
* | | | | Merge pull request #9318 from steveklabnik/router_headingsXavier Noria2013-02-181-3/+19
|\ \ \ \ \ | | | | | | | | | | | | Add headings to rake routes table
| * | | | | Add headings to rake routes tableSteve Klabnik2013-02-181-3/+19
| | | | | |