| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Added `ActiveSupport::TimeWithZone#to_r` for `Time#at` compatibility.
Closes #9404
|
| | | | | | |
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Taking the wise advice of @carlosantoniodasilva
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
don't apply invalid ordering when preloading hmt associations.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
closes #8663.
When preloading a hmt association there two possible scenarios:
1.) preload with 2 queries: first hm association, then hmt with id IN ()
2.) preload with join: hmt association is loaded with a join on the hm association
The bug was happening in scenario 1.) with a normal order clause on the hmt association.
The ordering was also applied when loading the hm association, which resulted in the error.
This patch only applies the ordering the the hm-relation if we are performing a join (2).
Otherwise the order will only appear in the second query (1).
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
update the example for `after_commit` in the guides.
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
This is a follow up to #9356.
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Remove `--builder` option from `rails` command
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Ability to use a custom builder by passing `--builder` (or `-b`) has
been removed. Consider using application template instead. See this
guide for more detail:
http://guides.rubyonrails.org/rails_application_templates.html
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove config.auto_explain_threshold_in_seconds
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We discussed that the auto explain feature is rarely used.
This PR removes only the automatic explain. You can still display
the explain output for any given relation using `ActiveRecord::Relation#explain`.
As a side-effect this should also fix the connection problem during
asset compilation (#9385). The auto explain initializer in the `ActiveRecord::Railtie`
forced a connection.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Updated doc to clarify about update_all and delete_all
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
delete_all will call callbacks if depdent option is specified as
:destroy. This behavior is not very clear from the documetation and
hence issue #7832 was raised.
closes #7832
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Point to the Protected Attributes gem to those who want a smoothly
upgrade path before to change to use Strong Parameters.
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The connection url parssing don't accept the socket option
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We should only type cast when we need to use.
Related to 4b005fb371c2e7af80df7da63be94509b1db038c
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Revert "move config.assets.precompile into config/application.rb"
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 304f4d4c25ccabdbf97d37dd7a92a54d0b63a9c9.
As it turns out everything should behave as it did and we don't
need to move this configuration option.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
multiple actions for :on option with `after_commit` and `after_rollback`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Closes #988.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
test case to prevent duplicated associations with custom PK.
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
closes #9201
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Address failure test_rename_column_with_multi_column_index with Oracle
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
because of Oracle database index length spec.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
also rename the test-case class inside columns_test.rb
|
|/ / / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reason: on a second thought, minitest prints a seed as run option
regardless of the test order, and it actually calls srand, so
albeit it might be misleading I believe, it is the way it is and
should be left that way.
This reverts commit c15862ae0cb876d745609170f0f90a9bb9b5e0ae.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
See the first FIXME comment in the patch for the rationale.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
guides/rails_guides moved up and out of the railties directory
|
| | | | | | | |
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Forwardport #9388 rename/remove column preserves custom PK.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
I renamed the test to better communicate it's intention. Since it also tests:
- add_column
- remove_column
- change_column
There is no reason to call it rename_column_test.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix debug helper not inspecting when it can't convert to YAML
|
|/ / / / / /
| | | | | |
| | | | | | |
The debug helper should inspect the object when it can't be converted to YAML, this behavior was changed in 8f8d8eb1465069e2ed9b6f2404aa9d02e785f534.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Since all changes from #9347 are related to AS, it seems proper that the
test is placed there as well.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Address edge case for number_to_human with units option.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
ActiveSupport::NumberHelper#number_to_human now returns the number unaltered when
the units hash does not contain the needed key, e.g. when the number provided is less
than the largest key provided.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Correct comment for (beginning|end)_of_minute [ci skip]
|
|/ / / / / / / |
|