| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Queue_classic currently limits pg to "< 0.20".
It is therefore not used for rails CI tests. There has been
a bull request for a while (by a co-worker of mine), which
fixes the incompatibilities and extends dependencies to pg-1.x.
This patch add this pull request to the Gemfile as an interim
solution, until it is merged.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pg-1.0.0 is just released and most Gemfiles don't restrict
it's version. But the version is checked when connecting to
the database, which leads to the following error:
Gem::LoadError: can't activate pg (~> 0.18), already activated pg-1.0.0
See also this pg issue:
https://bitbucket.org/ged/ruby-pg/issues/270/pg-100-x64-mingw32-rails-server-not-start
Preparation for pg-1.0 was done in commit f28a331023fab,
but the pg version constraint was not yet relaxed.
|
| |
|
| |
|
|\
| |
| |
| | |
Fix :inverse_of documentation
|
| |
| |
| |
| |
| |
| |
| |
| | |
options, and is needed for bi-directionality with a scope
[ci skip] Remove :conditions opion from association basics guide
This got replaced by scopes.
|
| | |
|
|/ |
|
|
|
|
| |
Need reloading when through record has replaced.
|
|\
| |
| | |
Clean up railties tests
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove `AppGeneratorTest#test_active_storage_install`.
The test is added by 67db41aa7f17c2d34eb5a914ac7a6b2574930ff4,
since #31534 this test doesn't test anything.
Remove redundant assertions in `SharedGeneratorTests`.
These assertions is added by 4a835aa3236eedb135ccf8b59ed3c03e040b8b01.
Follows 67db41aa7f17c2d34eb5a914ac7a6b2574930ff4, #31534.
|
|\ \
| |/
|/|
| |
| |
| | |
zoltankiss/allow-nested-has-many-associations-on-unpersisted-parent-instances
fix nested `has many :through` associations on unpersisted parent instances
|
| |
| |
| |
| | |
Fixes: #16313
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I removed redundant `Array.wrap(records)` since `Preloader` is nodoc
class and Active Record always pass `records` as an array to
`Preloader`.
But if users relies on that behavior, it is not worth dropping its
behavior.
Fixes #31661.
|
|\ \
| | |
| | | |
Fix performance issue with NameError#missing_name on ruby >= v2.3.0.
|
| | |
| | |
| | |
| | |
| | | |
Since ruby v2.3.0 `did_you_mean` gem shipped and ENABLED by default.
It patches NameError#message with spell corrections which are SLOW.
|
|\ \ \
| | | |
| | | | |
Consistency between first() and last() with limit
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Don't include Active Storage migrations in new apps
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When a user tries to create a new attachment or blog and the matching table is missing from the database
(`active_storage_attachments` and `active_storage_blobs` by default), an informative error is displayed
that invites users to run the `active_storage:install` task.
|
| | | |
| | | |
| | | |
| | | | |
See #31315 for full discussion
|
|\ \ \ \
| | | | |
| | | | | |
Change Active Storage destroy callbacks
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
There is concern that only blob are deleted depending on
the `before_destroy` definition order which throws abort.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
To pick up 21417e02e906f6b64f013aafefdc0cb8ea8b5e74
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
#31393
Brought to you by a 12 year old Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=329509
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Explicitly declare inverse associations so ActiveStorage::Attachment touches the original record instance.
Closes #31542.
|
|\ \ \ \
| | | | |
| | | | | |
Allow overriding filename in `Blob#service_url`
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is useful when we have several representations for the same
underlying file, each one with a different name, and we need to provide
a custom download URL based on that name and not that of the underlying
file.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Fix rubocop space before comma
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | | |
`ActiveSupport::OrderedOptions` responds to any message.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
eugeneius/use_authenticated_message_encryption_new_framework_defaults
Allow use_authenticated_message_encryption to be set in new_framework_defaults_5_2.rb
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
new_framework_defaults_5_2.rb
Enabling this option in new_framework_defaults_5_2.rb didn't work
before, as railtie initializers run before application initializers.
Using `respond_to?` to decide whether to set the option wasn't working
either, as `ActiveSupport::OrderedOptions` responds to any message.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
prathamesh-sonpatki/improve-deprecation-msg-pr-29358
Improve the deprecation message for using subclass of Rails::Application to start the Rails server
|
| | | | |
| | | | |
| | | | |
| | | | | |
start the Rails server
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently deleting through records doesn't respect `source_type`. It
should not be ignored in that case.
Related #23209.
Fixes #24116.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
We can use `relation.last(index)[-index]` instead of loading all records
when using reversible order because `last` will call `reverse_order`.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently `last` with `offset` behaves incorrectly because `offset` can
not be reversed like `limit`. Therefore, `offset` should also be handled
like `limit`.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Commit 4ec5b0d was for fixing the regression #18787, but #28379 fixes
#18787 as well. So 4ec5b0d is no longer necessary.
|