aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* FormHelper correctly passes its object through select, collection_select, ↵Jeremy Kemper2005-11-222-5/+7
| | | | | | country_select, and time_zone_select. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* has_and_belongs_to_many: use JOIN instead of LEFT JOIN. References #2937.Jeremy Kemper2005-11-212-2/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allow assert_tag(:conditions) to match the empty string when a tag has no ↵Jamis Buck2005-11-213-2/+10
| | | | | | children. Closes #2959. [Jamis Buck] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Update html-scanner to handle CDATA sections better. Closes #2970. [Jamis Buck]Jamis Buck2005-11-213-0/+18
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* MySQL: introduce :encoding option to specify the character set for client, ↵Jeremy Kemper2005-11-212-3/+25
| | | | | | connection, and results. Only available for MySQL 4.1 and later with the mysql-ruby driver. Do SHOW CHARACTER SET in mysql client to see available encodings. Closes #2975. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Don't put flash in session if sessions are disabled.Jeremy Kemper2005-11-212-7/+18
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Back out of 3109 for now as it seems to interfere with the flashDavid Heinemeier Hansson2005-11-211-6/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Simpler Mysql load test.Jeremy Kemper2005-11-211-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Revert [3130]. Behavior of introducing Kernel.binding causes breakage.Marcel Molina2005-11-213-5/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use Kernel.binding rather than binding to allow columns of that name. ↵Jeremy Kemper2005-11-213-3/+5
| | | | | | References #2973. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Strip out trailing &_= for raw post bodies #2868Sam Stephenson2005-11-212-0/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make the db_schema_dump task honor the SCHEMA environment variable if ↵Marcel Molina2005-11-212-1/+3
| | | | | | present the way db_schema_import does. Closes #2931. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3241@asus: jeremy | 2005-11-20 23:26:28 -0800Jeremy Kemper2005-11-211-0/+2
| | | | | | | Active Support is warnings-safe. References #1792. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3240@asus: jeremy | 2005-11-20 23:22:34 -0800Jeremy Kemper2005-11-214-34/+48
| | | | | | | Introduce enable_warnings counterpart to silence_warnings. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3239@asus: jeremy | 2005-11-20 23:21:37 -0800Jeremy Kemper2005-11-211-5/+5
| | | | | | | Test for absence of instance vars rather than nil so we don't get a warning. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3133 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3220@asus: jeremy | 2005-11-20 03:19:22 -0800Jeremy Kemper2005-11-212-3/+8
| | | | | | | Enable Action Mailer warnings in unit tests. adv_attr_accessor hecks for presence of instance variable before getting it. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3132 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3219@asus: jeremy | 2005-11-20 03:07:19 -0800Jeremy Kemper2005-11-212-12/+17
| | | | | | | silence necessary warnings in logger test. guard against multiple requires in kernel test. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3218@asus: jeremy | 2005-11-20 03:06:32 -0800Jeremy Kemper2005-11-211-0/+2
| | | | | | | alias old format_message before overriding it git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3217@asus: jeremy | 2005-11-20 03:06:01 -0800Jeremy Kemper2005-11-211-4/+2
| | | | | | | warnings-safe inherited alias for class_inheritable_attributes git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3216@asus: jeremy | 2005-11-20 03:05:20 -0800Jeremy Kemper2005-11-212-55/+29
| | | | | | | simplify cattr_ and mattr_accessor git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3215@asus: jeremy | 2005-11-20 02:05:56 -0800Jeremy Kemper2005-11-215-9/+5
| | | | | | | Eliminate double-requires due to Ruby seeing different paths to the same file. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3214@asus: jeremy | 2005-11-20 02:03:05 -0800Jeremy Kemper2005-11-211-48/+48
| | | | | | | Parenthesize args in Inflections git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3213@asus: jeremy | 2005-11-20 02:01:28 -0800Jeremy Kemper2005-11-211-0/+2
| | | | | | | Turn on warnings for tests. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Turn warnings on when loading a file if Dependencies.mechanism == :load. ↵Jeremy Kemper2005-11-212-3/+14
| | | | | | Common mistakes such as redefined methods will print warnings to stderr. References #752. References #1792. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Have the lighttpd server script report the actual ip to which the server is ↵Sam Stephenson2005-11-212-3/+8
| | | | | | bound. Closes #2903. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3123 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add plugin library directories to the load path after the lib directory so ↵Marcel Molina2005-11-212-3/+10
| | | | | | that libraries in the lib directory get precedence. Closes #2910. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3122 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make help for the console command more explicit about how to specify the ↵Marcel Molina2005-11-212-0/+2
| | | | | | desired environment in which to run the console. Closes #2911. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Pull out Array#to_strings in favor of more general Symbol#to_proc.Marcel Molina2005-11-213-9/+0
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add Symbol#to_proc, which allows for, e.g. [:foo, :bar].map(&:to_s).Marcel Molina2005-11-213-0/+15
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3118 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix grammar error in [3115]. References #2966.Jeremy Kemper2005-11-211-2/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Pass multiple arguments to Element.show and Element.hide in ↵Sam Stephenson2005-11-213-6/+8
| | | | | | JavaScriptGenerator instead of using iterators git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improve expire_fragment documentation. Closes #2966.Jeremy Kemper2005-11-212-1/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add Array#to_strings which to_s's all elements in an array.Marcel Molina2005-11-203-0/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add extended_by, extend_with_included_modules_from and ↵Marcel Molina2005-11-203-1/+99
| | | | | | copy_instance_variables_from to Object. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Correct docs for automatic layout assignment. Closes #2610.Marcel Molina2005-11-202-1/+5
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* PostgreSQL: the purge_test_database Rake task shouldn't explicitly specify ↵Jeremy Kemper2005-11-202-1/+3
| | | | | | the template0 template when creating a fresh test database. Closes #2964. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3209@asus: jeremy | 2005-11-20 01:04:22 -0800Jeremy Kemper2005-11-201-2/+6
| | | | | | | If sessions are disabled, return a hash that raises an error when it's accessed. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make data writer private. Marshal/unmarshal handle nil.Jeremy Kemper2005-11-201-8/+8
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Log ActiveRecordStore debugging.Jeremy Kemper2005-11-201-0/+19
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add tasks to create, drop and rebuild the MySQL and PostgreSQL test databases.Marcel Molina2005-11-202-0/+37
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Document request.env and request.host. Strip trailing whitespace.Jeremy Kemper2005-11-201-15/+18
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allows generator to specify migrations directory. References #2960.Jeremy Kemper2005-11-204-5/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3101 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3173@asus: jeremy | 2005-11-18 23:34:41 -0800Jeremy Kemper2005-11-204-13/+16
| | | | | | | | | | | | | | | | | | | | | Ticket 2731 - sessions r3185@asus: jeremy | 2005-11-19 18:02:51 -0800 eliminate const redefinition warning r3186@asus: jeremy | 2005-11-19 19:25:50 -0800 Use :database option instead of :dbfile r3187@asus: jeremy | 2005-11-19 19:34:31 -0800 Data writer assigns to instance var. Since nothing is calling write_attribute on the data column except for marshal_data, simplify data reader to lazy-unmarshal the data column (no worrying whether it's already unmarshaled) r3188@asus: jeremy | 2005-11-19 19:35:40 -0800 Explicitly create the session class so that subsequent requests for the session can find it in the database. This is masking a problem with the controller losing its @session instance var and therefore requesting a new session. r3189@asus: jeremy | 2005-11-19 19:36:40 -0800 Using create unnecessarily broadens the existing duck-typing so use new + save instead. r3194@asus: jeremy | 2005-11-19 20:28:17 -0800 Test creation of another instance while first instance is still active. Should return same session_id. r3195@asus: jeremy | 2005-11-19 20:39:45 -0800 Always create new AR sessions rather than trying too hard to avoid database traffic. References #2731. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Introducing the session_migration generator. Creates an add_session_table ↵Jeremy Kemper2005-11-206-53/+90
| | | | | | migration. References #2958. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r3181@asus: jeremy | 2005-11-19 02:52:24 -0800Jeremy Kemper2005-11-194-33/+39
| | | | | | | Mark connections for verification. Retrieve connection verifies before returning a connection. Verification tests whether the connection is marked then reconnects if the connection is inactive. All active connections are marked for verification after a request is handled. References #428. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use query methods rather than readers in boolean tests for [3092]. ↵Jeremy Kemper2005-11-191-4/+4
| | | | | | References #2945. Closes #2949. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Correct boolean handling in generated reader methods. References #2945.Jeremy Kemper2005-11-194-2/+50
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3092 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Update to Prototype 1.4.0_rc4. Closes #2943 (old Array.prototype.reverse ↵Sam Stephenson2005-11-194-18/+42
| | | | | | behavior can be obtained by passing false as an argument) git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Don't generate read methods for columns whose names are not valid ruby ↵Jeremy Kemper2005-11-193-1/+19
| | | | | | method names. References #2946. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use Element.update('id', 'html') instead of uid=501(sam) gid=501(sam) ↵Sam Stephenson2005-11-183-3/+5
| | | | | | groups=501(sam), 81(appserveradm), 79(appserverusr), 80(admin).innerHTML = 'html' in JavaScriptGenerator#replace_html so that script tags are evaluated git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de