| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
* define source_root by source_root method
* it don't create file, but copy it.
|
|\
| |
| | |
Fix rails middleware list in api_app guide [ci skip]
|
| |
| |
| |
| | |
* `MyApi::Application::Routes` is not middleware.
|
|\ \
| | |
| | |
| | |
| | | |
yhirano55/fix_email_in_active_support_instrumentation
Fix email in Active Support Instrumentation [ci skip]
|
|/ /
| |
| |
| | |
* `s/ddh/dhh/`
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/make_bang_verion_work_with_inheritable_options
Make bang version work with `InheritableOptions`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, bang version does not work with `InheritableOptions`.
`InheritableOptions` treats the argument Hash as the default value.
However, `Hash#fetch` does not use the default value when key is not
found, so can not get the default value.
So in bang version, should use `Hash#[]` instead of `Hash#fetch`.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Currently the normalization only exists in `primary_key` shorthand. It
should be moved to `new_column_definition` to also affect to
`add_column` with primary key.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently implicit legacy primary key is compatible, but adding explicit
legacy primary key is not compatible. It should also be fixed.
Fixes #30664.
|
|\ \ \
| | | |
| | | | |
Ensure `1 AS one` for SQL Server with Calculations
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`change_column_{default,null,comment}` in mysql2 adapter are passing
`column.sql_type` as `type` to `change_column` to intend keeping
previous type. But `column_for` requires extra query, so use passing
`nil` to `type` explicitly in the internal for the purpose.
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Implement change_table_comment and change_column_comment
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Use `TOPLEVEL_BINDING` in rails runner command
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Binding to capture the local scope. This means that if a constant with same
name as constant specified by the user exists in local scope, constant
defined in local will use. This is different from what the user expects.
Therefore, fixed to use top-level binding instead of local scope.
Fixes #30644
|
|\ \ \
| | | |
| | | | |
Use algorithm while removing index with db:rollback
|
| |/ /
| | |
| | |
| | | |
Closes #24190
|
|\ \ \
| |/ /
|/| | |
Fix "warning: `*' interpreted as argument prefix"
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes following warning:
```
/home/travis/build/rails/rails/activerecord/test/cases/instrumentation_test.rb:11: warning: `*' interpreted as argument prefix
/home/travis/build/rails/rails/activerecord/test/cases/instrumentation_test.rb:23: warning: `*' interpreted as argument prefix
/home/travis/build/rails/rails/activerecord/test/cases/instrumentation_test.rb:35: warning: `*' interpreted as argument prefix
/home/travis/build/rails/rails/activerecord/test/cases/instrumentation_test.rb:48: warning: `*' interpreted as argument prefix
/home/travis/build/rails/rails/activerecord/test/cases/instrumentation_test.rb:61: warning: `*' interpreted as argument prefix
```
|
|\ \
| | |
| | | |
Update link in The Asset Pipeline guide [ci skip]
|
| |/ |
|
|\ \
| |/
|/|
| |
| | |
jagthedrummer/jeremy/instrumentation-payload-names
Update payload names for `sql.active_record` instrumentation to be more descriptive.
|
| |
| |
| |
| | |
Fixes #30586.
|
|\ \
| | |
| | | |
Update Rails Guides about :autosave option
|
| | | |
|
| | | |
|
|/ / |
|
|\ \
| | |
| | | |
Deprecate `Module#reachable?` method
|
| | |
| | |
| | |
| | | |
Extensions" guide
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add `with_attached_*` scope to `has_one_attached` macro
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* For avoiding N+1 problem, added `with_attached_*` scope to
`has_one_attached` macro.
|
|\ \ \ \
| | | | |
| | | | | |
Update Layouts and Rendering in Rails [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* The example code on this page are similar to ones generated
by scaffold generator, but some points are different.
* Of course, it is no reason to be as same as scaffolding codes.
But this is the guide for beginners, I thought it's better
to be almost same as scaffolding codes.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
make documentation consistent with KeyError message
|
| | |_|_|/
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Use RESTful instead of restful
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
make create_join_table compatible.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use credentials in `storage.yml` template
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Follow up of #30650
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
According to #30067:
> This PR will deprecate secrets.yml* and instead adopt
> config/credentials.yml.enc to signify what these secrets are specifically
> for: Keeping API keys, database passwords, and any other integration
> credentials in one place.
[ci skip] since only comments are being edited.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add :comment option for add_column [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Update action_controller_overview.md [ci skip]
|