| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Add note on defaults block option
|
| | | | |
| | | | |
| | | | | |
When I was looking for how to default the entire routes file to JSON I could only find the postfix option. It was mentioned on IRC that you could do this with a block as well and I had not found it in the documentation.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
`ARGV.shift` before calling Rails generators
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Gems like rspec-rails depend on `ARGV` being shifted, and `scaffold`
(for example) not being the first item in `ARGV`. This should allow
rspec-rails to be passing on Rails master.
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | | |
Remove useless `test_supports_primary_key`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`supports_primary_key?` method is defined in `AbstractAdapter` so does
not raise any errors.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
there aren't any instance method defined in this class
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Consolidate duplicated elsif branch
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Ensure the support works like form_with.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Has the handy effect of making the initial examples in the form_with
docs work too.
Had to do some finagling such that form_with's without a scope didn't
wrap their names in braces ala `[title]`.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Remote is gone, long live local.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
By using `except` any option provided to `form_with` would become an html
attribute unless explicitly opted out. This proved annoying when adding
new internal keys in the options hash and seeing them pop up in the html
output.
Prevent this by inverting the `except` to `slice` out the keys we want to
allow becoming html attributes, like id and class.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix rake guides:generate:kindle error
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix Fixnum deprecated warning in Ruby 2.4+
|
| | |/ / /
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Simplify the regex for `unsigned?` method
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It is enough to distinguish only the trailing `unsigned` and
`unsigned zerofill`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Improve clarity of AJ tests output
|
| | | | | | | |
|
| |_|_|/ / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* How to disable scaffolds.scss in generators.md
* Improves workflow customization text in generators.md
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Add missing option on number helper
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
The `delimiter_pattern` option was not present on the documentaion of
the helper.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Change ActiveModel::Type::Helpers to :nodoc: [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Docs Command Line Arguments for Generators
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Throw friendly error message when fixture is not a hash
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Right now, when fixture is not a Hash we throw an error message
saying "fixture is not a hash". This is not very user friendly because
it's not saying which fixture is invalid.
|
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Coffee script 1.12.1 was released and contained a bug where coffee
script was undefined. 1.12.1 was yanked and 1.12.2 was released. This
bumps coffee-script-source so that CI Railties tests pass.
See: https://github.com/jashkenas/coffeescript/issues/4403
|
|\ \ \ \ \ \ \ |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Followup of https://github.com/rails/rails/pull/27086
|
|\ \ \ \ \ \ \ \
| |_|_|/ / / / /
|/| | | | | | | |
Support double-yield inside an around callback
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
It's questionable whether this is a good thing -- it forces any later/
inner callback to handle multiple invocations, along with the actual
wrapped action. But it worked prior to 871ca21f6a1d65c0ec78cb5a9641411e2210460b,
so we shouldn't break it unintentionally.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
fix QueryCache nil dup
|
|/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
make sql statements frozen
dup if arel is not our string
expect runtime error
dont wrap runtime error in invalid
log errors will now be treated as runtime errors
update changelog
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Avoid invalid attribute on local forms generated by `form_with`
|
| | |_|_|_|_|/ /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fixes that the following ERB template would result in invalid HTML
output:
<%= form_with model: Post.new, local: true do |form| %>
<% end %>
Specifically, the resulting form tag would have a spurious `remote`
attribute:
<form remote="false" ...>
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Mention JS Runtime dependency in dev dependencies guide [ci skip].
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix constantize edge case involving prepend, autoloading and name conflicts
|
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
In the following situation:
```ruby
class Bar
end
module Baz
end
class Foo
prepend Baz
end
class Foo::Bar
end
```
Running `Inflector.constantize('Foo::Bar')` would blow up with a NameError.
What is happening is that `constatize` was written before the introduction
of prepend, and wrongly assume that `klass.ancestors.first == klass`.
So it uses `klass.ancestors.inject` without arguments, as a result
a prepended module is used in place of the actual class.
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Remove unused method `namespaced_file_path`
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
```
$ git grep namespaced_file_path
railties/lib/rails/generators/named_base.rb: def namespaced_file_path
railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/")
```
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
use appropriate type for `rc` option
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This fixes the following warning.
```
Expected boolean default value for '--rc'; got "~/.railsrc" (string)
```
|