aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | Merge pull request #12307 from douglascalhoun/patch-1Vijay Dev2013-09-211-2/+0
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Removes (redundant?) sentence fragment in intro text
| | * | | | | | | | | | Removes redundant into textdouglascalhoun2013-09-211-2/+0
| | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | Looks like a remnant sentence fragment from the 3.2 guide.
| * | | | | | | | | | Merge pull request #12310 from JuanitoFatas/fix-a-typoVijay Dev2013-09-211-1/+1
| |\ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / | |/| | | | | | | | | [ci skip] Fix a typo in Engines.md.
| | * | | | | | | | | [ci skip] Fix a typo in Engines.md.Juanito Fatas2013-09-221-1/+1
| |/ / / / / / / / /
| * | | | | | | | | Merge pull request #12232 from claudiob/delete-unused-helper-fixturesSantiago Pastorino2013-09-204-16/+0
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Remove unused AV helper fixtures from e10a2531
| | * | | | | | | | | Remove unused AV helper fixtures from e10a2531claudiob2013-09-144-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Several fixtures for helpers are removed. They were introduced in ActionView by @strzalek but never referenced in any test.
| * | | | | | | | | | Merge pull request #12301 from Gazler/guide_3_0_release_notes_broken_linkRafael Mendonça França2013-09-201-2/+0
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Documentation Fix: Remove broken link on rails 3 guide Closes #12300
| | * | | | | | | | | | Fix: Remove broken link on rails 3 guideGary Rennie2013-09-201-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As raised in https://github.com/rails/rails/issues/12300 [ci skip]
| * | | | | | | | | | | Merge pull request #11452 from dasch/dasch/details-in-digestor-cache-keyJosé Valim2013-09-203-2/+39
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Bust the template digest cache key when details are changed
| | * | | | | | | | | | | Bust the template digest cache key when details are changedDaniel Schierbeck2013-09-193-2/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value.
| * | | | | | | | | | | | Merge pull request #12285 from dasch/dasch/allow-attaching-up-frontJosé Valim2013-09-203-2/+92
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow attaching to AS::Notifications namespace up front
| | * | | | | | | | | | | | Allow attaching to AS::Notifications namespace up frontDaniel Schierbeck2013-09-203-2/+92
| | | |/ / / / / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before, you were required to attach *after* adding the methods to the class, since the attachment process needed the methods to be present. With this change, any new method will also be attached to the configured namespace.
| * | | | | | | | | | | | Merge pull request #12299 from hitendrasingh/code_refactorJosé Valim2013-09-203-8/+8
| |\ \ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / / | |/| | | | | | | | | | | DRYing up method_missing code; Initializing Codepoint object with default values
| | * | | | | | | | | | | Initializing Codepoint object with default valuesHitendra Singh2013-09-202-6/+7
| | | | | | | | | | | | |
| | * | | | | | | | | | | Drying up method_missing codeHitendra Singh2013-09-201-2/+1
| | | | | | | | | | | | |
| * | | | | | | | | | | | mention controller test base class in testing guide. [ci skip]Yves Senn2013-09-201-4/+6
| |/ / / / / / / / / / /
| * | | | | | | | | | | Merge pull request #12295 from gaurish/patch-2Guillermo Iguaran2013-09-191-1/+1
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Allow failures in jruby-head
| | * | | | | | | | | | | Allow failures in jruby-headGaurish Sharma2013-09-201-1/+1
| |/ / / / / / / / / / /
| * | | | | | | | | | | Merge pull request #12294 from gaurish/patch-1Guillermo Iguaran2013-09-191-1/+1
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Run Tests against JRuby master
| | * | | | | | | | | | | Run Tests against JRuby masterGaurish Sharma2013-09-201-1/+1
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many of the failing tests in rails test suite fail because of missing encoding support, example #11739 And according to recent announcement, lot of encoding issues have been fixed in current master. http://ruby.11.x6.nabble.com/Big-encoding-patches-landed-on-master-td4993719.html So lets test against JRuby master & incase there are still bugs. it would be easier to report them to JRuby.
| * | | | | | | | | | | Merge pull request #10362 from derekprior/dp-fix-assert-redirect-toAndrew White2013-09-194-34/+53
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Fix incorrect assert_redirected_to failure message
| | * | | | | | | | | | | Fix regex used to find URI schemes in redirect_toDerek Prior2013-09-192-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous regex was allowing `_` in the URI scheme, which is not allowed by RFC 3986. This change brings the regex in line with the RFC.
| | * | | | | | | | | | | Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-194-34/+48
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
| * | | | | | | | | | | Merge pull request #12280 from kennyj/remove_1_8_compatJosé Valim2013-09-191-1/+1
| |\ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / | |/| | | | | | | | | | Remove 1.8 compatible code
| | * | | | | | | | | | Remove 1.8 compatible codekennyj2013-09-191-1/+1
| | | | | | | | | | | |
| * | | | | | | | | | | Merge pull request #12279 from jbaudanza/reset_sessionJosé Valim2013-09-182-0/+13
| |\ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / | |/| | | | | | | | | | Calling reset_session inside of a controller with a NullSessionHash raises a nil exception.
| | * | | | | | | | | | NullSessionHash#destroy should be a no-opJonathan Baudanza2013-09-182-0/+13
| |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it was raising a NilException
* | | | | | | | | | | remove initialize methodAaron Patterson2013-09-251-4/+0
| | | | | | | | | | |
* | | | | | | | | | | extract association resetting to a methodAaron Patterson2013-09-251-9/+16
| | | | | | | | | | |
* | | | | | | | | | | hash insertion order doesn't matter anymore, so only loop over theAaron Patterson2013-09-251-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | owners once
* | | | | | | | | | | always populate the preloaded records instance variable so we can removeAaron Patterson2013-09-252-10/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the @associated_records_by_owner ivar
* | | | | | | | | | | keep preloaded records in a list rather than extract from a hashAaron Patterson2013-09-253-16/+21
| | | | | | | | | | |
* | | | | | | | | | | push slice loading to it's own method so we can remove the type castingAaron Patterson2013-09-242-24/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | code
* | | | | | | | | | | guarantee that `klass` is not nil inside the preloader objectsAaron Patterson2013-09-242-5/+12
| | | | | | | | | | |
* | | | | | | | | | | eliminate unused ivarAaron Patterson2013-09-241-1/+0
| | | | | | | | | | |
* | | | | | | | | | | all records have a preloaded, so eliminate that conditionalAaron Patterson2013-09-241-11/+7
| | | | | | | | | | |
* | | | | | | | | | | eliminate the `loaded?` conditionalAaron Patterson2013-09-243-12/+7
| | | | | | | | | | |
* | | | | | | | | | | push preloaded test up to the factory method so we can eliminateAaron Patterson2013-09-244-9/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | conditionals from the individual preloaded classes
* | | | | | | | | | | we can't sort by lhs since the middle records have difference classesAaron Patterson2013-09-232-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and possibly different rules for finding those objects
* | | | | | | | | | | adding a test for sti on middle tables with sorting on RHSAaron Patterson2013-09-232-1/+19
| | | | | | | | | | |
* | | | | | | | | | | pass the preloader down so we only have to construct oneAaron Patterson2013-09-237-21/+21
| | | | | | | | | | |
* | | | | | | | | | | reuse the same preloader object for each associationAaron Patterson2013-09-231-2/+2
| | | | | | | | | | |
* | | | | | | | | | | remove state from the preloaderAaron Patterson2013-09-233-28/+18
| | | | | | | | | | |
* | | | | | | | | | | pass the scope all the way down to the constructorsAaron Patterson2013-09-231-10/+10
| | | | | | | | | | |
* | | | | | | | | | | only do the should_reset test onceAaron Patterson2013-09-231-6/+6
| | | | | | | | | | |
* | | | | | | | | | | fix variable names and speed up relation orderingAaron Patterson2013-09-232-16/+12
| | | | | | | | | | |
* | | | | | | | | | | hm:t preloading will respect order set on the RHS associationAaron Patterson2013-09-236-8/+68
| | | | | | | | | | |
* | | | | | | | | | | cache associated target records hashAaron Patterson2013-09-201-17/+11
| | | | | | | | | | |
* | | | | | | | | | | combine methods so we can reuse preloadersAaron Patterson2013-09-201-19/+18
| | | | | | | | | | |
* | | | | | | | | | | return a list rather than hashAaron Patterson2013-09-201-7/+13
| | | | | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-24 05:06:50 +0000