Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | ActiveRecord::Relation#blank? should `LIMIT 1` | David Celis | 2013-06-07 | 1 | -5/+1 | |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an SQL improvement to ActiveRecord::Relation#blank?. Currently, it calls `to_a` on the Relation, which loads all records in the association, and calls `blank?` on the loaded Array. There are other ways, however, to check the emptiness of an association that are far more performant. `#empty?`, `#exists?` and `#any?` all attach a `LIMIT 1` to the SQL query before firing it off, which is a nice query improvement. `#blank?` should do the same! Bonus performance improvements will also happen for `#present?`, which merely calls the negation of `#blank?` Signed-off-by: David Celis <me@davidcel.is> | |||||
* | | Merge pull request #10860 from ka8725/activemodel_log | Carlos Antonio da Silva | 2013-06-07 | 1 | -0/+4 | |
|\ \ | | | | | | | Ignore activemodel/log/ folder | |||||
| * | | Stub logger for tests | Andrey Koleshko | 2013-06-06 | 1 | -0/+4 | |
| | | | ||||||
* | | | Merge pull request #10875 from vipulnsward/fix_some_typos_in_as | Carlos Antonio da Silva | 2013-06-07 | 2 | -2/+2 | |
|\ \ \ | | | | | | | | | Fix some typos [ci skip] | |||||
| * | | | Fix some typos | Vipul A M | 2013-06-07 | 2 | -2/+2 | |
| |/ / | ||||||
* | | | Merge pull request #10874 from rlivsey/patch-1 | Andrew White | 2013-06-07 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Docfix: Use public interface instead of setting instance variables | |||||
| * | | | Docfix: Use public interface instead of setting instance variables | Richard Livsey | 2013-06-07 | 1 | -1/+1 | |
|/ / / | | | | | | | Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor. | |||||
* | | | Merge pull request #10561 from Empact/nix-throwresult | Jon Leighton | 2013-06-07 | 6 | -23/+35 | |
|\ \ \ | |_|/ |/| | | Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results. | |||||
| * | | Rather than raising ThrowResult when construct_limited_ids_conditions comes ↵ | Ben Woosley | 2013-05-10 | 3 | -21/+15 | |
| | | | | | | | | | | | | | | | | | | up empty, set the relation to NullRelation and rely on its results. This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control. | |||||
| * | | Make NullRelation a bit more like a real relation by returning 0 for ↵ | Ben Woosley | 2013-05-10 | 2 | -3/+8 | |
| | | | | | | | | | | | | #calculate(:count) | |||||
| * | | No point in memoizing a simple literal string. | Ben Woosley | 2013-05-10 | 1 | -1/+1 | |
| | | | ||||||
| * | | Add coverage for the fact that pluck without an argument returns all the ↵ | Ben Woosley | 2013-05-10 | 1 | -0/+5 | |
| | | | | | | | | | | | | table's columns. | |||||
| * | | Fix that #pluck wasn't rescuing ThrowResult, meaning it would blow up when ↵ | Ben Woosley | 2013-05-10 | 2 | -0/+8 | |
| | | | | | | | | | | | | failing to construct_limited_ids_condition. | |||||
* | | | Merge pull request #10871 from arunagw/lifo-to-rails | Xavier Noria | 2013-06-06 | 3 | -5/+5 | |
|\ \ \ | | | | | | | | | As we have moved to rails/docrails from lifo/docrails | |||||
| * | | | As we have moved to rails/docrails from lifo/docrails | Arun Agrawal | 2013-06-06 | 3 | -5/+5 | |
|/ / / | | | | | | | | | | | | | | | | Changing links to guides. We are not worried for old versions as GitHub is handling the redirects. | |||||
* | | | registers recent patch in the railties CHANGELOG | Xavier Noria | 2013-06-06 | 1 | -0/+4 | |
| | | | ||||||
* | | | clearing autoloaded constants triggers routes reloading [Fixes #10685] | Xavier Noria | 2013-06-06 | 2 | -9/+61 | |
| | | | | | | | | | | | | | | | Conflicts: railties/test/application/loading_test.rb | |||||
* | | | Merge pull request #10867 from iHiD/patch-1 | Xavier Noria | 2013-06-06 | 1 | -0/+2 | |
|\ \ \ | |_|/ |/| | | Add info about contributing to docs to CONTRIBUTING.md | |||||
| * | | Add info about contributing to docs to CONTRIBUTING.md | Jeremy Walker | 2013-06-06 | 1 | -0/+2 | |
|/ / | | | | | | | Encourage more people to contribute to Rails docs by mentioning it in the contribution guide. | |||||
* | | Merge pull request #10851 from arunagw/fixing_build_pending_migration | Aaron Patterson | 2013-06-05 | 1 | -0/+1 | |
|\ \ | | | | | | | Fixing build for not checking migration | |||||
| * | | Fixing build for not checking migration | Arun Agrawal | 2013-06-05 | 1 | -0/+1 | |
|/ / | ||||||
* | | Merge pull request #10850 from arunagw/build_fix_null_migration | Aaron Patterson | 2013-06-05 | 1 | -3/+3 | |
|\ \ | | | | | | | Need to pass parameters | |||||
| * | | Fix Build. Changing constructor. | Arun Agrawal | 2013-06-05 | 1 | -3/+3 | |
|/ / | ||||||
* | | Merge pull request #10482 from scudco/10432-fix-add-column-with-array | Aaron Patterson | 2013-06-05 | 3 | -0/+34 | |
|\ \ | | | | | | | Fixes #10432 add_column not creating array columns in PostgreSQL | |||||
| * | | Fixes #10432 add_column not creating array columns in PostgreSQL | Adam Anderson | 2013-06-04 | 3 | -0/+34 | |
| | | | | | | | | | | | | | | | | | | When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34) `add_column` was no longer receiving the column options directly. This caused the options to be lost along the way. | |||||
* | | | only check pending migrations if there are new files | Aaron Patterson | 2013-06-05 | 1 | -2/+25 | |
| | | | ||||||
* | | | Fix #10789. Now at last ::Logger doesn't support #silence method . | kennyj | 2013-06-05 | 2 | -3/+10 | |
| | | | ||||||
* | | | the typecast value should be passed to the serializer. fixes #10830 | Aaron Patterson | 2013-06-05 | 2 | -6/+5 | |
| | | | ||||||
* | | | adding a test for #10830 | Aaron Patterson | 2013-06-05 | 1 | -0/+18 | |
| | | | | | | | | | | | | | | | Conflicts: activerecord/test/cases/adapters/postgresql/bytea_test.rb | |||||
* | | | Merge pull request #10841 from latortuga/fix-underscore-dependency-tracking | David Heinemeier Hansson | 2013-06-04 | 2 | -14/+42 | |
|\ \ \ | | | | | | | | | Fix mismatching variable names when using an underscore | |||||
| * | | | Fix mismatching variable names when using an underscore | Drew Ulmer | 2013-06-04 | 2 | -14/+42 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ERBTracker template digest helper class was using a regex to match render calls and it was incorrectly not matching against variables with underscores in the name. This caused it to use the wrong regex match data to populate the template dependency. Because underscore is a valid character for a variable, this fixes the ERBTracker to match it properly. | |||||
* | | | | Merge pull request #10839 from gsamokovarov/clean-normalize_encoded_paths | Rafael Mendonça França | 2013-06-04 | 1 | -11/+7 | |
|\ \ \ \ | | | | | | | | | | | Refactor ActionDispatch::Http::Parameters#normalize_encode_params | |||||
| * | | | | Refactor ActionDispatch::Http::Parameters#normalize_encode_params | Genadi Samokovarov | 2013-06-04 | 1 | -11/+7 | |
| | | | | | ||||||
* | | | | | Merge pull request #10838 from gsamokovarov/routing-autoload_under | Rafael Mendonça França | 2013-06-04 | 1 | -5/+7 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | DRY-up ActionDispatch::Routing autoloads | |||||
| * | | | | Dry-up ActionDispatch::Routing autoloads | Genadi Samokovarov | 2013-06-04 | 1 | -5/+7 | |
| |/ / / | ||||||
* | | | | Merge pull request #10832 from wangjohn/removing_use_of_application_constant | José Valim | 2013-06-03 | 8 | -50/+50 | |
|\ \ \ \ | |_|/ / |/| | | | Removing use of subclassed application constant and replacing with Rails.application | |||||
| * | | | Removing use of subclassed application constant and instead using the | wangjohn | 2013-06-03 | 8 | -50/+50 | |
|/ / / | | | | | | | | | | | | | more agnostic Rails.application syntax. This means tests will be more portable, and won't rely on the existence of a particular subclass. | |||||
* | | | Merge pull request #10784 from senny/10526_prevent_key_transformation | Rafael Mendonça França | 2013-06-03 | 3 | -6/+25 | |
|\ \ \ | | | | | | | | | Prevent side effects in `Hash#with_indifferent_access`. | |||||
| * | | | Prevent side effects in `Hash#with_indifferent_access`. | Yves Senn | 2013-05-29 | 3 | -6/+25 | |
| | | | | ||||||
* | | | | Replace comment about Sprockets stub directive with a link to README about ↵ | Guillermo Iguaran | 2013-06-03 | 2 | -2/+4 | |
| | | | | | | | | | | | | | | | | all directives | |||||
* | | | | Merge branch 'master' of github.com:rails/rails | David Heinemeier Hansson | 2013-06-03 | 4 | -20/+4 | |
|\ \ \ \ | ||||||
| * | | | | Revert "Merge pull request #4490 from EmmanuelOga/master" | José Valim | 2013-06-04 | 3 | -19/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behaviour doesn't actually make sense, the context of the child should not be affected by the parent. See #10492. This reverts commit 5f8274efe128ffeec8fa3179460f5167a078f007, reversing changes made to 81e837e810460d066a2e5fc5a795366ec8ab2313. | |||||
| * | | | | Merge pull request #10809 from wangjohn/fix_failing_railtie_test | Guillermo Iguaran | 2013-06-03 | 1 | -1/+2 | |
| |\ \ \ \ | | | | | | | | | | | | | Fixing a failing railtie test by wrapping the command inside of sh -c | |||||
| | * | | | | Fixing a failing railtie test by using the ENV variable to specify a | wangjohn | 2013-05-31 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | particular controller to search for in rake routes. | |||||
* | | | | | | The behavior we had in place in rc1 was actually to convert to DateTime and ↵ | David Heinemeier Hansson | 2013-06-03 | 1 | -2/+2 | |
|/ / / / / | | | | | | | | | | | | | | | | use <=> from there. Restore that. | |||||
* | | | | | Allow Date to be compared with Time (like it was possible to compare Time ↵ | David Heinemeier Hansson | 2013-06-03 | 2 | -0/+15 | |
| | | | | | | | | | | | | | | | | | | | | with Date) | |||||
* | | | | | Merge pull request #10827 from trevorturk/patch-upgrade-guide | David Heinemeier Hansson | 2013-06-03 | 1 | -16/+39 | |
|\ \ \ \ \ | | | | | | | | | | | | | Improve upgrade guide documentation about the PUT->PATCH change | |||||
| * | | | | | Improve upgrade guide documentation about the PUT->PATCH change | Trevor Turk | 2013-06-03 | 1 | -16/+39 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #10747 from javan/patch-1 | David Heinemeier Hansson | 2013-06-03 | 1 | -0/+18 | |
|\ \ \ \ \ | | | | | | | | | | | | | Add note about upgrading custom routes from `put` to `patch`. | |||||
| * | | | | | Add note about upgrading custom routes from `put` to `patch`. | Javan Makhmali | 2013-05-24 | 1 | -0/+18 | |
| | | | | | |