| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / / /
| | | | |
| | | | |
| | | | | |
Default worker pool size was changed from 100 to 4 at #24376
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
y-yagi/add_missing_as_option_to_deprecation_message
add missing `as` to request kwargs of `ActionDispatch::IntegrationTest`
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
Follow up to #21671
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Add test for `delegate_missing_to` where method doesn't exist
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Bash markdown syntax
|
|/ / / /
| | | |
| | | | |
Added 'sh' for markdown formatting as bash.
|
|\ \ \ \
| | | | |
| | | | | |
Fix `has_one` `enum` `where` queries
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #25128
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Docs: Clarify when assoc. methods persist [ci skip]
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Because I can never remember if `collection_singular_ids=` persists
or not (it does).
[ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Revert back to a compatible bundler version
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Add tests for keyword arg to: for Module#delegate
|
| |/ / / |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Allow failures until test runs are consistently stable, not hanging.
Closes #24943.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
|\ \ \
| | | |
| | | | |
Normalize whitespace for Hash#compact documentation
|
|/ / /
| | |
| | |
| | | |
This is a similar change that occurred for Hash#except in #21087.
|
| | |
| | |
| | |
| | | |
And make sure that it doesn't even try to call the method in the target.
|
|\ \ \
| | | |
| | | | |
Build action_cable.js with Blade
|
| | | |
| | | |
| | | |
| | | | |
Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Introduce Module#delegate_missing_to
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When building decorators, a common pattern may emerge:
class Partition
def initialize(first_event)
@events = [ first_event ]
end
def people
if @events.first.detail.people.any?
@events.collect { |e| Array(e.detail.people) }.flatten.uniq
else
@events.collect(&:creator).uniq
end
end
private
def respond_to_missing?(name, include_private = false)
@events.respond_to?(name, include_private)
end
def method_missing(method, *args, &block)
@events.send(method, *args, &block)
end
end
With `Module#delegate_missing_to`, the above is condensed to:
class Partition
delegate_missing_to :@events
def initialize(first_event)
@events = [ first_event ]
end
def people
if @events.first.detail.people.any?
@events.collect { |e| Array(e.detail.people) }.flatten.uniq
else
@events.collect(&:creator).uniq
end
end
end
David suggested it in #23824.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Cloning depth set to 1
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improved commands in README with markdown formatting
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | | |
Adding '$' to emulate shell syntax
|
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Use RAILS_MAX_THREADS as pool size on all adapters
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When RAILS_MAX_THREADS is set, the postgresql adapter uses it as the
connection pool size, so that there are always enough connections
available to serve Action Cable requests.
The same logic applies when using any other adapter.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[] and read_attribute are not aliases [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The `#[]` method *used to be* an alias of `#read_attribute`, but since Rails 4
(10f6f90d9d1bbc9598bffea90752fc6bd76904cd), it will raise an exception for
missing attributes. Saying that it is an alias is confusing.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 28492204ee59a5aca2f3bc7b161d45724552686d.
Reason: `suppress` without an argument doesn't actually tell what is
supressing. Also, it can be confused with ActiveRecord::Base#suppress.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Add default exceptions affected by suppress
suppress { do_something_that_might_fail }
# instead of
begin
do_something_that_might_fail
rescue
end
# or
do_something_that_might_fail rescue nil
* Do not add default exceptions list constant
[Rafael Mendonça França + Alexey Zapparov]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove deprecated `Module#qualified_const_` from guide [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Follow up to #17845.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix and optimize scaffold CSS
|
| |/ / / / / |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
CSRF verification for non-XHR GET requests (cross-origin `<script>`
tags) didn't check this flag before logging failures.
Setting `config.action_controller.log_warning_on_csrf_failure = false`
now disables logging for these CSRF failures as well.
Closes #25086.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Apps that depend on Action Cable don't need Blade for app development,
so we can remove the gem dependency.
We do need Blade for Action Cable dev, so we bundle it in the Gemfile.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Change comments to not exceed 80 characters
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Other generated files do keep to this, but action cable doesn't.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove space, properly italicize
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Difference in rendering --> https://gist.github.com/maclover7/a50ff9231eb825c39c77cd5858af6d9a
[ci skip]
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Add backticks to `config/secrets.yml`
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Pass over Action Cable docs
|