| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
* includes -> include
* "on your computer" is implied
|
|\
| |
| | |
Better explain the bug report templates [ci skip]
|
|/ |
|
|
|
|
|
|
|
|
|
| |
setup gets called from the initializer, so it happens more than once in
a test run. Trying to drop the database again after the first process is
connected is.. ineffective. And entirely pointless.
Instead, defer creating the database to start_workers -- which only
happens once, right before we start doing anything real.
|
|
|
|
|
|
|
| |
* Don't swallow output -- if there is any, it's probably useful
* Wait for the process to finish
* Use IPC instead of a sleep
* No need for a pidfile
|
|
|
|
|
|
|
|
| |
Requiring sidekiq/testing changes stuff, so we need to counteract that
after we do so.
And given its potential to confuse things, let's do it up front, at a
predictable point.
|
|\
| |
| | |
Add a "generic" bug report template
|
|/
|
|
|
| |
This template gives contributors a starting point to use when reporting bugs
that does not involve Active Record or Action Pack.
|
|\
| |
| | |
Binding to localhost only allows access to localhost
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This will avoid the indirection of having calling id since we already
know which is the primary key column.
Also this will make explicit the behavior since it is not clear that id
gets the right primary key value and not just the value of the "id"
column.
|
|\ \
| |/
|/| |
Raise StaleObjectError if touched object is stale and locking is enabled
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes #19776
change test variable names and use more verbose on method
less verbose
use _read_attribute instead of send
|
|\ \
| | |
| | | |
add missing require for ArrayInquirer
|
| | | |
|
|\ \ \
| | | |
| | | | |
[ci skip] Fix docs and guide about 'Array.wrap'
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Update association_basics.md [ci skip]
|
| | |/ /
| |/| | |
|
|\ \ \ \
| |/ / /
|/| | | |
Spell out "asynchronously" instead of async in guides [ci skip]
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
To me it seems like this should only be the case if `autosave: true` is
set on the association. However, when implemented that way, it caused
issues with has many associations, where we have explicit tests stating
that child records are updated when the parent is new, even if autosave
is not set (presumably to update the parent id, but other changed
attributes would be persisted as well).
It's quirky, but at least we should be consistently quirky. This
constitutes a minor but subtle change in behavior, and therefore should
not be backported to 4.2 and earlier.
Fixes #19782
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
[Doc] Encourage users to user super to override methods.
[ci skip]
|
| | |/
| |/|
| | | |
IMO we shouldn't encourage users to use methods they shouldn't need to know about. As Song (in this example) inherits from ActiveRecord, we can use super here instead to get the same effect with the bonus of not knowing how active record actually implements these methods.
|
|\ \ \
| | | |
| | | |
| | | | |
Improve documentation for uuid [ci skip]
|
|/ / /
| | |
| | |
| | | |
Add information about usage `uuid` type with `reference`
|
|\ \ \
| | | |
| | | | |
Add missing require for String#strip_heredoc
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
This method is being used in `#xml_http_request`, but was not properly
required. This causes `NoMethodError` on projects that are doing
integration test.
|
|\ \ \
| |_|/
|/| | |
[ci skip] Replace `list` with `array`
|
|/ / |
|
|\ \
| |/
|/| |
[ci skip] Update code example of Enumerable#without
|
|/ |
|
|\
| |
| | |
add active job testing section [ci skip]
|
|/ |
|
|\
| |
| | |
[ci skip] Document running a rake command as a rails command
|
|/ |
|
|\
| |
| | |
fix typo asser url [ci skip]
|
|/ |
|
|\
| |
| | |
[Skip ci] Add information about :host options
|
| |
| |
| |
| |
| |
| | |
Added informations about :host options for each url helper
(#javascript_url, #video_url, #stylesheet_url, etc) based on #asser_url
method.
|
|\ \
| | |
| | | |
Correct small typo.
|
| | |
| | |
| | |
| | | |
* files are written to hard "disk" not "disc".
|
|\ \ \
| |/ /
|/| | |
remove extra `=` in form builder example [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Fix typos and improve the documentation
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 524d40591eaa2f4d007409bfad386f6b107492eb, reversing
changes made to 34d3a6095100245283861ef480a54d0643bbee4c.
Reasoning behind the revert are in the PR discussion:
https://github.com/rails/rails/pull/19755
- This means that types can no longer cast to/from `Set`, and reasonably
work with `where` (we already have this problem for `array`/`json`
types on pg)
- This adds precedent for every other `Enumerable`, and we can't target
`Enumerable` directly.
- Calling `to_a` on a `Set` is reasonable.
|
|\ \
| | |
| | |
| | |
| | | |
andersonDadario/fix_security_guide_captcha_03_21_2015
Fix security guide captcha 03 21 2015 [ci skip]
|
| | | |
|