aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | Improve == and hash methods on various schema cache structs to be allocation ↵Jean Boussier2019-04-094-32/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | free. The previous implementation would allocate 2 arrays per comparisons. I tried relying on Struct, but they do allocate one Hash inside `Struct#hash`.
* | | | | | | Merge pull request #35912 from dgfitch/masterRafael França2019-04-091-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Clarify exists check in logs
| * | | | | | | Clarify exists check in logsDan Fitch2019-04-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default log messages for Model.exists?, when called from .save on an object which uses scoped uniqueness validation like: class Example < ApplicationRecord validates :field, uniqueness: {scope: parent_id} end can result in slightly misleading logs. An example case: ↳ app/controllers/example_controller.rb:23 (0.2ms) begin transaction ↳ app/controllers/example_controller.rb:39 Example Exists (0.2ms) SELECT 1 AS one FROM "examples" WHERE "examples"."field" IS NULL AND "examples"."parent_id" = ? LIMIT ? [["parent_id", 123], ["LIMIT", 1]] ↳ app/controllers/example_controller.rb:39 (0.1ms) rollback transaction To me, a Rails newbie, this parsed as the following: - started the transaction to create a thing - found that your object exists already! - so we rolled back the transaction (even though the actual cause of the transaction is something that happens after the Exists check.) All this does is add a question mark to the message, to make it clear in the log that this is a check, not a confirmation. This may be kind of silly, but it may save some future goofs by newbs like me.
* | | | | | | | Merge pull request #35913 from baweaver/baweaver/actionpack/named_capturesRafael França2019-04-092-0/+13
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Adds named_captures to MatchData to emulate Regex
| * | | | | | | | Adds named_captures to MatchData to emulate RegexBrandon Weaver2019-04-092-0/+13
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds a `named_captures` method to `ActionDispatch::Journey::Path::MatchData` in order to emulate a similar method present on `Regex`'s `MatchData` present in Ruby core. This method can be useful for introspection of routes without the need to use `zip` while testing or developing in Rails core.
* | | | | | | | Merge pull request #35905 from BatedUrGonnaDie/dont-override-job-seed-adapterRafael França2019-04-093-2/+25
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Only override async adapter when seeding
| * | | | | | | Only override async adapter when seedingBatedUrGonnaDie2019-04-093-2/+25
| | | | | | | |
* | | | | | | | Merge pull request #35909 from simi/alias-postgresql-adapterRyuta Kamizono2019-04-101-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Bring back postgresql_version as an alias.
| * | | | | | | | Bring back postgresql_version as an alias.Josef Šimánek2019-04-091-0/+1
| | | | | | | | |
* | | | | | | | | Remove duplicated attribute alias resolution in `_select!`Ryuta Kamizono2019-04-092-6/+4
| |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | This is also resolved in `arel_column`.
* | | | | | | | Better spread out the railties testsMatthew Draper2019-04-091-2/+39
| | | | | | | |
* | | | | | | | `get_database_version` is not public API [ci skip]Ryuta Kamizono2019-04-091-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #35904 from xrav3nz/fix/action-mailbox/test-helper-argsGeorge Claghorn2019-04-091-6/+6
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | FIX: ActionMailbox test helper argument list
| * | | | | | | FIX: ActionMailbox test helper argument listKyle Zhao2019-04-091-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `receive_inbound_email_from_source` should accept an argument list (`*args`) instead, to allow for the `source` argument in `create_inbound_email_from_source`. ```ruby receive_inbound_email_from_source(source, status: :processing) ``` Accepting a keyword argument list (`**kwargs`) results in an `ArgumentError` ```text ArgumentError: wrong number of arguments (given 1, expected 0) ```
* | | | | | | | cleanup up constant in test suiteXavier Noria2019-04-091-0/+1
| |/ / / / / / |/| | | | | |
* | | | | | | depend on Zeitwerk 2.1.0Xavier Noria2019-04-096-25/+83
| |/ / / / / |/| | | | |
* | | | | | Merge pull request #35903 from ryohashimoto/fix_upsert_method_commentप्रथमेश Sonpatki2019-04-091-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | [ci skip] Fix `#upsert` method comment
| * | | | | Fix upsert method commentRyo Hashimoto2019-04-091-1/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | Because this method only updates or inserts a single record like `insert` method.
* | | | | s/Travis/Buildkite/Matthew Draper2019-04-094-8/+8
| | | | |
* | | | | Merge pull request #34800 from mqchau/mysqlCountDeleteRowInLockMatthew Draper2019-04-092-1/+31
|\ \ \ \ \ | | | | | | | | | | | | Wrap Mysql count of deleted rows in lock block to avoid conflict in test
| * | | | | Wrap Mysql count of deleted rows in lock block to avoid conflict in testQuan Chau2019-04-082-1/+31
| | | | | |
* | | | | | Merge pull request #35887 from kamipo/argument_errorRyuta Kamizono2019-04-0910-18/+40
|\ \ \ \ \ \ | | | | | | | | | | | | | | Raise `ArgumentError` for invalid `:limit` and `:precision` like as other options
| * | | | | | Raise `ArgumentError` for invalid `:limit` and `:precision` like as other ↵Ryuta Kamizono2019-04-0710-18/+40
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | options When I've added new `:size` option in #35071, I've found that invalid `:limit` and `:precision` raises `ActiveRecordError` unlike other invalid options. I think that is hard to distinguish argument errors and statement invalid errors since the `StatementInvalid` is a subclass of the `ActiveRecordError`. https://github.com/rails/rails/blob/c9e4c848eeeb8999b778fa1ae52185ca5537fffe/activerecord/lib/active_record/errors.rb#L103 ```ruby begin # execute any migration rescue ActiveRecord::StatementInvalid # statement invalid rescue ActiveRecord::ActiveRecordError, ArgumentError # `ActiveRecordError` except `StatementInvalid` is maybe an argument error end ``` I'd say this is the inconsistency worth fixing. Before: ```ruby add_column :items, :attr1, :binary, size: 10 # => ArgumentError add_column :items, :attr2, :decimal, scale: 10 # => ArgumentError add_column :items, :attr3, :integer, limit: 10 # => ActiveRecordError add_column :items, :attr4, :datetime, precision: 10 # => ActiveRecordError ``` After: ```ruby add_column :items, :attr1, :binary, size: 10 # => ArgumentError add_column :items, :attr2, :decimal, scale: 10 # => ArgumentError add_column :items, :attr3, :integer, limit: 10 # => ArgumentError add_column :items, :attr4, :datetime, precision: 10 # => ArgumentError ```
* | | | | | Merge pull request #35890 from kamipo/except_table_name_from_columnRyuta Kamizono2019-04-097-49/+48
|\ \ \ \ \ \ | | | | | | | | | | | | | | Except `table_name` from column objects
| * | | | | | Except `table_name` from column objectsRyuta Kamizono2019-04-087-49/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `table_name` was added at #23677 to detect whether serial column or not correctly. We can do that detection before initialize column object, it makes column object size smaller, and it probably helps column object de-duplication.
* | | | | | | Merge pull request #35888 from ↵Eileen M. Uchitelle2019-04-081-8/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | lxxxvi/documentation_change_foreign_keys_to_bigint_in_association_basics change `t.integer` to `t.bigint` where applicable
| * | | | | | | change `t.integer` to `t.bigint` where applicablelxxxvi2019-04-071-8/+8
| | |/ / / / / | |/| | | | |
* | | | | | | Merge pull request #35892 from ryohashimoto/bulk_insert_logsEileen M. Uchitelle2019-04-082-1/+53
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Improve log messages for #insert_all` / `#upsert_all` etc. methods
| * | | | | | | Improve log messages for #insert_all` / `#upsert_all` / `#insert` / `#upsert ↵Ryo Hashimoto2019-04-082-1/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | etc. methods In #35077, `#insert_all` / `#upsert_all` / `#insert` / `#upsert` etc. methods are added. But Active Record logs only “Bulk Insert” log messages when they are invoked. This commit improves the log messages to use collect words for how invoked them.
* | | | | | | | Merge pull request #35897 from soartec-lab/update_guide_engineRafael França2019-04-081-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Update configuration of `app` directory and use oxford comma [skip ci]
| * | | | | | | | Update configuration of `app` directory and use oxford comma [skip ci]soartec-lab2019-04-091-2/+2
| | | | | | | | |
* | | | | | | | | Merge pull request #35854 from boblail/fix-bug-with-insert_all-on-mysqlRyuta Kamizono2019-04-083-4/+42
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | When skipping duplicates in bulk insert on MySQL, avoid assigning an AUTONUMBER column when not specified
| * | | | | | | | When skipping duplicates in bulk insert on MySQL, avoid assigning id when ↵Bob Lail2019-04-083-4/+42
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | not specified If `id` is an `AUTONUMBER` column, then my former strategy here of assigning `no_op_column` to an arbitrary column would fail in this specific scenario: 1. `model.columns.first` is an AUTONUMBER column 2. `model.columns.first` is not assigned in the insert attributes I added three tests: the first test covers the actual error; the second test documents that this _isn't_ a problem when a value is given for the AUTONUMBER column and the third test ensures that this no-op strategy isn't secretly doing an UPSERT.
* | | | | | | | Merge pull request #35883 from alexcameron89/add_ar_release_notesप्रथमेश Sonpatki2019-04-081-0/+227
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | [ci-skip] Add 6.0 Release Notes for Active Record
| * | | | | | | [ci skip] Add 6.0 Release Notes for Active RecordAlex Kitchens2019-04-081-0/+227
| | |/ / / / / | |/| | | | |
* | | | | | | Fix GROUP BY with calculate longer name field to respect `table_alias_length`Ryuta Kamizono2019-04-086-11/+30
| |/ / / / / |/| | | | | | | | | | | | | | | | | Follow up of c9e4c848eeeb8999b778fa1ae52185ca5537fffe.
* | | | | | depend on Zeitwerk 2Xavier Noria2019-04-076-7/+28
|/ / / / /
* | | | | Don't repeat same expression in SELECT and GROUP BY clausesRyuta Kamizono2019-04-061-26/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactors `execute_grouped_calculation` and slightly changes generated GROUP BY queries, since I'd not prefer to repeat same expression in SELECT and GROUP BY clauses. Before: ``` SELECT COUNT(*) AS count_all, "topics"."author_name" AS topics_author_name, COALESCE(type, title) AS coalesce_type_title FROM "topics" GROUP BY "topics"."author_name", COALESCE(type, title) ``` After: ``` SELECT COUNT(*) AS count_all, "topics"."author_name" AS topics_author_name, COALESCE(type, title) AS coalesce_type_title FROM "topics" GROUP BY topics_author_name, coalesce_type_title ``` Although we generally don't guarantee to support Arel node constructed by user itself, this also fixes #24207.
* | | | | There is no need to check `null_relation?` in `empty_scope?`Ryuta Kamizono2019-04-063-1/+8
| | | | | | | | | | | | | | | | | | | | `values[:extending]` includes `NullRelation` if `null_relation?`.
* | | | | Association loading isn't to be affected by null relation scopingRyuta Kamizono2019-04-063-3/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #35868. Closes #19349.
* | | | | Merge pull request #35868 from ↵Ryuta Kamizono2019-04-064-8/+48
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/association_isnt_to_be_affected_by_scoping_consistently Association loading isn't to be affected by scoping consistently
| * | | | | Association loading isn't to be affected by scoping consistentlyRyuta Kamizono2019-04-054-8/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-up of 5c71000, #29834, and #30271. Currently, preloading and eager loading are not to be affected by scoping, with the exception of `unscoped`. But non eager loaded association access is still affected by scoping. Although this is a breaking change, the association loading will work consistently whether preloaded / eager loaded or not. Before: ```ruby Post.where("1=0").scoping do Comment.find(1).post # => nil Comment.preload(:post).find(1).post # => #<Post id: 1, ...> Comment.eager_load(:post).find(1).post # => #<Post id: 1, ...> end ``` After: ```ruby Post.where("1=0").scoping do Comment.find(1).post # => #<Post id: 1, ...> Comment.preload(:post).find(1).post # => #<Post id: 1, ...> Comment.eager_load(:post).find(1).post # => #<Post id: 1, ...> end ``` Fixes #34638. Fixes #35398.
* | | | | | The default value without loading railtie is false [ci skip] (#35881)प्रथमेश Sonpatki2019-04-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/pull/35873#issuecomment-480333333 for reference [Prathamesh Sonpatki, bogdanvlviv]
* | | | | | Merge pull request #35873 from prathamesh-sonpatki/enqueuing-fixesEileen M. Uchitelle2019-04-052-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix the deprecation warning about `config.active_job.return_false_on_aborted_enqueue`
| * | | | | | Fix the deprecation warning about ↵Prathamesh Sonpatki2019-04-052-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `config.active_job.return_false_on_aborted_enqueue` - It will return false in Rails 6.1 not 6.0. Also fixed the default value which is true for new applications.
* | | | | | | Merge pull request #35876 from abhaynikam/fix-typo-for-touch-later-test-caseRyuta Kamizono2019-04-051-1/+1
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | Fix typo for touch later test description. laster -> later
| * | | | | | Fix typo for touch later test description. laster -> laterAbhay Nikam2019-04-051-1/+1
|/ / / / / /
* | | | | | Add Active Job release notes [ci skip] (#35872)प्रथमेश Sonpatki2019-04-052-2/+48
| | | | | |
* | | | | | Merge pull request #35871 from kamipo/klass_level_touch_allRyuta Kamizono2019-04-053-2/+34
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add missing `touch_all` delegation to relation
| * | | | | | Add missing `touch_all` delegation to relationRyuta Kamizono2019-04-053-2/+34
| | |/ / / / | |/| | | | | | | | | | | | | | | | Follow up of #31513.
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-28 11:25:40 +0000