aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Replaced statement in comment with an assertionPaul Barry2010-06-291-2/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixed error when removing an index from a table name values, which is a ↵J. Pablo Fernández2010-06-292-1/+17
| | | | | | reserved word, with test. Signed-off-by: José Valim <jose.valim@gmail.com>
* No need to check if the attribute exists (this is the same behavior as in ↵José Valim2010-06-291-3/+1
| | | | 2.3) [#4994 state:resolved] and [#5003 state:resolved]
* Push a failing test for issues [#4994] and [#5003].José Valim2010-06-293-1/+23
|
* Revert "Revert "Name compiled render methods". This caused several failures ↵Jeremy Kemper2010-06-291-8/+11
| | | | | | | | on AP test suite for 1.9.2." This reverts commit 9013227e00895ac95f29077229ec2fb156f450b0. minitest was 'running' compiled templates beginning with test!
* Rename _snowman_ to _snowman to be in sync with _method and _csrf_token.José Valim2010-06-293-3/+3
|
* array subtraction should be faster than iterating over all the elementsNeeraj Singh2010-06-291-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* splitting a really long line into multiple lines which is easy on eyesNeeraj Singh2010-06-291-1/+5
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove ActiveRecord::Base#class_name [#379 state:committed]David Trasbo2010-06-292-27/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Tidy up deprecation message for with_exclusive_scope.José Valim2010-06-292-11/+12
|
* Add scoping and unscoped as the syntax to replace the old with_scope and ↵José Valim2010-06-2910-250/+484
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with_exclusive_scope. A few examples: * with_scope now should be scoping: Before: Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end After: Comment.where(:post_id => 1).scoping do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end * with_exclusive_scope now should be unscoped: class Post < ActiveRecord::Base default_scope :published => true end Post.all #=> SELECT * FROM posts WHERE published = true Before: Post.with_exclusive_scope do Post.all #=> SELECT * FROM posts end After: Post.unscoped do Post.all #=> SELECT * FROM posts end Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values: Post.unscoped.all #=> SELECT * FROM posts
* Revert "Name compiled render methods". This caused several failures on AP ↵José Valim2010-06-291-11/+8
| | | | | | test suite for 1.9.2. This reverts commit 2c4f8aae5ca8489bb3e47712f50b3f57015811d9.
* Remove unneeded rejectSantiago Pastorino2010-06-281-8/+1
|
* with_exclusive_scope does not work properly if ARel is passed. It does work ↵Neeraj Singh2010-06-293-1/+26
| | | | | | | | nicely if hash is passed. Blow up if user is attempting it pass ARel to with_exclusive_scope. [#3838 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Use caller for helpers_dir deprecation warningsJeremy Kemper2010-06-281-2/+2
|
* Slice new buffer from beginning of old buffer to skip encoding special caseJeremy Kemper2010-06-281-3/+1
|
* Name compiled render methodsJeremy Kemper2010-06-281-8/+11
|
* returning -> tapJeremy Kemper2010-06-281-5/+4
|
* ETag: use body instead of @body since the method will always return a stringJeremy Kemper2010-06-281-2/+2
|
* Don't store incorrect values in zones_mapSantiago Pastorino2010-06-283-5/+7
| | | | | | [#4942 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com>
* test that unknown zones don't store mapping keysLeigh Caplan2010-06-281-0/+5
| | | | | | | [#4942] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: José Valim <jose.valim@gmail.com>
* Make the sentinel flag for route a bit more robust.José Valim2010-06-281-1/+1
|
* Tidy up valid conditions in router a bit.José Valim2010-06-281-2/+4
|
* Add :controller and :action to the list of valid conditionsAndrew White2010-06-281-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Do not trigger the old mapper to avoid deprecation messages.José Valim2010-06-281-1/+1
|
* Restores the escaping of urls generated from hashes. [#4765 state:resolved]Andrew White2010-06-282-9/+5
| | | | | | | | | | | | | | HTML specifications recommend the escaping of urls in web pages, which url_for does by default for string urls and consquently urls generated by path helpers as these return strings. Hashes passed to url_for are not escaped by default and this commit reverses this default so that they are escaped. Undoes the changes of this commit: http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944 Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge :constraints from scope into resource options [#2694 state:resolved]Andrew White2010-06-282-4/+49
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Convert instance_variables to symbols before excluding internal vars [#4965 ↵rohit2010-06-281-1/+1
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove invalid conditions from route [#4989 state:resolved]Andrew White2010-06-283-4/+26
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Deprecate the old router DSL. Since it is still used intensively across ↵José Valim2010-06-283-15/+25
| | | | ActionPack test suite, patches that translates Rails internal tests to the new router DSL are welcome (note though that a few tests shouldn't be translated since they are testing exactly the old mapper API, like the ones in actionpack/test/controller/resource_test.rb and actionpack/test/controller/routing_test.rb)
* Strip_tags never ending attribute should not raise a TypeError [#4870 ↵Bruno Michel2010-06-283-0/+6
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Update CHANGELOGs.José Valim2010-06-283-2/+10
|
* Information about new rake task in CHANGELOGŁukasz Strzałkowski2010-06-281-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Small typowycats2010-06-271-1/+1
|
* Add this rule to run common tests and specifics ones from adapters dirSantiago Pastorino2010-06-271-1/+3
|
* Avoid "no such table" exception when schema migrations table does not existAkira Matsuda2010-06-271-0/+5
| | | | | | [#4990 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Use ActiveRecord::Migrator.schema_migrations_table_name instead of ↵Akira Matsuda2010-06-271-1/+1
| | | | | | hardcoding "schema_migrations" Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix several known web encoding issues:wycats2010-06-277-198/+318
| | | | | | | | | | | | | | | | | | | | | | | * Specify accept-charset on all forms. All recent browsers, as well as IE5+, will use the encoding specified for form parameters * Unfortunately, IE5+ will not look at accept-charset unless at least one character in the form's values is not in the page's charset. Since the user can override the default charset (which Rails sets to UTF-8), we provide a hidden input containing a unicode character, forcing IE to look at the accept-charset. * Now that the vast majority of web input is UTF-8, we set the inbound parameters to UTF-8. This will eliminate many cases of incompatible encodings between ASCII-8BIT and UTF-8. * You can safely ignore params[:_snowman_] TODO: * Validate inbound text to confirm it is UTF-8 * Combine the whole_form implementations in form_helper_test and form_tag_helper_test
* Add missing require, Base use deprecate methodSantiago Pastorino2010-06-271-0/+1
|
* rake db:migrate:status displays status of migrations [#4947 state:resolved]Kevin Skoglund2010-06-281-0/+25
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Warn that ActiveRecord::Base.reset_subclasses is gone in Rails 3 final.Jeremy Kemper2010-06-271-0/+12
|
* Upgrade to Rack 1.2.1Jeremy Kemper2010-06-272-9/+15
|
* Implemented getbyte as an aliased method and RDoc addedSantiago Pastorino2010-06-281-3/+2
| | | | Signed-off-by: Xavier Noria <fxn@hashref.com>
* Update to latest rails.jsJeremy Kemper2010-06-271-57/+114
| | | | [#4411 state:resolved]
* Vendor unreleased rack-mount 0.6.6.pre dependencyJeremy Kemper2010-06-2737-3/+4016
|
* Missing BigDecimal dependencyJeremy Kemper2010-06-271-0/+2
|
* Move sqlite to sqlite3 for this tests to be run only on sqlite3 adapterSantiago Pastorino2010-06-282-0/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* AV::logger returns AC::logger if it's defined, workaround meanwhile AV ↵Santiago Pastorino2010-06-281-2/+3
| | | | | | doesn't have it's own logger Signed-off-by: José Valim <jose.valim@gmail.com>
* Move Rails module to abstract_unit to make test in isolation workSantiago Pastorino2010-06-282-3/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Makes more sense to ask about method_defined?Santiago Pastorino2010-06-281-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-06 00:45:57 +0000