| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Introduce default_headers. closes #6311 #6515
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
Bertg/activemodel_naming_helpers_try_model_name_first
Naming helpers should first check if passed object responds to model_name
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
stevecj/fix-psql-reconnect-after-simulated-disconnect-test
Fix only-once stub logic.
|
| | |
| | |
| | |
| | |
| | | |
Didn't fail the test because adapter#query happens to
not call raw connection's #query, but don't want to count
on that and have a fragile test.
|
| | | |
|
| | |
| | |
| | |
| | | |
can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH*
|
|\| |
| |/
|/|
| |
| | |
stevecj/fix-psql-reconnect-after-simulated-disconnect-test
Fix just-plain-wrongness of psql auto-reconnect test.
|
| |
| |
| |
| |
| |
| | |
Full test requiring manual intervention was fine, but
w/ simulated disconnect, assertion was backward & still
passing. Was several kinds of wrong.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We recommend the use of Unobtrusive JavaScript instead. For example:
link_to "Greeting", "#", :class => "nav_link"
$(function() {
$('.nav_link').click(function() {
// Some complex code
return false;
});
});
or
link_to "Greeting", '#', onclick: "alert('Hello world!'); return false", class: "nav_link"
for simple cases.
This reverts commit 3acdd652e9fe99481c879c84c5807a84eb9ad724.
|
| | |
|
| | |
|
| |
| |
| |
| | |
called out at the top level
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
Reason: ActiveSupport::JSON::Variable is not used anymore internally. It
was deprecated in 3-2-stable but we reverted all the deprecation for
point releases.
See #6536 and #6546.
Conflicts:
activesupport/lib/active_support/json/variable.rb
|
| |
|
|
|
|
|
|
| |
Reverting because it feels backward to specify a delivery to not
be performed while the e-mail is being composed. It is simpler (and
makes more sense) to delegate the responsibility to the calling code.
|
|
|
|
|
|
|
| |
what this makes ERB files look like.
This reverts commit 46b8bceedd3e47169c50a04c93161424909c75fb, reversing
changes made to 2f58795e783150f2e1b1f6c64e305703f0061129.
|
|
|
|
| |
basic data". I dont consider this something most people is going to want most of the time. If you want to add it in your own app, knock yourself out. But it doesnt belong in Rails imo
|
|\
| |
| | |
Restore "%" ERb/Erubis Trim Mode
|
| |
| |
| |
| | |
percent sign on a line to indicate non-inserted Ruby code.
|
|/ |
|
|\
| |
| | |
Do not include application.js if it doesn't exists
|
| | |
|
|/
|
|
|
|
| |
Rails were including 'application.js' to the pack when using
`javascript_include_tag :all` even there's no application.js in the
public directory.
|
|\
| |
| | |
add changelog for #7202
|
|/ |
|
|\
| |
| | |
Add AS::StringInquirer#respond_to? method
|
| |
| |
| |
| | |
Consistently with #method_missing
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Make sure :environment task is executed before db:schema:load or
db:structure:load
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
db:structure:load
Otherwise, if schema_format = :sql, you will see:
$ rake db:setup --trace
** Invoke db:setup (first_time)
** Invoke db:schema:load_if_ruby (first_time)
** Invoke db:create (first_time)
** Invoke db:load_config (first_time)
** Invoke rails_env (first_time)
** Execute rails_env
** Execute db:load_config
** Execute db:create
db_example_development already exists
db_example_test already exists
** Execute db:schema:load_if_ruby #<-------- :environment hasn't been executed yet
** Invoke db:schema:load (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute db:schema:load
~/db_example/db/schema.rb doesn't exist yet. Run `rake db:migrate` to create it then try again.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
by Active Support)
Selecting which key extensions to include in active_support/rails
made apparent the systematic usage of Object#in? in the code base.
After some discussion in
https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d
we decided to remove it and use plain Ruby, which seems enough
for this particular idiom.
In this commit the refactor has been made case by case. Sometimes
include? is the natural alternative, others a simple || is the
way you actually spell the condition in your head, others a case
statement seems more appropriate. I have chosen the one I liked
the most in each case.
|
|\ \ \
| |_|/
|/| | |
Changing AR:CollectionAssociation#empty? to use #exists?
|
|/ /
| |
| |
| |
| | |
COUNT(*) queries can be slow in PostgreSQL, #exists? avoids this by
selecting a single record.
|
|\ \
| | |
| | | |
Remove warning: `*' interpreted as argument prefix
|
|/ / |
|
| |
| |
| |
| |
| | |
Passing options as the last value in an array doesn't work with form_for.
This reverts commit 61c8a4d926343903593a27080216af7e4ed81268.
|
| |
| |
| |
| |
| | |
Passing options as the last value in an array doesn't work with form_for.
This reverts commit 6be564c7a087773cb0b51c54396cc190e4f5c983.
|
|\ \
| | |
| | | |
Refator route set
|