aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Merge pull request #32397 from yhirano55/remove_needless_images_in_guidesXavier Noria2018-03-3141-15/+10
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Remove needless images in guides
| * | | | | | | Remove needless images in guidesYoshiyuki Hirano2018-03-3128-5/+0
| | | | | | | |
| * | | | | | | Put images into each page's dir in guidesYoshiyuki Hirano2018-03-3113-10/+10
| | |/ / / / / | |/| | | | |
* | | | | | | Merge pull request #32394 from yskkin/key_generatorAndrew White2018-03-312-1/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Deriving `secret_key_base` breaks `key_generator` defined in 5.1.
| * | | | | | | Deriving `secret_key_base` breaks `key_generator` defined in 5.1.Yoshiyuki Kinjo2018-03-312-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If one created Rails 5.1 app and then updated to 5.2, `secret_key_base` defined in `config/secrets.yml` is ignored for `development` and `test` environment. A change in `secret_key_base` in turn breaks `Rails.application.key_generator`. If one encrypt data in Rails 5.1, she cannot decrypt it in Rails 5.2 for `development` and `test` environment.
* | | | | | | | Merge pull request #32395 from yhirano55/use_oxford_comma_style_in_guideAndrew White2018-03-311-1/+1
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | [ci skip] Use Oxford comma style in guide
| * | | | | | | [ci skip] Use Oxford comma style in guideYoshiyuki Hirano2018-03-311-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #32386 from utilum/tmpname_basenameAndrew White2018-03-311-1/+3
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | Fix: FileStoreTest#test_filename_max_size fails in Ruby 2.5.1
| * | | | | | | Fix: FileStoreTest#test_filename_max_size fails in Ruby 2.5.1utilum2018-03-311-1/+3
|/ / / / / / /
* / / / / / / Revert "[ci skip] Capitalize sentence of first char in AS guide"Andrew White2018-03-311-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The text is a continuation of the sentence before the listing so doesn't need to begin with a capital letter. This reverts commit 77a7acafba11fccac8b4cf30a9ce62d43a9ac186.
* | | | | | Merge pull request #32392 from ↵Andrew White2018-03-311-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | yhirano55/capitalize_sentence_of_first_char_in_as_guide [ci skip] Capitalize sentence of first char in AS guide
| * | | | | [ci skip] Capitalize sentence of first char in AS guideYoshiyuki Hirano2018-03-311-1/+1
| | | | | |
* | | | | | Merge pull request #32389 from yhirano55/add_earlier_releases_in_guidesRyuta Kamizono2018-03-311-1/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add earlier releases v3.0, v3.1 in guides
| * | | | | | Add earlier releases links v3.0 and v3.1 in guidesYoshiyuki Hirano2018-03-311-1/+3
| | | | | | |
* | | | | | | Merge pull request #32388 from yhirano55/remove_useless_stylesheet_file_in_guideRyuta Kamizono2018-03-311-50/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Remove useless stylesheet file in guide
| * | | | | | | Remove useless stylesheet file in guideYoshiyuki Hirano2018-03-311-50/+0
| |/ / / / / /
* | | | | | | Bump tested versions of Ruby on CIAndrew White2018-03-311-8/+8
| | | | | | |
* | | | | | | Merge pull request #32390 from yhirano55/modify_twitter_api_link_in_api_guideRyuta Kamizono2018-03-311-1/+1
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | [ci skip] Modify twitter api link in api guide
| * | | | | | [ci skip] Modify twitter api link in api guideYoshiyuki Hirano2018-03-311-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | * The twitter developer site's url was changed.
* | | | | | Merge pull request #32366 from utilum/use_current_configAndrew White2018-03-301-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use current_config in structure_dump
| * | | | | | Use current_config in structure_dumputilum2018-03-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This looks like a typo from 0f0aa6a275876502e002c054896734d6536ba5cd
* | | | | | | Merge pull request #32277 from derekprior/dp-deprecate-force-sslGuillermo Iguaran2018-03-307-90/+62
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Deprecate controller level force_ssl
| * | | | | | | Deprecate controller level force_sslDerek Prior2018-03-307-90/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Today there are two common ways for Rails developers to force their applications to communicate over HTTPS: * `config.force_ssl` is a setting in environment configurations that enables the `ActionDispatch::SSL` middleware. With this middleware enabled, all HTTP communication to your application will be redirected to HTTPS. The middleware also takes care of other best practices by setting HSTS headers, upgrading all cookies to secure only, etc. * The `force_ssl` controller method redirects HTTP requests to certain controllers to HTTPS. As a consultant, I've seen many applications with misconfigured HTTPS setups due to developers adding `force_ssl` to `ApplicationController` and not enabling `config.force_ssl`. With this configuration, many application requests can be served over HTTP such as assets, requests that hit mounted engines, etc. In addition, because cookies are not upgraded to secure only in this configuration and HSTS headers are not set, it's possible for cookies that are meant to be secure to be sent over HTTP. The confusion between these two methods of forcing HTTPS is compounded by the fact that they share an identical name. This makes finding documentation on the "right" method confusing. HTTPS throughout is quickly becomming table stakes for all web sites. Sites are expected to operate over HTTPS for all communication, sensitive or otherwise. Let's encourage use of the broader-reaching `ActionDispatch::SSL` middleware and elminate this source of user confusion. If, for some reason, applications need to expose certain endpoints over HTTP they can do so by properly configuring `config.ssl_options`.
* | | | | | | | Merge pull request #32384 from riseshia/remove-expired-documentAndrew White2018-03-301-15/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove expired explanation [ci skip]
| * | | | | | | | Remove expired explanation [ci skip]Shia2018-03-301-15/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Override callback doesn't work anymore.
* | | | | | | | | Remove shadowing variable warningAndrew White2018-03-301-2/+2
|/ / / / / / / /
* | | | | | | | Merge pull request #32383 from freeletics/add-missing-requireRyuta Kamizono2018-03-301-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Adding missing extension for `cattr_accessor` method
| * | | | | | | | Adding missing extension for `cattr_accessor` methodWojciech Wnętrzak2018-03-301-0/+1
|/ / / / / / / /
* | | | | | | | Fix intermittent CI failure due to setting explicit `person.id = 10`Ryuta Kamizono2018-03-301-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/360109429
* | | | | | | | Merge pull request #32338 from eugeneius/dont_clobber_foreign_keyRyuta Kamizono2018-03-302-2/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Don't unset foreign key when preloading missing record
| * | | | | | | | Don't unset foreign key when preloading missing recordEugene Kenny2018-03-242-2/+4
| | |_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a belongs to association's target is set, its foreign key is now updated to match the new target. This is the correct behaviour when a new record is assigned, but not when the existing record is preloaded. As long as we mark the association as loaded, we can skip setting the target when the record is missing and avoid clobbering the foreign key.
* | | | | | | | Short circuit the scoping delegation for `relation.all`Ryuta Kamizono2018-03-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `relation.all` behaves as `relation.scoping { klass.all }`. But it is just enough to `relation.spawn`.
* | | | | | | | Remove unnecessary line break and quotesyuuji.yaginuma2018-03-301-2/+2
| |_|/ / / / / |/| | | | | |
* | | | | | | Fix "--frozen-lockfile" argument used in yarn install rake taskGuillermo Iguaran2018-03-291-1/+1
| | | | | | | | | | | | | | | | | | | | | --frozen-lockfile is the right name of the argument
* | | | | | | Merge pull request #32289 from gsamokovarov/did-you-mean-suggestionsGuillermo Iguaran2018-03-296-57/+14
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Use `did_you_mean` spell checker for option suggestions
| * | | | | | | Use `did_you_mean` spell checker for option suggestionsGenadi Samokovarov2018-03-236-57/+14
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we require Ruby over `2.3`, we can replace the current suggestion methods we have with tooling from the `did_you_mean` gem. There is a small user visible change and this is that we now offer a single suggestion for misspelled options. We are suggesting fixes during generator invocation and during a mistyped rails server rack handler. In both cases, if we don't make a proper prediction on the first match, we won't do so in the second or third one, so in my mind, this is okay.
* | | | | | | Merge pull request #32243 from maschwenk/patch-2Guillermo Iguaran2018-03-291-1/+1
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | [Webpack] Raise an error when lockfile diff is generated
| * | | | | | Raise an error when lockfile diff is generatedMax Schwenk2018-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | https://yarnpkg.com/en/docs/cli/install#toc-yarn-install-frozen-lockfile
* | | | | | | Merge pull request #32370 from riseshia/patch-1Andrew White2018-03-291-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Compare ruby version with correct way
| * | | | | | | Compare ruby version with correct wayShia2018-03-291-1/+1
|/ / / / / / /
* | | | | | | Merge pull request #30956 from CJStadler/with-lock-changed-deprecationRafael França2018-03-284-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix deprecation warnings from with_lock
* | | | | | | Bump rack-test to 1.0.0Yuji Yaginuma2018-03-281-1/+1
| | | | | | |
* | | | | | | Merge pull request #32299 from davidstosik/expose-fk-ignore-patternGuillermo Iguaran2018-03-277-3/+43
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Expose foreign key name ignore pattern in configuration
| * | | | | | | Move fk_ignore_pattern from config.active_record to SchemaDumperDavid Stosik2018-03-226-16/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes more sense, as the foreign key ignore pattern is only used by the schema dumper.
| * | | | | | | Test config.active_record.fk_ignore_patternDavid Stosik2018-03-201-0/+8
| | | | | | | |
| * | | | | | | Document config.active_record.fk_ignore_patternDavid Stosik2018-03-202-0/+10
| | | | | | | |
| * | | | | | | Expose foreign key name ignore pattern in configurationDavid Stosik2018-03-197-2/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When dumping the database schema, Rails will dump foreign key names only if those names were not generate by Rails. Currently this is determined by checking if the foreign key name is `fk_rails_` followed by a 10-character hash. At [Cookpad](https://github.com/cookpad), we use [Departure](https://github.com/departurerb/departure) (Percona's pt-online-schema-change runner for ActiveRecord migrations) to run migrations. Often, `pt-osc` will make a copy of a table in order to run a long migration without blocking it. In this copy process, foreign keys are copied too, but [their name is prefixed with an underscore to prevent name collision ](https://www.percona.com/doc/percona-toolkit/LATEST/pt-online-schema-change.html#cmdoption-pt-online-schema-change-alter-foreign-keys-method). In the process described above, we often end up with a development database that contains foreign keys which name starts with `_fk_rails_`. That name does not match the ignore pattern, so next time Rails dumps the database schema (eg. when running `rake db:migrate`), our `db/schema.rb` file ends up containing those unwanted foreign key names. This also produces an unwanted git diff that we'd prefer not to commit. In this PR, I'd like to suggest a way to expose the foreign key name ignore pattern to the Rails configuration, so that individual projects can decide on a different pattern of foreign keys that will not get their names dumped in `schema.rb`.
* | | | | | | | Merge pull request #32317 from dwightwatson/32247George Claghorn2018-03-263-4/+24
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Flip the order of the after_create callbacks
| * | | | | | | | Flip the order of the after_create callbacksDwight Watson2018-03-273-4/+24
| | |_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses rails/rails#32247 Add test that checks identify and analyze work in correct order Break out direct upload test helper Review changes for direct-upload test helper
* | | | | | | | Merge pull request #32185 from nholden/human_readable_date_time_comparisonsRafael França2018-03-269-0/+63
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add `before?` and `after?` methods to date and time classes
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-22 22:50:53 +0000