aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Per #9999 revert the revert changing so columns are only tested for empty? ↵Sam2013-04-032-15/+29
| | | | | | as opposed to blank? This is both faster and more correct, added tests to make sure this is not reverted again.
* CHANGELOG entry for rails.png removal.Steve Klabnik2013-04-021-0/+5
|
* We don't need to remove index.html any more.Steve Klabnik2013-04-021-1/+0
| | | | | Since it's not a real file any longer, no need to worry about removing it when we reset the dummy.
* .gitkeep -> .keepSteve Klabnik2013-04-021-0/+0
| | | | Mentioned in a comment in e90c2d029edc by @frodsan.
* Merge pull request #10061 from trevorturk/dummy-key-generator-renameSantiago Pastorino2013-04-028-18/+18
|\ | | | | Rename DummyKeyGenerator -> LegacyKeyGenerator
| * Rename DummyKeyGenerator -> LegacyKeyGeneratorTrevor Turk2013-04-028-18/+18
| |
* | Merge pull request #10060 from trevorturk/cookies-refactoringJeremy Kemper2013-04-021-28/+25
|\ \ | | | | | | Cookies refactoring
| * | :scissors: spacing after privateTrevor Turk2013-04-021-3/+0
| | |
| * | Be consistent when talking about cookies, key -> nameTrevor Turk2013-04-021-25/+25
| | |
* | | Merge pull request #10059 from trevorturk/perm-cookie-jar-fixSteve Klabnik2013-04-022-2/+7
|\| | | |/ |/| Fix permanent cookie jar accessor typo
| * Fix permanent cookie jar accessor typoTrevor Turk2013-04-022-2/+7
|/
* Fix tests from rails.png removal.Jessica Lynn Suttles2013-04-021-1/+8
| | | | | I'm giving @jlsuttles credit on this commit because she gave me the idea and the actual converted image in 952289aabfb.
* Merge pull request #10056 from steveklabnik/remove_rails_pngDavid Heinemeier Hansson2013-04-023-1/+1
|\ | | | | Remove rails.png.
| * adding .gigkeep to default app/assets/imagesSteve Klabnik2013-04-021-0/+0
| |
| * Remove rails.png.Steve Klabnik2013-04-022-1/+1
| | | | | | | | | | | | | | No reason to have a file, we've got data-URIs now! It didn't make sense to me that you no longer have to remove public/index.html, but you still need to remove rails.png. This means that you won't have to any more when making a new Rails app.
* | Merge pull request #10054 from rubys/use_find_by_in_rdocSantiago Pastorino2013-04-0210-23/+23
|\ \ | | | | | | Prefer find_by over dynamic finders in rdoc
| * | Prefer find_by over dynamic finders in rdocSam Ruby2013-04-0210-23/+23
| |/
* | Merge pull request #10055 from vipulnsward/remove_each_with_index_in_testSantiago Pastorino2013-04-021-1/+1
|\ \ | |/ |/| each_with_index => each as we dont use index
| * each_with_index => each as we dont use indexVipul A M2013-04-031-1/+1
| |
* | Merge pull request #10053 from ↵Steve Klabnik2013-04-021-6/+30
|\ \ | |/ |/| | | | | wangjohn/change_docs_for_associations_distinctness Changed the guides for associations, warning about race conditions when checking for distinctness
| * Changed the guides to use distinct instead of uniq for associations (seewangjohn2013-04-021-6/+30
| | | | | | | | | | | | commit a1bb6c8b which changes the naming). I've also provided an example of how distinctness when inserting into an association can be achieved.
* | Merge pull request #3782 from arunagw/warning_mode_onSantiago Pastorino2013-04-021-1/+1
|\ \ | | | | | | Turning on warnings in "rake test" for railties
| * | Turning on warnings in "rake test" for railtiesArun Agrawal2013-04-011-1/+1
| | |
* | | Merge pull request #9975 from ↵Aaron Patterson2013-04-022-14/+20
|\ \ \ | | | | | | | | | | | | | | | | mmangino/raise_when_attributes_cant_be_unserialized Unserializing YAML attributes can silently fail in development mode
| * | | Remove all error masking when decoding serialized data fails?Mike Mangino2013-04-022-15/+12
| | | |
| * | | Raise an exception when unserialization fails due to a missing classMike Mangino2013-03-282-1/+10
| | | |
* | | | Merge pull request #9971 from kennyj/refactor_tasksRafael Mendonça França2013-04-0211-61/+450
|\ \ \ \ | | | | | | | | | | Extract Firebird / Sqlserver / Oracle database tasks, and They should be deprecated.
| * | | | Add CHANGELOG entry about extracting and deprecating ↵kennyj2013-04-031-0/+5
| | | | | | | | | | | | | | | | | | | | Firebird/Sqlserver/Oracle database tasks.
| * | | | Show deprecated messages only when target database adapters definedYasuo Honda2013-04-033-3/+3
| | | | |
| * | | | Fix tiny problem: change method order for consistency and fix wrong method name.kennyj2013-04-032-2/+2
| | | | |
| * | | | Suppress deprecation messages for deprecated database tasks, when executing ↵kennyj2013-04-033-0/+21
| | | | | | | | | | | | | | | | | | | | rails's testcases.
| * | | | Add deprecation message on Firebird / Sqlserver / Oracle database tasks.kennyj2013-04-033-0/+3
| | | | |
| * | | | Extract Oracle database tasks.kennyj2013-04-035-31/+140
| | | | |
| * | | | Extract Sqlserver database tasks.kennyj2013-04-035-11/+131
| | | | |
| * | | | Extract Firebird database tasks.kennyj2013-04-035-20/+151
| | | | |
* | | | | Merge pull request #10052 from neerajdotname/stdout-in-logRafael Mendonça França2013-04-022-2/+6
|\ \ \ \ \ | |/ / / / |/| | | | write sql queries to terminal
| * | | | write sql queries to terminalNeeraj Singh2013-04-022-2/+6
| | | | |
* | | | | Merge pull request #10050 from neerajdotname/no-need-of-to_s-before-internRafael Mendonça França2013-04-021-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | no need to invoke to_s before applying intern
| * | | | no need to invoke to_s before applying internNeeraj Singh2013-04-021-1/+1
|/ / / /
* | | | Merge pull request #10048 from ↵Rafael Mendonça França2013-04-021-17/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | senny/replace_merge_with_relation_calls_in_count_api replace #merge with relation API calls in calculations_test.
| * | | | replace #merge with relation API calls in calculations_test.Yves Senn2013-04-021-17/+13
| | |_|/ | |/| |
* | | | Merge pull request #10038 from nateberkopec/sti-new-with-complex-inheritanceRafael Mendonça França2013-04-022-1/+5
|\ \ \ \ | | | | | | | | | | Fix regression re: #new with an STI object & complex inheritance
| * | | | Fix #new with an STI object with complex inheritanceNate Berkopec2013-04-022-1/+5
| | | | |
* | | | | Use released sdocSantiago Pastorino2013-04-021-1/+1
| |/ / / |/| | |
* | | | Merge pull request #10041 from vipulnsward/more_destructive_mergeSantiago Pastorino2013-04-022-2/+2
|\ \ \ \ | | | | | | | | | | change merge to merge! in AS on new hashes
| * | | | change merge to merge! in AS on new hashesVipul A M2013-04-022-2/+2
| | | | |
* | | | | Merge pull request #10042 from choudhuryanupam/fix_activesupport_testSantiago Pastorino2013-04-026-25/+37
|\ \ \ \ \ | |/ / / / |/| | | | Added missing assert
| * | | | Added missing assertAnupam Choudhury2013-04-026-25/+37
|/ / / /
* | | | Revert "Use jquery-rails from github"Santiago Pastorino2013-04-021-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7a9a7007637b8279501770be03bd84ce83d61ab8. Conflicts: railties/lib/rails/generators/app_base.rb
* | | | Revert "Use jquery-rails from github (fix Gem::Version error)"Santiago Pastorino2013-04-011-1/+1
|/ / / | | | | | | | | | This reverts commit 6f3f0f86332004fcee5c2f05d52bbff08c22f980.