aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix `select_all` with legacy `binds`Ryuta Kamizono2017-02-122-1/+14
| | | | Fixes #27923.
* Deprecate calling `attr_will_change!` with non-attributesSean Griffin2017-02-113-3/+26
| | | | | | | | | | | | | This was never really intended to work (at least not without calling `define_attribute_methods`, which is less common with Active Record). As we move forward the intention is to require the use of `attribute` over `attr_accessor` for more complex model behavior both on Active Record and Active Model, so this behavior is deprecated. Fixes #27956. Close #27963. [Alex Serban & Sean Griffin]
* [ci skip] Fully qualify missing template error.Kasper Timm Hansen2017-02-111-1/+1
| | | | Switch extension 👉 format as it's more apt here.
* Merge pull request #27870 from kenta-s/get-todo-done-in-render_testKasper Timm Hansen2017-02-112-2/+3
|\ | | | | Get TODO done in `render_test`
| * Add information on `:formats` option in action_view_overview.mdkenta-s2017-02-062-2/+3
| |
* | Fix bigint primary key with unsignedRyuta Kamizono2017-02-102-12/+24
| | | | | | | | | | | | | | Currently schema dumper lost the unsigned option when primary key is defined as bigint with unsigned. This commit fixes the issue. Closes #27960
* | Test with the newest i18nAkira Matsuda2017-02-111-1/+1
| | | | | | | | which is bundled in new apps by default
* | Merge pull request #27904 from ↵Eileen M. Uchitelle2017-02-102-1/+3
|\ \ | | | | | | | | | | | | kenta-s/add-methods-back-to-array-delegation-from-ar-relation Delegate `to_sentence` and `to_fomatted_s` to `records`
| * | Delegate `to_sentence` and `to_fomatted_s` to `records`kenta-s2017-02-042-1/+3
| | |
* | | Merge pull request #27959 from y-yagi/use_released_resqueKasper Timm Hansen2017-02-102-13/+8
|\ \ \ | | | | | | | | Use released resque
| * | | Use released resqueyuuji.yaginuma2017-02-102-13/+8
|/ / /
* | | Merge pull request #27957 from ↵Rafael França2017-02-092-10/+18
|\ \ \ | | | | | | | | | | | | | | | | kamipo/fix_test_composite_primary_key_out_of_order Fix `test_composite_primary_key_out_of_order`
| * | | Revert "Simplify and speed up Postgres query for primary_keys"Ryuta Kamizono2017-02-101-8/+10
| | | | | | | | | | | | | | | | This reverts commit d6529af2954a67bd57fda45286fa9cfd0ff6b5ac.
| * | | Fix `test_composite_primary_key_out_of_order`Ryuta Kamizono2017-02-101-2/+8
| | | | | | | | | | | | | | | | | | | | `test_composite_primary_key_out_of_order` should use `barcodes_reverse` table.
* | | | Fix rubocop violationsRafael Mendonça França2017-02-093-13/+15
|/ / /
* | | Merge pull request #27950 from st0012/update-configuration-guideRafael França2017-02-091-0/+5
|\ \ \ | | | | | | | | Update configuration guide about ActiveRecord's use_schema_cache_dump option [ci skip]
| * | | Update configuration guide about ActiveRecord's config option.Stan Lo2017-02-101-0/+5
|/ / /
* | | Merge pull request #27954 from maclover7/jm-fix-26404Jon Moss2017-02-091-0/+10
|\ \ \ | | | | | | | | Add note about breakage in file uploads in controller tests to upgrading guide
| * | | Add note about breakage in file uploads in controller tests to upgradingJon Moss2017-02-091-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | guide ref #26404 [ci skip]
* | | | Simplify and speed up Postgres query for primary_keysJordan Lewis2017-02-092-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | primary_keys(table) needs to query various metadata tables in Postgres to determine the primary key for the table. Previously, it did so using a complex common table expression against pg_constraint and pg_attribute. This patch simplifies the query by joining pg_index against pg_attribute instead of going through pg_constraint. This avoids an expensive unnest, window function query, and common table expression. EXPLAINing these queries in Postgres against a database with a single table with a composite primary key shows a 66% reduction in the plan and execute latencies. This is significant during application startup time, especially against very large schemas, where these queries would be even slower and more numerous. Closes #27949
* | | | Merge pull request #27952 from dijonkitchen/patch-1Eileen M. Uchitelle2017-02-091-1/+1
|\ \ \ \ | | | | | | | | | | Fix wording
| * | | | Fix wordingJonathan Chen2017-02-091-1/+1
|/ / / /
* | | | Refactor `ColumnDefinition` to contain `options` hashRyuta Kamizono2017-02-0915-128/+59
| | | | | | | | | | | | | | | | | | | | | | | | Column options are passed as an hash args then used as `options` hash in `add_column_options!`. Converting args to attributes is inconvinient for using options as an hash.
* | | | Merge pull request #27945 from betesh/allow-frozen-hashes-to-as_jsonRafael Mendonça França2017-02-083-1/+16
|\ \ \ \ | | | | | | | | | | | | | | | Allow ActiveRecord::Base.as_json to accept a frozen Hash
| * | | | Allow ActiveRecord::Base.as_json to accept a frozen HashIsaac Betesh2017-02-083-1/+16
| | | | |
* | | | | Merge pull request #27935 from namusyaka/fix-hidden-primary_keyRafael França2017-02-085-1/+18
|\ \ \ \ \ | |/ / / / |/| | | | Fix inspection behavior when the :id column is not primary key
| * | | | Fix inspection behavior when the :id column is not primary keynamusyaka2017-02-095-1/+18
|/ / / /
* | | | Merge pull request #27940 from ↵Rafael França2017-02-087-23/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | y-yagi/deprecate_halt_callback_chains_on_return_false deprecate `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`
| * | | | remove `ActiveSupport.halt_callback_chains_on_return_false` from everywhereyuuji.yaginuma2017-02-084-7/+0
| | | | |
| * | | | deprecate `halt_callback_chains_on_return_false` instead of ↵yuuji.yaginuma2017-02-083-16/+7
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `halt_and_display_warning_on_return_false` `halt_and_display_warning_on_return_false` is not a public API and application is using `halt_callback_chains_on_return_false`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults.rb.tt#L29 https://github.com/rails/rails/blob/5-0-stable/activesupport/lib/active_support.rb#L86..L88 Therefore, deprecate messages should be issued for `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`.
* | | | Merge pull request #27938 from y-yagi/remove_link_to_edgeapiJon Moss2017-02-071-1/+1
|\ \ \ \ | | | | | | | | | | remove link to edgeapi [ci skip]
| * | | | remove link to edgeapi [ci skip]yuuji.yaginuma2017-02-081-1/+1
|/ / / /
* | | | Merge pull request #27232 from robin850/guides-linkingXavier Noria2017-02-072-2/+43
|\ \ \ \ | | | | | | | | | | Improve linking inside guides
| * | | | Automatically link to Ruby files referenced in notes [ci skip]Robin Dupret2017-02-071-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To ease reading the "Active Support Core Extensions" guide, let's automatically link references to Ruby files. It's also possible to reference other components' files in the even though it's not used in the guides at the moment. [Petr Skocik & Robin Dupret]
| * | | | Automatically inject the current Rails version in API links [ci skip]Robin Dupret2017-02-072-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To make sure that the user won't look at a feature that doesn't already exist if they are looking at a previous version of the guides, let's automatically inject the Rails version the guides have been generated against.
* | | | | Remove unused code now that the deprecated file was removedRafael Mendonça França2017-02-071-2/+1
| | | | |
* | | | | Merge pull request #25873 from schuetzm/warn_about_dirty_lockRafael Mendonça França2017-02-073-2/+18
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Deprecate locking of dirty records
| * | | | | Deprecate locking of dirty recordsMarc SchĂĽtz2017-02-073-2/+18
| | | | | |
* | | | | | Deprecate halt_and_display_warning_on_return_falseRafael Mendonça França2017-02-072-5/+16
| | | | | |
* | | | | | Remove deprecated behavior that halts callbacks when the return is falseRafael Mendonça França2017-02-0712-188/+24
| | | | | |
* | | | | | Document that string in if and unless option of callbacks are deprecatedRafael Mendonça França2017-02-071-4/+4
| | | | | |
* | | | | | Improve the exception message to direct people to all the possible valuesRafael Mendonça França2017-02-071-1/+2
| | | | | |
* | | | | | Merge pull request #27608 from ↵Rafael França2017-02-077-116/+99
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | kamipo/remove_deprecated_passing_string_to_define_callback Remove deprecated passing string to define callback
| * | | | | Deprecate passing string to `:if` and `:unless` conditional options on ↵Ryuta Kamizono2017-02-045-14/+68
| | | | | | | | | | | | | | | | | | | | | | | | `set_callback` and `skip_callback`
| * | | | | Remove deprecated passing string to define callbackRyuta Kamizono2017-02-045-103/+32
| | |_|/ / | |/| | | | | | | | | | | | | And raise `ArgumentError` when passing string to define callback.
* | | | | Merge pull request #27933 from kamipo/revert_27682Jeremy Daer2017-02-072-3/+3
|\ \ \ \ \ | | | | | | | | | | | | Revert "Remove useless `column_alias` in `subquery_for_count`"
| * | | | | Revert "Remove useless `column_alias` in `subquery_for_count`"Ryuta Kamizono2017-02-072-3/+3
|/ / / / / | | | | | | | | | | | | | | | This reverts commit 28977f1fa3d7b15c1608174a165e60b71ddf3995.
* | | | | Merge pull request #27334 from ↵Jeremy Daer2017-02-0712-31/+79
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/pk_and_ref_columns_should_be_identical_type `primary_key` and `references` columns should be identical type
| * | | | | `primary_key` and `references` columns should be identical typeRyuta Kamizono2017-02-0712-31/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #26266. The default type of `primary_key` and `references` were changed to `bigint` since #26266. But legacy migration and sqlite3 adapter should keep its previous behavior.
* | | | | | Merge pull request #27922 from martijn/reduce-actioncable-loggingJeremy Daer2017-02-072-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Move some ActionCable logs to debug level
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-15 18:41:07 +0000