aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove unnecessary string interpolationMarcelo G. Cajueiro2013-07-091-2/+2
| | | | Removed from controller template of scaffold generator.
* close our connection when we are doneAaron Patterson2013-07-082-14/+17
|
* remove dead codeAaron Patterson2013-07-081-16/+0
|
* if we remove the connection from the pool, we should close itAaron Patterson2013-07-081-0/+1
|
* use latches rather than mucking with the schedulerAaron Patterson2013-07-081-7/+7
|
* Merge pull request #11371 from arunagw/actionview-changesRafael Mendonça França2013-07-083-3/+3
|\ | | | | Actionview changes
| * Removed unused require from actionview rakefile.Arun Agrawal2013-07-091-1/+0
| |
| * Fixed broken rake task for update_version [ci skip]Arun Agrawal2013-07-091-1/+2
| | | | | | | | Also added actionview to update version rake task
| * actionview should be able to install using install.rb [ci skip]Arun Agrawal2013-07-091-1/+1
|/
* Merge pull request #11370 from dpdawson/masterRafael Mendonça França2013-07-081-1/+1
|\ | | | | Fix a grammatical error/typo in Active Record Migrations guide. [ci skip]
| * Fix a grammatical error/typo in Active Record Migrations guide. [ci skip]Daniel Dawson2013-07-081-1/+1
|/
* refactor to_sql so it does not depend on the to_sql implementation ofAaron Patterson2013-07-081-4/+11
| | | | the connection
* Merge pull request #11355 from wangjohn/class_for_rails_commandsRafael Mendonça França2013-07-082-94/+172
|\ | | | | Creating a class for carrying out rails commands.
| * Creating a class for carrying out rails commands.wangjohn2013-07-072-94/+172
| | | | | | | | | | | | This class encapsulates a lot of logic that wasn't very object oriented. Helper methods have been created to try to make things more logical and easy to read.
* | Merge pull request #11367 from artemeff/sass_in_notesRafael Mendonça França2013-07-083-2/+8
|\ \ | | | | | | handle notes in *.sass files
| * | handle notes in *.sass filesYuri Artemev2013-07-083-2/+8
| | |
* | | Merge pull request #11363 from dpdawson/masterCarlos Antonio da Silva2013-07-081-2/+2
|\ \ \ | |/ / |/| | Fix 2 grammatical errors/typos in Active Record Basics guide. [ci skip]
| * | Fix 2 grammatical errors/typos in Active Record Basics guide. [ci skip]Daniel Dawson2013-07-081-2/+2
|/ /
* | Merge pull request #11359 from willnet/patch-1Yves Senn2013-07-081-1/+0
|\ \ | | | | | | Update 'Active Record Migrations' guide [ci skip]
| * | Update 'Active Record Migrations' guide [ci skip]Shinichi Maeshima2013-07-081-1/+0
| |/ | | | | | | Delete an unneeded line.
* | Fix SyntaxError in guides sample codeAkira Matsuda2013-07-081-1/+1
| | | | | | | | [ci skip]
* | 1.9 Hash SyntaxAkira Matsuda2013-07-084-4/+4
| |
* | params keys are StringsAkira Matsuda2013-07-081-13/+13
|/
* Add CHANGELOG entry for #11348Rafael Mendonça França2013-07-071-0/+14
|
* Merge pull request #11348 from sanemat/fix/link-to-blockRafael Mendonça França2013-07-072-1/+8
|\ | | | | Fix actionview link_to with block and url_hash
| * Include block in a argument shiftsanemat2013-07-081-6/+2
| |
| * Fix link_to with block and url_hashsanemat2013-07-072-1/+12
| | | | | | | | | | | | Use link_to with block and url_hash, expect block as name. But ignore block and use url_hash as name. 3-2-stable passes this test. 4-0-stable and master fail this.
* | Fix "Stack Level Too Deep" error when rendering recursive partialsRafael Mendonça França2013-07-075-3/+40
| | | | | | | | | | | | | | When rendering recursive partial Action View is trying to generate the view digest infinitly causing a stack level error. Fixes #11340
* | Merge pull request #11347 from ankit8898/refactoring-spRafael Mendonça França2013-07-074-109/+92
|\ \ | | | | | | Refactored strong parameters usage and updated Gemfile.lock with Rails 4
| * | Refactored strong paramters usage and updated Gemfile.lock with Rails 4Ankit Gupta2013-07-074-109/+92
| | |
* | | Merge pull request #11317 from ma2gedev/enforcer_tag_optionRafael Mendonça França2013-07-073-2/+39
|\ \ \ | | | | | | | | Added an `enforce_utf8` hash option for `form_tag` method
| * | | Added an `enforce_utf8` hash option for `form_tag` methodTakayuki Matsubara2013-07-073-2/+39
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Control to output a hidden input tag with name `utf8` without monkey patching Before: form_tag # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>' After: form_tag # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>' form_tag({}, { :enforce_utf8 => false }) # => '<form>....</form>'
* | | Merge pull request #11274 from arunagw/deprecation-removed-build-fixedRafael Mendonça França2013-07-071-20/+0
|\ \ \ | |/ / |/| | Deprecation removed build fixed
| * | Removed unused test for DateTime.local_offsetArun Agrawal2013-07-071-20/+0
| | | | | | | | | | | | see discussion here #11274
* | | Merge pull request #11313 from gsamokovarov/url-encoded-params-testRafael Mendonça França2013-07-061-25/+27
|\ \ \ | | | | | | | | Cleanup ul_encoded_params_parsing_test
| * | | Cleanup ul_encoded_params_parsing_testGenadi Samokovarov2013-07-051-25/+27
| | | |
* | | | Merge pull request #11324 from blahedo/masterRafael Mendonça França2013-07-066-27/+53
|\ \ \ \ | | | | | | | | | | Cleanup on getting_started tutorial
| * | | | Cleaned up wording and tags.blahedo2013-07-066-27/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced <br /> with <br> for consistency; Added note about singular/plural distinction (which was previously confusing to a Rails noob); Rephrased explanation of how form is routed to controller, again to reduce confusion; and added explanation to replace incorrect link. [ci skip]
* | | | | Merge pull request #11336 from ankit8898/performance-bmRafael Mendonça França2013-07-061-1/+13
|\ \ \ \ \ | | |_|_|/ | |/| | | Some performance benchmarking for take vs limit
| * | | | Some performance benchmarking for take vs limitAnkit Gupta2013-07-061-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also added a dummy progress bar during insert of records so it shows something is happening. Performance report Model.take 6198.9 (±13.4%) i/s - 121743 in 20.042671s Model.take! 6173.6 (±13.6%) i/s - 121242 in 20.057006s Model.all limit(100) 107.8 (±15.8%) i/s - 2106 in 20.022316s Model.all take(100) 105.2 (±15.2%) i/s - 2061 in 20.062509s
* | | | | Merge pull request #11339 from arunagw/running-actionpack-isolatedYves Senn2013-07-061-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Running isolated test for assertions and journey
| * | | | | Running isolated test for assertions and journeyArun Agrawal2013-07-061-1/+1
|/ / / / / | | | | | | | | | | | | | | | in actionpack
* | | | | Merge pull request #11337 from arunagw/actionview-rdocRafael Mendonça França2013-07-062-10/+0
|\ \ \ \ \ | | | | | | | | | | | | RUNNING_UNIT_TESTS tweaks.
| * | | | | actionpack not having activerecord tests [ci skip]Arun Agrawal2013-07-061-10/+0
| | | | | |
| * | | | | RUNNING_UNIT_TESTS file is in rdoc [ci skip]Arun Agrawal2013-07-061-0/+0
| | | | | |
* | | | | | fixes Rails version for the stable API [ci skip]Xavier Noria2013-07-062-1/+13
| | | | | |
* | | | | | Merge pull request #11306 from ↵Rafael Mendonça França2013-07-063-2/+50
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/11288_remove_extra_queries_for_belongs_to_with_touch #11288: Removed duplicated touching Conflicts: activerecord/CHANGELOG.md
| * | | | | | #11288: Removed duplicated touchingPaul Nikitochkin2013-07-053-2/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if belongs to model with touch option on touch Closes #11288
* | | | | | | fixes broken links in the API [Fixes #11335] [ci skip]Xavier Noria2013-07-061-2/+2
| |/ / / / / |/| | | | |
* | | | | | Merge pull request #11332 from sanemat/fix/av-test-duplicationRafael Mendonça França2013-07-061-3/+0
|\ \ \ \ \ \ | | |/ / / / | |/| | | | Remove actionview test duplication