aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix table comment dumpingRyuta Kamizono2016-10-113-2/+5
| | | | | | | | | | | | | Follow up to #26735. If `table_options` returns `{ comment: nil }`, `create_table` line is broken. Example: ```ruby create_table "accounts", force: :cascade, do |t| ```
* Merge pull request #26747 from kamipo/name_is_not_column_optionRafael França2016-10-103-12/+8
|\ | | | | `name` is not a column option
| * `name` is not a column optionRyuta Kamizono2016-10-103-12/+8
| | | | | | | | `migration_keys` includes `name` but `name` is not a column option.
* | Merge pull request #26750 from bogdanvlviv/docKasper Timm Hansen2016-10-101-6/+6
|\ \ | |/ |/| Add missing @, fix indents. [ci skip]
| * Add missing @, fix indents. [ci skip]bogdanvlviv2016-10-101-6/+6
|/
* Merge pull request #26578 from jeremy/undeprecate-plural-positional-argRafael França2016-10-102-14/+3
|\ | | | | Undeprecate plural positional argument
| * Undeprecate plural positional argumentJeremy Daer2016-09-212-14/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ```ruby pluralize people.count, 'person', 'people' ``` reads more naturally than ```ruby pluralize people.count, 'person', plural: 'people' ``` so let's not deprecate it. We could label both, but that's a mouthful: ```ruby pluralize people.count, singular: 'person', plural: 'people' ``` (The `plural:` kwarg shipped in 5.0.0, so we're keeping it.)
* | Merge pull request #26746 from rails/deprecationsRafael França2016-10-1056-1430/+298
|\ \ | | | | | | Remove all deprecations from Action Pack
| * | Remove deprecated support to non-keyword arguments in ↵Rafael Mendonça França2016-10-104-98/+19
| | | | | | | | | | | | | | | | | | `ActionDispatch::IntegrationTest`, `#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`.
| * | Remove deprecated `ActionDispatch::IntegrationTest#*_via_redirect`.Rafael Mendonça França2016-10-103-142/+4
| | |
| * | Remove deprecated `ActionDispatch::IntegrationTest#xml_http_request`Rafael Mendonça França2016-10-103-134/+8
| | |
| * | Remove deprecated support for passing `:path` and route path as stings in ↵Rafael Mendonça França2016-10-103-17/+7
| | | | | | | | | | | | `ActionDispatch::Routing::Mapper#match`
| * | Remove deprecated support passing path as `nil` in ↵Rafael Mendonça França2016-10-103-8/+6
| | | | | | | | | | | | `ActionDispatch::Routing::Mapper#match`
| * | Remove deprecated `cache_control` argument from ↵Rafael Mendonça França2016-10-103-18/+5
| | | | | | | | | | | | `ActionDispatch::Static#initialize`
| * | Remove deprecated support to passing strings to the middleware stackRafael Mendonça França2016-10-104-60/+8
| | |
| * | Remove deprecated code in ssl middlewareRafael Mendonça França2016-10-104-62/+23
| | |
| * | Remove deprecated code in ActionDispatch::Session::SessionRestoreErrorRafael Mendonça França2016-10-102-11/+10
| | |
| * | Deprecated ActionDispatch::ParamsParser::ParamsParserRafael Mendonça França2016-10-109-53/+51
| | | | | | | | | | | | | | | | | | ActionDispatch::ParamsParser class was removed in favor of ActionDispatch::Http::Parameters so it is better to move the error constant to the new class.
| * | Remove deprecated ActionDispatch::ParamsParserRafael Mendonça França2016-10-102-12/+5
| | |
| * | Remove deprecated code in ActionDispatch::ParamsParser::ParseErrorRafael Mendonça França2016-10-102-17/+10
| | |
| * | Remove deprecated access to mime types through constantsRafael Mendonça França2016-10-103-38/+4
| | |
| * | Remove deprecated support to non-keyword arguments #processRafael Mendonça França2016-10-103-181/+21
| | |
| * | Remove deprecated `xml_http_request` and `xhr` methodsRafael Mendonça França2016-10-103-30/+4
| | |
| * | Remove deprecated methods in ActionController::ParametersRafael Mendonça França2016-10-103-27/+5
| | |
| * | Remove deprecated comparing support with `ActionController::Parameters`Rafael Mendonça França2016-10-103-17/+5
| | |
| * | Remove deprecated support to :text in renderRafael Mendonça França2016-10-1021-293/+84
| | |
| * | Remove deprecated support to :nothing in renderRafael Mendonça França2016-10-093-15/+4
| | |
| * | Remove deprecated support to `:back` in `redirect_to`Rafael Mendonça França2016-10-093-50/+4
| | |
| * | Remove deprecated support for status option in headRafael Mendonça França2016-10-093-28/+5
| | |
| * | Remove deprecation at ActionController::BadRequestRafael Mendonça França2016-10-092-11/+6
| | |
| * | Remove deprecated methods related to controller filtersRafael Mendonça França2016-10-094-116/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `skip_action_callback`, `skip_filter`, `before_filter`, `prepend_before_filter`, `skip_before_filter`, `append_before_filter`, `around_filter` `prepend_around_filter`, `skip_around_filter`, `append_around_filter`, `after_filter`, `prepend_after_filter`, `skip_after_filter` and `append_after_filter`.
* | | Merge pull request #26745 from kamipo/dump_index_options_to_pretty_formatRafael França2016-10-105-12/+10
|\ \ \ | |/ / |/| | Dump index options to pretty format
| * | Dump index options to pretty formatRyuta Kamizono2016-10-105-12/+10
|/ / | | | | | | | | | | | | | | | | | | ```ruby # Before t.index ["firm_id", "type", "rating"], name: "company_index", order: {"rating"=>:desc}, using: :btree # After t.index ["firm_id", "type", "rating"], name: "company_index", order: { rating: :desc }, using: :btree ```
* | Merge pull request #26735 from kamipo/prevent_to_create_blank_commentRafael França2016-10-093-6/+8
|\ \ | | | | | | Prevent to create blank comment
| * | Prevent to create blank commentRyuta Kamizono2016-10-083-6/+8
| | | | | | | | | | | | | | | Currently blank comment does not dump to `db/schema.rb`. But created it even if specified blank.
* | | Merge pull request #26738 from bogdanvlviv/travisRafael França2016-10-091-1/+0
|\ \ \ | | | | | | | | Don't allow tests ac:integration to failure
| * | | Don't allow tests ac:integration to failurebogdanvlviv2016-10-081-1/+0
| | | |
* | | | Merge pull request #26740 from y-yagi/update_retry_on_exampleJon Moss2016-10-081-2/+2
|\ \ \ \ | |/ / / |/| | | correct exception class in `retry_on` example [ci skip]
| * | | correct exception class in `retry_on` example [ci skip]yuuji.yaginuma2016-10-091-2/+2
| | | | | | | | | | | | | | | | | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059
* | | | Revert "Temporarily make ACa tests noiser and more predictable"Matthew Draper2016-10-081-1/+1
| | | | | | | | | | | | | | | | This reverts commit 2d6c14bca25c5629e431a802c3053bad1e378fcc.
* | | | Merge pull request #26732 from matthewd/fixnum-warningMatthew Draper2016-10-085-8/+8
|\ \ \ \ | |/ / / |/| | | Fixnum and Bignum are deprecated in Ruby trunk
| * | | Fixnum and Bignum are deprecated in Ruby trunkMatthew Draper2016-10-085-8/+8
| | | | | | | | | | | | | | | | https://bugs.ruby-lang.org/issues/12739
* | | | Merge pull request #26729 from rails/bump-sdocRafael França2016-10-072-8/+6
|\ \ \ \ | | | | | | | | | | Bump sdoc to 1.0.0.beta2 which includes fix to support Ruby 2.4
| * | | | Include sdoc 1.0.0.beta2 which includes updated rdoc w/o hard json depZachary Scott2016-10-072-7/+6
| | | | |
| * | | | Bump sdoc to 1.0.0.beta1 which includes fix to support Ruby 2.4Zachary Scott2016-10-072-4/+3
| | | | |
* | | | | Silence a warningRafael Mendonça França2016-10-071-1/+3
| | | | |
* | | | | Undefine assings in IntegrationTestRafael Mendonça França2016-10-072-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | assigns assert the state of a controller instance what should not be done in an integration test.
* | | | | Merge pull request #26730 from rails/explain-why-inverse_of-is-disabledXavier Noria2016-10-071-0/+4
|\ \ \ \ \ | |_|/ / / |/| | | | explain why autosave= disables inverse_of [ci skip]
| * | | | explain why autosave= disables inverse_of [ci skip]Xavier Noria2016-10-071-0/+4
| |/ / /
* / / / Tweak a test so the queries matchMatthew Draper2016-10-081-1/+1
|/ / /