Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | test pg, rm unused requires. | Yves Senn | 2014-06-03 | 11 | -27/+0 |
| | |||||
* | Merge pull request #15487 from sgrif/sg-bit-limit | Yves Senn | 2014-06-03 | 3 | -32/+32 |
|\ | | | | | Respect limit for PG bit strings | ||||
| * | Respect limit for PG bit strings | Sean Griffin | 2014-06-03 | 3 | -32/+32 |
| | | |||||
* | | Merge pull request #15442 from sgrif/sg-refactor-field-changed | Yves Senn | 2014-06-03 | 6 | -36/+39 |
|\ \ | |/ |/| | Refactor determination of whether the field has changed | ||||
| * | Refactor determination of whether the field has changed | Sean Griffin | 2014-06-03 | 6 | -36/+39 |
| | | | | | | | | | | The types know more about what is going on than the dirty module. Let's ask them! | ||||
* | | pg, preserve type when schema dumping bit and bit varying columns. | Yves Senn | 2014-06-03 | 7 | -12/+44 |
| | | |||||
* | | test pg, move bit string type tests into `bit_string_test.rb`. | Yves Senn | 2014-06-03 | 3 | -42/+80 |
| | | |||||
* | | test pg, we don't care about the internal state of `column#default`. | Yves Senn | 2014-06-03 | 5 | -9/+0 |
|/ | | | | | That data is internal to Active Record. What we care about is that new records have the right default value. | ||||
* | pg, preserve point type when schema dumping. | Yves Senn | 2014-06-03 | 6 | -11/+24 |
| | |||||
* | pg test, examples for default values and schema dumping of point types. | Yves Senn | 2014-06-03 | 2 | -0/+32 |
| | | | | /cc @sgrif | ||||
* | Merge pull request #15483 from ↵ | Yves Senn | 2014-06-03 | 4 | -11/+11 |
|\ | | | | | | | | | eileencodes/reuse-available-reflection-polymorphic-methods fix polymorphic? method and reuse it | ||||
| * | fix polymorphic? method and reuse it | eileencodes | 2014-06-02 | 4 | -11/+11 |
|/ | | | | | | Fix polymorphic to check for `options[:polymorphic]` instead of `options.key? :polymorphic` and then reuse the method `polymorphic?` method instead of constantly checking the same `options[:polymorphic]`. | ||||
* | call `capture` fewer times from `form_for` | Aaron Patterson | 2014-06-02 | 2 | -4/+4 |
| | |||||
* | drastically reduce object allocations | Aaron Patterson | 2014-06-02 | 2 | -8/+15 |
| | | | | | | | | | | before this change, we were allocating AS::SafeBuffer objects that were being interpolated in to a string, so the safe buffer object was being thrown away. This change only allocates a string (vs a string *and* a safebuffer) and interpolates the string. On my test application, this reduced the AS::SafeBuffer objects from 1527k per request to about 500 per request. | ||||
* | reduce AS::SafeBuffer allocations | Aaron Patterson | 2014-06-02 | 1 | -1/+2 |
| | | | | | | | | | | | | html_escape_interpolated_argument is only used in mutation methods: https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L174 https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L179 The return value doesn't need to be converted to an AS::SafeBuffer since we know that the current object is an AS::SafeBuffer and will be mutated, and the return value from html_escape_interpolated_argument will be thrown away | ||||
* | Merge pull request #15475 from sgrif/sg-initialize-attributes | Guillermo Iguaran | 2014-06-02 | 3 | -11/+3 |
|\ | | | | | Remove unused `initialize_attributes` method | ||||
| * | Remove unused `initialize_attributes` method | Sean Griffin | 2014-06-02 | 3 | -11/+3 |
| | | | | | | | | | | This was previously a hook for a special case related to `serialize`, which has since been removed. | ||||
* | | concat is a hotspot (via AV#append=), so just directly define the methods | Aaron Patterson | 2014-06-02 | 1 | -4/+6 |
| | | |||||
* | | Merge pull request #15477 from aripollak/actioncontroller-overview-typo | Arthur Nogueira Neves | 2014-06-02 | 1 | -2/+2 |
|\ \ | | | | | | | Fix typo in ActionController Overview | ||||
| * | | Fix typo in ActionController Overview | Ari Pollak | 2014-06-02 | 1 | -2/+2 |
|/ / | | | | | | | * Should say "sensitive" instead of "sensible" | ||||
* | | Merge pull request #15474 from unixmonkey/master | Rafael Mendonça França | 2014-06-02 | 1 | -1/+1 |
|\ \ | | | | | | | File.exist? instead of File.exists? in bin/setup | ||||
| * | | File.exist? instead of File.exists? in bin/setup | David Jones | 2014-06-02 | 1 | -1/+1 |
| |/ | | | | | | | | | File.exists? is deprecated in Ruby 2.1+ https://github.com/ruby/ruby/blob/v2_1_2/file.c#L1413 | ||||
* | | Merge pull request #15473 from sgrif/sg-missing-colon | Zachary Scott | 2014-06-02 | 1 | -1/+1 |
|\ \ | |/ |/| | Add missing colon to internal [ci skip] | ||||
| * | Add missing colon to internal | Sean Griffin | 2014-06-02 | 1 | -1/+1 |
|/ | |||||
* | just use `assert` | Aaron Patterson | 2014-06-02 | 1 | -1/+1 |
| | |||||
* | Merge pull request #15379 from xuanxu/rational_precision | Rafael Mendonça França | 2014-06-02 | 4 | -5/+17 |
|\ | | | | | Fix AS::NumberHelper results with rationals | ||||
| * | Fix AS::NumberHelper results with rationals | Juanjo Bazán | 2014-05-31 | 4 | -5/+17 |
| | | | | | | | | | | | | | | | | | | | | :precision was incorrectly being applied to Rationals before: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.3" after: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.33" | ||||
* | | Merge pull request #15464 from tgxworld/improve_notifications_logic | Matthew Draper | 2014-06-03 | 2 | -8/+18 |
|\ \ | | | | | | | Improvements to ActiveSupport::Notifications. | ||||
| * | | Avoid looping through subscribers when unsubscribing with a subscriber object. | Guo Xiang Tan | 2014-06-01 | 1 | -5/+10 |
| | | | |||||
| * | | Update documentation to reflect unsubscription with name. | Guo Xiang Tan | 2014-06-01 | 2 | -4/+9 |
| | | | |||||
* | | | docs, fix typo [ci skip] | Yves Senn | 2014-06-02 | 1 | -2/+2 |
| | | | |||||
* | | | test pg, add basic test cases for point datatype. | Yves Senn | 2014-06-02 | 1 | -0/+45 |
| | | | |||||
* | | | pg, inline casting methods into `OID::Type` objects. | Yves Senn | 2014-06-02 | 4 | -44/+25 |
| | | | | | | | | | | | | | | | | | | | | | | | | This inlines casting for the most obvious types. The rest will follow eventually. I need to put some tests in place, to make sure that the inlining is not causing regressions. /cc @sgrif | ||||
* | | | Feature requests should be made on the mailing list, not submitted to | Zachary Scott | 2014-06-01 | 7 | -7/+40 |
| | | | | | | | | | | | | the issue tracker. See also #15455 [ci skip] | ||||
* | | | Merge pull request #15444 from sgrif/sg-yaml-new-record | Guillermo Iguaran | 2014-06-01 | 4 | -2/+28 |
|\ \ \ | | | | | | | | | New records should remain new after yaml serialization | ||||
| * | | | New records should remain new after yaml serialization | Sean Griffin | 2014-06-01 | 4 | -2/+28 |
|/ / / | |||||
* | | | :nail_care: for migrations guide from #15457 [ci skip] | Zachary Scott | 2014-06-01 | 1 | -7/+8 |
| | | | |||||
* | | | Merge pull request #15457 from maurogeorge/add-changing-columns | Zachary Scott | 2014-06-01 | 1 | -0/+22 |
|\ \ \ | | | | | | | | | Create Changing Columns on migrations guides [ci skip] | ||||
| * | | | Create Changing Columns on migrations guides | Mauro George | 2014-06-01 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Remove docs regarding grouping multiple values, as we should avoid | Zachary Scott | 2014-06-01 | 1 | -18/+1 |
| | | | | | | | | | | | | | | | | duplicating API reference in guides. Also :scissors: [ci skip] | ||||
* | | | | Merge pull request #15459 from maurogeorge/add-total-grouped-items | Zachary Scott | 2014-06-01 | 1 | -0/+34 |
|\ \ \ \ | |_|/ / |/| | | | Add Total of grouped items to Active Record query interface on guides [ci skip] | ||||
| * | | | Add Total of grouped items to AR query interface on guides | Mauro George | 2014-06-01 | 1 | -0/+34 |
| |/ / | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #15435 from sgrif/sg-rm-serialization | Yves Senn | 2014-06-01 | 12 | -103/+30 |
|\ \ \ | | | | | | | | | Remove most code related to serialized properties | ||||
| * | | | Remove most code related to serialized properties | Sean Griffin | 2014-06-01 | 12 | -103/+30 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing | ||||
* | | | Merge pull request #15432 from sgrif/sg-coder-type-casting | Yves Senn | 2014-06-01 | 4 | -23/+14 |
|\ \ \ | | | | | | | | | Don't change values in `@raw_attributes` during serialization | ||||
| * | | | Don't change values in `@raw_attributes` during serialization | Sean Griffin | 2014-06-01 | 4 | -23/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | During `init_with`, the attributes given to the coder will be placed into `@raw_attributes`. As such, we should read from `@raw_attributes` when encoding, rather than `@attributes`, which has been type cast. | ||||
* | | | | Merge pull request #14881 from robin850/patch-19 | Yves Senn | 2014-06-01 | 1 | -5/+8 |
|\ \ \ \ | | | | | | | | | | | Swallow bundler exceptions when running tests | ||||
| * | | | | Swallow bundler exceptions when running tests | Robin Dupret | 2014-04-27 | 1 | -5/+8 |
| | | | | | | | | | | | | | | | | | | | | Let's avoid useless output when testing stuff related to Bundler. | ||||
* | | | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-06-01 | 4 | -6/+11 |
|\ \ \ \ \ | |||||
| * | | | | | document generators hidden_namespaces | schneems | 2014-05-29 | 1 | -0/+5 |
| | | | | | |