aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Show source view and backtrace on missing template errorsGenadi Samokovarov2014-11-243-0/+33
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will help you debug missing template errors, especially if they come from a programmatic template selection. Thanks to @dhh for suggesting that. As a bonus, also show request and response info on the routing error page for consistency.
* | | | Merge pull request #17748 from ↵Zachary Scott2014-11-244-0/+14
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | claudiob/remove-unwanted-comments-from-documentation Mark comments that should not be in the docs [ci skip]
| * | | | Mark comments that should not be in the docsclaudiob2014-11-244-0/+14
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some comments that are meant to separate blocks of code in a file show up on http://api.rubyonrails.org as though they were part of the documentation. This commit hides those comments from the documentation. Stems from the discussion with @zzak at https://github.com/voloko/sdoc/issues/79#issuecomment-64158738 [ci skip]
* | | | Add `.reflections` change to release note [skip ci]Arthur Neves2014-11-241-0/+3
| | | | | | | | | | | | | | | | [related #17718]
* | | | Ensure the type map's cache is thread safeSean Griffin2014-11-241-3/+7
| | | | | | | | | | | | | | | | | | | | Thanks to @thedarkone for pointing out that an instance of this object is used in a shared context.
* | | | Merge pull request #17725 from chancancode/deprecate_use_routeGodfrey Chan2014-11-245-5/+41
|\ \ \ \ | | | | | | | | | | Deprecate use route
| * | | | Don't show the warning if we're already raising the error anywayGodfrey Chan2014-11-231-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the route set is empty, or if none of the routes matches with a score > 0, there is no point showing the deprecation message because we are already be raising the `ActionController::UrlGenerationError` mentioned in the warning. In this case it is the expected behavior and the user wouldn't have to take any actions.
| * | | | Deprecate `use_route` in controller testsGodfrey Chan2014-11-232-3/+24
| | | | | | | | | | | | | | | | | | | | Reference #17453
| * | | | Deprecate passing an invalid name to `Formatter#generate`Godfrey Chan2014-11-231-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The internal tests that (incorrectly) relied on this were already fixed in 938d130. However, we cannot simply fix this bug because the guides prior to b7b9e92 recommended a workaround that relies on this buggy behavior. Reference #17453
| * | | | Fix cases where the wrong name is passed to `Formatter#generate`Godfrey Chan2014-11-232-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | These are currently working "by accident" because `match_route` does not check that the name is valid.
* | | | | Merge pull request #17737 from yui-knk/fix/headSantiago Pastorino2014-11-242-5/+5
|\ \ \ \ \ | | | | | | | | | | | | Replace ActionDispatch::Head with Rack::Head.
| * | | | | Replace ActionDispatch::Head with Rack::Head.yui-knk2014-11-242-5/+5
| | | | | |
* | | | | | Merge pull request #17678 from siddharth28/includes_with_scope_with_joinsSantiago Pastorino2014-11-245-12/+17
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix includes on association with a scope
| * | | | | | Fix includes on association with a scope containing joins along with conditionssiddharth@vinsol.com2014-11-215-12/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | on the joined assoiciation
* | | | | | | Merge pull request #17707 from claudiob/move-debug-helper-testRafael Mendonça França2014-11-241-0/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Move test that depends on ActiveRecord
| * | | | | | | Move test that depends on ActiveRecordclaudiob2014-11-211-0/+0
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves a test from `test/template` to `test/activerecord` since the test depends on ActiveRecord. This matches the documentation from [RUNNING_UNIT_TESTS](https://github.com/rails/rails/blob/f28d1ddd507174ac233b773cc4f35c3c05ad32e7/actionview/RUNNING_UNIT_TESTS.rdoc): > Test cases in the test/activerecord/ directory depend on having activerecord and sqlite3 installed. > If Active Record is not in actionview/../activerecord directory, or the sqlite3 rubygem is not installed, these tests are skipped. > Other tests are runnable from a fresh copy of actionview without any configuration. --- More details about this commit. All the tests starting with `require 'active_record_unit'` are already inside `test/activerecord`, except for the one test this commit moves. If you don't have `active_record` on your machine, the following command currently fails on master: ```bash ```
* | | | | | | Merge pull request #17744 from RichardLitt/doc-fix-syntaxRafael Mendonça França2014-11-241-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix wrong path in comments about stylesheets
| * | | | | | | Fix wrong path in comments about stylesheetsRichard Littauer2014-11-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I put the wrong path in my last PR by accident. Fixed here. Related to #17742
* | | | | | | | Merge pull request #17742 from RichardLitt/doc-fix-syntaxRafael Mendonça França2014-11-244-4/+4
|\| | | | | | | | |_|_|_|/ / / |/| | | | | | Change 'of plugins' syntax
| * | | | | | Change 'of plugins' syntaxRichard Littauer2014-11-244-4/+4
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the docs uses a syntax that is unclear and not general American English. I've switched it to be clearer wording. Not a big fix, but may be helpful.
* | / / / / cleanup, remove trailing whitespace [ci skip]Yves Senn2014-11-241-2/+2
| |/ / / / |/| | | |
* | | | | Grammar pass on Web Console release note [ci skip]Zachary Scott2014-11-231-3/+3
| | | | |
* | | | | Clarify what is being serialized and when it will be deserializedZachary Scott2014-11-231-2/+2
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | Merge pull request #17721 from yui-knk/fix/rails_on_rack_guideZachary Scott2014-11-231-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Fix class name of middleware.
| * | | | | [ci skip] Fix class name of middleware.yui-knk2014-11-231-1/+1
| | | | | |
* | | | | | Merge pull request #17732 from rails/add-reflections-string-keys-testGuillermo Iguaran2014-11-231-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add a test for reflection keys as Strings, fixes #16928
| * | | | | | Add a test for reflection keys as Strings, fixes #16928Zachary Scott2014-11-231-0/+4
|/ / / / / / | | | | | | | | | | | | | | | | | | See also PR: #17610
* | | | | | Merge pull request #17723 from marocu/patch-1Arthur Nogueira Neves2014-11-231-1/+1
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Specified beta branch for web-console gem
| * | | | | Specified beta branch for web-console gemMatthew Cullum2014-11-221-1/+1
| | | | | |
* | | | | | Correct example in the engines testing guide [ci skip]Godfrey Chan2014-11-231-14/+25
| | | | | | | | | | | | | | | | | | | | | | | | Reference #17453
* | | | | | Test using `ActionController::TestCase` with enginesGodfrey Chan2014-11-231-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reference #17453 [Godfrey Chan, Washington Luiz]
* | | | | | Merge pull request #17715 from tgxworld/fix_nil_anchorGodfrey Chan2014-11-223-1/+20
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Anchor should not be appended when set to nil/false.
| * | | | | Anchor should not be appended when set to nil/false.Guo Xiang Tan2014-11-233-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/17714.
* | | | | | Merge pull request #17722 from yui-knk/fix/callbacks_commentZachary Scott2014-11-221-1/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | [ci skip] Fix comment of ActionDispatch::Callbacks
| * | | | | [ci skip] Fix comment of ActionDispatch::Callbacksyui-knk2014-11-231-1/+1
|/ / / / / | | | | | | | | | | | | | | | cc ddce3dd
* | | | | [ci skip] Dispatching is a verb :bow:Zachary Scott2014-11-221-1/+1
| | | | | | | | | | | | | | | | | | | | cc #17719
* | | | | Merge pull request #17719 from yui-knk/fix/rails_on_rack_guideZachary Scott2014-11-221-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix explanation for ActionDispatch::Callbacks. [ci skip]
| * | | | | Fix explanation for ActionDispatch::Callbacks.yui-knk2014-11-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActionDispatch::Callbacks dose not run the prepare callbacks, so change with comment on ActionDispatch::Callbacks.
* | | | | | Merge pull request #17718 from arthurnn/fixes_16928Zachary Scott2014-11-222-1/+7
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fixes 16928, improve reflections public API doc [ci skip]
| * | | | | Update reflections public API docArthur Neves2014-11-221-1/+1
| | | | | |
| * | | | | Add changelog entry for .reflections API changeArthur Neves2014-11-221-0/+6
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `.reflections` public API changed to return a String instead of a Symbol as keys. see commit 1f31488499111fdfce79d8dc1cc8fb008f7cdb25 and 6259e4e2dcca9a79f22f96658c33efe81936bc0d [fixes #16928] [fixes #17610]
* | | | | Fix build failuresSean Griffin2014-11-221-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For some reason changing `.find` to `.unscoped.find` in https://github.com/rails/rails/commit/f766abd4cf3eb75469d3646cfb6d85e668c619f3 caused `scoping` to leak in some tests when run in isolation (looks like a concurrency issue?). `relation_scoping_test.rb` is a case that failed. From what I can tell it should not be possible, but changing to the block form fixes it. There is a deeper issue that I can't seem to find. /cc @senny
* | | | | Rename the primary key index when renaming a table in pgSean Griffin2014-11-223-0/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also checked to make sure this does not affect foreign key constraints. (It doesn't). Fixes #12856 Closes #14088
* | | | | Remove outdated comments [ci skip]Godfrey Chan2014-11-221-6/+0
| | | | | | | | | | | | | | | They were introduced in 23b6def; the serial stuff has been removed since a5d80f8
* | | | | Merge pull request #17716 from javiervidal/fixing_documentationArun Agrawal2014-11-221-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | Fixing wrong link in 'Ruby on Rails Security Guide' [ci skip]
| * | | | Fixing wrong link in 'Ruby on Rails Security Guide' [ci skip]Javier Vidal2014-11-221-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The URL http://www.h-online.com/security/Symantec-reports-first-active-attack-on-a-DSL-router--/news/102352 points to an article titled 'The H is closing down'. The good one is: http://www.h-online.com/security/news/item/Symantec-reports-first-active-attack-on-a-DSL-router-735883.html
* | | | Merge pull request #17712 from y-yagi/correct_postgres_guideArun Agrawal2014-11-221-2/+2
|\ \ \ \ | | | | | | | | | | [ci skip] correct example output and filename in pg guide
| * | | | [ci skip] correct example output and filename in pg guideyuuji.yaginuma2014-11-221-2/+2
|/ / / /
* | | | ConnectionAdapter#substitute_at is technically public API...Sean Griffin2014-11-211-1/+1
| | | | | | | | | | | | | | | | We can't change the signature without a deprecation cycle.
* | | | Merge pull request #17705 from fgo/patch-14Arthur Nogueira Neves2014-11-211-2/+2
|\ \ \ \ | |/ / / |/| | | Move 'the' outside of SQLite and Bundler link text [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 06:37:09 +0000