Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add a valid hex that shouldn't be valid to ActiveModel numericality tests ↵ | rohit | 2010-05-18 | 1 | -1/+1 |
| | | | | | | [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use assert_respond_to because it has better error messaging | Neeraj Singh | 2010-05-18 | 3 | -8/+8 |
| | | | | | | [#4628 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove deprecated methods since 2-3-stable. | José Valim | 2010-05-18 | 2 | -46/+6 |
| | |||||
* | Kill legacy dispatcher. | José Valim | 2010-05-18 | 2 | -26/+0 |
| | |||||
* | Simplify cookie_store by simply relying on cookies.signed. | José Valim | 2010-05-18 | 9 | -151/+138 |
| | |||||
* | Rely on set and delete cookie logic from rack. | José Valim | 2010-05-18 | 2 | -33/+6 |
| | |||||
* | Renames Array#rand -> Array#random_element | Rizwan Reza | 2010-05-17 | 4 | -17/+5 |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Merge remote branch 'origin/master' | wycats | 2010-05-17 | 4 | -3/+38 |
|\ | |||||
| * | Added default currency values to NumberHelper and pass them to I18n.translate | Santiago Pastorino | 2010-05-17 | 2 | -2/+22 |
| | | | | | | | | | | | | [#4604 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Allow root to be given in the resources scope without need to specify :on => ↵ | José Valim | 2010-05-17 | 2 | -1/+16 |
| | | | | | | | | collection. | ||||
* | | Merge branch 'encodings' | wycats | 2010-05-17 | 2 | -5/+9 |
|\ \ | |||||
| * | | Make sure encoding changes don't break 1.8 | wycats | 2010-05-17 | 2 | -5/+9 |
| | | | |||||
* | | | Revert "Moved encoding work in progress to a feature branch." | wycats | 2010-05-17 | 22 | -89/+488 |
| |/ |/| | | | | | This reverts commit ade756fe42423033bae8e5aea8f58782f7a6c517. | ||||
* | | Valid hex strings aren't valid float column values, to match the integer ↵ | Jeremy Kemper | 2010-05-17 | 2 | -4/+9 |
| | | | | | | | | restriction. [#4622 state:resolved] | ||||
* | | Use assert_equal correctly in transaction callback tests (exposing some of ↵ | Paco Guzman | 2010-05-17 | 1 | -17/+17 |
| | | | | | | | | | | | | | | | | them as broken) [#4612] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Ruby 1.9: helper path may be a pathname, so convert to a string before ↵ | Jeremy Kemper | 2010-05-16 | 1 | -1/+1 |
| | | | | | | | | quoting for regexp | ||||
* | | AR::Base#clone fixed to set dirty bits for cloned object | pleax | 2010-05-16 | 2 | -1/+57 |
| | | | | | | | | | | | | [#2919 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | cache connection when quoting | Comron Sattari | 2010-05-16 | 1 | -5/+6 |
| | | | | | | | | | | | | | | [#3642 state:committed] Signed-off-by: Marius Nuennerich <marius@nuenneri.ch> Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | a cloned object no longer mimics changed flags from creator , plus a test ↵ | Federico Brubacher | 2010-05-16 | 3 | -4/+15 |
| | | | | | | | | | | | | case [#4614 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Moved encoding work in progress to a feature branch. | Jeremy Kemper | 2010-05-16 | 22 | -488/+89 |
|/ | | | | This reverts commits af0d1a88157942c6e6398dbf73891cff1e152405 and 64d109e3539ad600f58536d3ecabd2f87b67fd1c. | ||||
* | Change on Array extension from rand => random_element [#4555 state:committed] | Santiago Pastorino | 2010-05-16 | 4 | -13/+27 |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Significantly improved internal encoding heuristics and support. | wycats | 2010-05-16 | 19 | -54/+417 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Default Encoding.default_internal to UTF-8 * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file * Read templates as BINARY, use default_external or template-wide magic comments inside the Template to set the initial encoding * This means that template handlers in Ruby 1.9 will receive Strings encoded in default_internal (UTF-8 by default) * Create a better Exception for encoding issues, and use it when the template source has bytes that are not compatible with the specified encoding * Allow template handlers to opt-into handling BINARY. If they do so, they need to do some of their own manual encoding work * Added a "Configuration Gotchas" section to the intro Rails Guide instructing users to use UTF-8 for everything * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid $KCODE value is used Also: * Fixed a few tests that were assert() rather than assert_equal() and were caught by Minitest requiring a String for the message * Fixed a test where an assert_select was misformed, also caught by Minitest being more restrictive * Fixed a test where a Rack response was returning a String rather than an Enumerable | ||||
* | Initial work to improve the state of encodings for templates | wycats | 2010-05-16 | 6 | -45/+81 |
| | |||||
* | Added nokogiri dependency to Gemfile [#4617 state:resolved] | Priit Tamboom | 2010-05-16 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | prevent to run fixture accessor (e.g. test_foos for TestFoo model) as a test ↵ | Nobuhiro IMAI | 2010-05-16 | 2 | -0/+6 |
| | | | | | | | case [#2992 state:resolved] Signed-off-by: Wijnand Wiersma <wijnand@videre.net> Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Gemfile requires sqlite3-ruby = 1.3.0.beta.2 | Santiago Pastorino | 2010-05-16 | 1 | -1/+1 |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Tests for new reserved words [#4602 state:resolved] | Simon Jefford | 2010-05-16 | 1 | -2/+7 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Added rails command aliases (s g c db) to reserved words in app generator ↵ | Aleksandr Koss | 2010-05-16 | 1 | -1/+1 |
| | | | | | | [#4602 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | I have updated the documentation according to ticket #4263 about fixtures ↵ | Franck Verrot | 2010-05-16 | 1 | -1/+9 |
| | | | | | | and set_fixture_class Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Take out stale tasks from Actionpack's Rakefile [#4619 state:resolved] | Rizwan Reza | 2010-05-16 | 1 | -19/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Takes out stale methods relating to edge_rails_version | Rizwan Reza | 2010-05-16 | 2 | -54/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Added missing require, we are using bind method defined on ↵ | Santiago Pastorino | 2010-05-16 | 1 | -0/+1 |
| | | | | | | | | active_support/core_ext/proc [#4610 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make use of assert_equal to test equallity between object assert expects and ↵ | Santiago Pastorino | 2010-05-16 | 7 | -12/+12 |
| | | | | | | | | object and a message of error [#4611 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Postgresql doesn't allow to change a string type column to a binary type. ↵ | Wijnand Wiersma | 2010-05-16 | 1 | -7/+9 |
| | | | | | | Skip this test for postgresql for now. [#4616 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Check blocks are not incorrectly detected when compiling erubis templates ↵ | Simon Jefford | 2010-05-16 | 3 | -1/+7 |
| | | | | | | [#4575 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed 1 failure in ActionPack testsuite [#4613 state:resolved] | Hussein Morsy | 2010-05-16 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add some comments related to Hash method check. | José Valim | 2010-05-16 | 1 | -0/+3 |
| | |||||
* | added support for html attributes in options_for_select [#2165] | pleax | 2010-05-16 | 2 | -2/+81 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited] | rohit | 2010-05-16 | 3 | -6/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix Hash#index deprecated warning in 1.9.x [#4600 state:resolved] | Aleksandr Koss | 2010-05-16 | 1 | -1/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Rename assert_attribute_type to asser_field_type. | José Valim | 2010-05-16 | 2 | -10/+10 |
| | |||||
* | Added assert_attribute_type to clean up GeneratedAttributeTest [#2377 ↵ | Jeff Kreeftmeijer | 2010-05-16 | 2 | -0/+52 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move AD::Cascade to the bottom of the middleware stack. | José Valim | 2010-05-16 | 3 | -34/+34 |
| | |||||
* | using :time_select when the attribute type is :time in the scaffold ↵ | Jeff Kreeftmeijer | 2010-05-16 | 1 | -6/+7 |
| | | | | | | generator. [#2377 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed two failing tests in railties on 1.9.2-head [#4609 state:commited] | rohit | 2010-05-16 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Don't carry default value when changing column for a binary type on MySQL ↵ | Elomar França | 2010-05-16 | 2 | -1/+15 |
| | | | | | | [#3234 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Expose remaining hooks to minimize the need for a Railtie based on feedback ↵ | José Valim | 2010-05-16 | 4 | -6/+36 |
| | | | | from plugin developers. | ||||
* | Ensure that eager_load actually takes place just after the middleware stack ↵ | José Valim | 2010-05-15 | 4 | -15/+49 |
| | | | | | | is built by using another pattern. Also create a engine_blank_point initializer to ensure any :before or :after hooks defined inside engines won't move the configuration initializers to other places. | ||||
* | Sending :id => nil to form helpers now properly omits the "id" html element ↵ | Jeff Dean | 2010-05-15 | 2 | -5/+118 |
| | | | | | | [#4559 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵ | José Valim | 2010-05-15 | 15 | -139/+111 |
| | | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff. |