| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| | |
Avoid defining multibyte method names in JSON decoding test for JRuby Compatitibility
|
| | |
| |
| |
| | |
This change is similar to #11736 & in same way switched with fixed string & the index of the hash for method name. the index was added because otherwise, ruby will raise Error.
|
| |\ \
| |/
|/| |
document how to deploy to a subdirectory [ci skip]
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit fixes the build but we need to further investigate the root cause,
to see if it can be fixed.
The test fails under `MysqlAdapter` with:
```
ActiveRecord::UnknownAttributeError: unknown attribute: なまえ
```
The root cause is that the returned column names from the adapter
have the wrong encoding:
```ruby
columns = Weird.columns_hash.keys
columns # => ["id", "a$b", "\xE3\x81\xAA\xE3\x81\xBE\xE3\x81\x88", "from"]
columns.map(&:encoding) # => [#<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>]
columns.map {|c| c.dup.force_encoding "utf-8"} # => ["id", "a$b", "なまえ", "from"]
```
From what I can tell the MySQL variables are fine:
```
ActiveRecord::Base.connection.execute("show variables")
...
character_set_client utf8
character_set_connection utf8
character_set_database utf8
character_set_filesystem binary
character_set_results utf8
character_set_server utf8
character_set_system utf8
character_sets_dir /usr/local/Cellar/mysql/5.5.29/share/mysql/charsets/
collation_connection utf8_general_ci
collation_database utf8_unicode_ci
collation_server utf8_general_ci
...
```
|
| | | |
|
| |\ \
| | |
| | | |
Bump ruby version [ci skip]
|
| | | | |
|
| |\ \ \
| |/ /
|/| | |
Bump ruby version [ci skip]
|
| |/ / |
|
| | |
| |
| |
| | |
Closes #11062
|
| |\ \
| | |
| | | |
Rack::Logger naked rescue fix
|
| | | |
| | |
| | |
| | | |
Similar to #11497.
|
| |/ /
| |
| |
| | |
This makes the rack_logger_test.rb runnable by itself (outside of the `rake test` suite).
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Fix in-memory tests
|
| | |
| |
| |
| | |
[ci skip]
|
| |\ \
| | |
| | | |
Update Assets Pipeline Guide [ci skip]
|
| | | |
| | |
| | |
| | | |
by default included to precompile only non-js/css files from `app/assets` and `application.(css|js)`
|
| |/ / |
|
| |\ \
| | |
| | | |
Remove privatizing of Fixnum#/ from assert_distance_of_time_in_words
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
MRI reimplemented Date in C so it doesn't hit this division anymore
while JRuby still uses the old stdlib implementation of Date so
it will always hit this.
With this change the actionview date_helper_test.rb tests should pass on JRuby.
|
| |\ \
| | |
| | | |
[Jruby] Make all tests in ActionView::TemplateDigestorTest green
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Missing tmp directory will cause the test to fail on JRuby. will commit
adds tmp directory & 22 TemplateDigestorTests which were failing before
are now green.
Further Discussion on this can be seen at #11743
|
| | | |
| | |
| | |
| | |
| | | |
This change was breaking the Railties tests. See
https://travis-ci.org/rails/rails/jobs/9865969
|
| | | |
| | |
| | |
| | | |
The deprecation message was removed on 50cbc03d18c5984347965a94027879623fc44cce but the code was not.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The pattern is event.component
Closes #11769
Conflicts:
railties/CHANGELOG.md
|
| |\ \ \
| | | |
| | | | |
Load fixtures from linked folders[master]
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Removed confusing statement about adding route for show action in getting started guide [ci skip]
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- routes for CRUD already exists as `resources :posts` is in
`config/routes.rb`
- So we don't have to add any new route in the `config/routes.rb`
- As per #11644, the adding of routes which are already there confuses user, so here its
changed to referring output of `rake routes`
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Free result_metadata directly instead of freeing 2nd, redundant call.
|
| | |/ / / /
| | | | |
| | | | | |
`result_metadata` returns a new object each time it is called, so calling `result_metadata.free` is essentially a noop. Instead call `free` directly on the metadata when we're done with it.
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Create sqlite3 directory if not present
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory:
```
SQLite3::CantOpenException: unable to open database file
```
This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you.
This PR is an alternative to #11692 as suggested by @josevalim
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Passing the actual ID is not idiomatic.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Added data for permit array into scalar value
[ci skip]
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Fix: documentation for ActiveModel::Errors [ci skip]
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Pass assert_dom_equal message arg to underlying assertion
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
#assert_dom_equal and #assert_dom_not_equal both take a "failure"
message argument, but this argument was not utilized.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Rails.logger should have level specified by config.log_level.
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | | |
Fix bug when log level of Rails.logger (which was set via config.logger) does not match the config.log_level.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
update guide to reflect default HMAC SHA1 in MessageVerifier used in SignedCookieStore
|
