Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | | | | | | | return early from add_request_method | Aaron Patterson | 2014-06-03 | 1 | -11/+11 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | only loop over `options` once (hopefully) | Aaron Patterson | 2014-06-03 | 1 | -13/+11 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | only loop through constraints once | Aaron Patterson | 2014-06-03 | 1 | -19/+15 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | change defaults allocation to a one-liner | Aaron Patterson | 2014-06-03 | 1 | -3/+2 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | no longer need the scope ivar | Aaron Patterson | 2014-06-03 | 1 | -2/+1 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | only look up scope[:module] once | Aaron Patterson | 2014-06-03 | 1 | -6/+6 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | remove IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+8 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | :only is never used in Mapping, so rm the key | Aaron Patterson | 2014-06-03 | 1 | -1/+2 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | remove :defaults from the IGNORE_OPTIONS list | Aaron Patterson | 2014-06-03 | 1 | -4/+4 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | remove :constraints from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+5 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | disconnect normalize_defaults! from options[:constraints] | Aaron Patterson | 2014-06-03 | 1 | -6/+6 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | disconnect options and scope from the `blocks` method | Aaron Patterson | 2014-06-03 | 1 | -7/+8 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | disconnect the constraints method from the options and scope hashes | Aaron Patterson | 2014-06-03 | 1 | -12/+15 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | :on is removed from options before the Mapping is instantiated, so remove it ↵ | Aaron Patterson | 2014-06-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from IGNORE_OPTIONS | |||||
* | | | | | | | | | | | | pull up via extraction and remove it from options / IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -8/+6 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | always make :via a list | Aaron Patterson | 2014-06-03 | 1 | -3/+2 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | always pull out a via variable and simplify logic | Aaron Patterson | 2014-06-03 | 1 | -12/+15 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | test with an empty via | Aaron Patterson | 2014-06-03 | 1 | -0/+8 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | add a test for missing "via" parameter | Aaron Patterson | 2014-06-03 | 2 | -1/+9 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | remove :as and :anchor from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -3/+5 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | remove another value from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -2/+2 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | shorten up IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since we are now passing the format value around, we can remove it from the options hash, which means we don't need to consult as many values from IGNORE_OPTIONS | |||||
* | | | | | | | | | | | | only look up the format option from the hash once | Aaron Patterson | 2014-06-03 | 1 | -16/+18 | |
| | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | Merge pull request #15486 from sgrif/sg-binary-quoting | Matthew Draper | 2014-06-04 | 5 | -47/+83 | |
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / / |/| | | | | | | | | | | | Refactor quoting of binary data to not be based on the column type | |||||
| * | | | | | | | | | | | Refactor quoting of binary data to not be based on the column type | Sean Griffin | 2014-06-03 | 5 | -47/+83 | |
| | |/ / / / / / / / / | |/| | | | | | | | | | ||||||
* | | | | | | | | | | | test pg, remove unused column assignments. Follow up to 254cdf47 | Yves Senn | 2014-06-03 | 5 | -12/+0 | |
| | | | | | | | | | | | ||||||
* | | | | | | | | | | | pg, preserve money type when dumping schema and extract money default. | Yves Senn | 2014-06-03 | 7 | -22/+39 | |
| | | | | | | | | | | | ||||||
* | | | | | | | | | | | test pg, rm unused requires. | Yves Senn | 2014-06-03 | 11 | -27/+0 | |
| |_|_|_|/ / / / / / |/| | | | | | | | | | ||||||
* | | | | | | | | | | Merge pull request #15487 from sgrif/sg-bit-limit | Yves Senn | 2014-06-03 | 3 | -32/+32 | |
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | Respect limit for PG bit strings | |||||
| * | | | | | | | | | | Respect limit for PG bit strings | Sean Griffin | 2014-06-03 | 3 | -32/+32 | |
| | | | | | | | | | | | ||||||
* | | | | | | | | | | | Merge pull request #15442 from sgrif/sg-refactor-field-changed | Yves Senn | 2014-06-03 | 6 | -36/+39 | |
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / |/| | | | | | | | | | | Refactor determination of whether the field has changed | |||||
| * | | | | | | | | | | Refactor determination of whether the field has changed | Sean Griffin | 2014-06-03 | 6 | -36/+39 | |
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The types know more about what is going on than the dirty module. Let's ask them! | |||||
* | | | | | | | | | | pg, preserve type when schema dumping bit and bit varying columns. | Yves Senn | 2014-06-03 | 7 | -12/+44 | |
| | | | | | | | | | | ||||||
* | | | | | | | | | | test pg, move bit string type tests into `bit_string_test.rb`. | Yves Senn | 2014-06-03 | 3 | -42/+80 | |
| | | | | | | | | | | ||||||
* | | | | | | | | | | test pg, we don't care about the internal state of `column#default`. | Yves Senn | 2014-06-03 | 5 | -9/+0 | |
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That data is internal to Active Record. What we care about is that new records have the right default value. | |||||
* | | | | | | | | | pg, preserve point type when schema dumping. | Yves Senn | 2014-06-03 | 6 | -11/+24 | |
| | | | | | | | | | ||||||
* | | | | | | | | | pg test, examples for default values and schema dumping of point types. | Yves Senn | 2014-06-03 | 2 | -0/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | /cc @sgrif | |||||
* | | | | | | | | | Merge pull request #15483 from ↵ | Yves Senn | 2014-06-03 | 4 | -11/+11 | |
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | eileencodes/reuse-available-reflection-polymorphic-methods fix polymorphic? method and reuse it | |||||
| * | | | | | | | | | fix polymorphic? method and reuse it | eileencodes | 2014-06-02 | 4 | -11/+11 | |
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix polymorphic to check for `options[:polymorphic]` instead of `options.key? :polymorphic` and then reuse the method `polymorphic?` method instead of constantly checking the same `options[:polymorphic]`. | |||||
* | | | | | | | | | call `capture` fewer times from `form_for` | Aaron Patterson | 2014-06-02 | 2 | -4/+4 | |
| | | | | | | | | | ||||||
* | | | | | | | | | drastically reduce object allocations | Aaron Patterson | 2014-06-02 | 2 | -8/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | before this change, we were allocating AS::SafeBuffer objects that were being interpolated in to a string, so the safe buffer object was being thrown away. This change only allocates a string (vs a string *and* a safebuffer) and interpolates the string. On my test application, this reduced the AS::SafeBuffer objects from 1527k per request to about 500 per request. | |||||
* | | | | | | | | | reduce AS::SafeBuffer allocations | Aaron Patterson | 2014-06-02 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | html_escape_interpolated_argument is only used in mutation methods: https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L174 https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L179 The return value doesn't need to be converted to an AS::SafeBuffer since we know that the current object is an AS::SafeBuffer and will be mutated, and the return value from html_escape_interpolated_argument will be thrown away | |||||
* | | | | | | | | | Merge pull request #15475 from sgrif/sg-initialize-attributes | Guillermo Iguaran | 2014-06-02 | 3 | -11/+3 | |
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Remove unused `initialize_attributes` method | |||||
| * | | | | | | | | | Remove unused `initialize_attributes` method | Sean Griffin | 2014-06-02 | 3 | -11/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was previously a hook for a special case related to `serialize`, which has since been removed. | |||||
* | | | | | | | | | | concat is a hotspot (via AV#append=), so just directly define the methods | Aaron Patterson | 2014-06-02 | 1 | -4/+6 | |
| |_|_|_|_|_|/ / / |/| | | | | | | | | ||||||
* | | | | | | | | | Merge pull request #15477 from aripollak/actioncontroller-overview-typo | Arthur Nogueira Neves | 2014-06-02 | 1 | -2/+2 | |
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Fix typo in ActionController Overview | |||||
| * | | | | | | | | | Fix typo in ActionController Overview | Ari Pollak | 2014-06-02 | 1 | -2/+2 | |
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Should say "sensitive" instead of "sensible" | |||||
* | | | | | | | | | Merge pull request #15474 from unixmonkey/master | Rafael Mendonça França | 2014-06-02 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | File.exist? instead of File.exists? in bin/setup | |||||
| * | | | | | | | | | File.exist? instead of File.exists? in bin/setup | David Jones | 2014-06-02 | 1 | -1/+1 | |
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | File.exists? is deprecated in Ruby 2.1+ https://github.com/ruby/ruby/blob/v2_1_2/file.c#L1413 | |||||
* | | | | | | | | | Merge pull request #15473 from sgrif/sg-missing-colon | Zachary Scott | 2014-06-02 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | Add missing colon to internal [ci skip] |