| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Add documentation for #17573
|
| |
| |
| |
| |
| |
| | |
Fixes some parts of #23148.
[ci skip]
|
|\ \
| | |
| | | |
git protocol replaced with https
|
| | | |
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
yahonda/shorten_internal_metadata_table_name_less_than_30_byte
Shorten ActiveRecord::InternalMetadata.table_name to ar_internal_metadata
|
| | |
| | |
| | |
| | | |
for those who already migrated to Rails 5.0.0 beta
|
| |/
| |
| |
| | |
to support Oracle database which only supports 30 byte identifier length
|
|\ \
| | |
| | | |
[ci skip] Properly indent code in markdown
|
|/ /
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Add Default Puma Config
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When the `puma` command is run without any configuration options it will detect presence of a `config/puma.rb` file and use that. Currently there is discrepancy between `puma` command and `rails server` but Evan said it would be reasonable to add in reading in config from the default location. I am working on that right now as a feature in puma/puma.
Why do we need this? By default Puma uses 16 threads, and by default ActiveRecord only has 5 threads. Due to the architecture of AR it is guaranteed that if you're running with fewer DB connections than your server has threads you will hit `ActiveRecord::ConnectionTimeoutError ` eventually if your app gets modest amounts of traffic. Since we are providing a default webserver, we should provide reasonable configuration for that webserver.
This PR does a few things, first it sets the default Puma thread count to 5 to mach ActiveRecord's default. It sets the default environment to `"development"` and the default port to 300 so that booting the server with `$ puma` will give you the same default port as `rails server`. It is worth mentioning that by reading in from `PORT` environment variable this config can work with containerized deployments, such as on Heroku.
We are not using worker processes by default, that way JRuby and windows devs can use this configuration without modification. I went ahead and included a default `on_worker_boot`. It won't be used unless a worker count is specified, that means this config will not use it. Even though it's not being used now It will make someone who wants to try modifying their config to run extra workers easier.
cc/ @pixeltrix
|
|\ \ \
| | | |
| | | | |
Change default ACa adapter for development & test
|
| | | | |
|
|\ \ \ \
| |_|_|/
|/| | | |
Redis sans EventMachine
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This new adapter does get a little more intimate with the redis-rb gem's
implementation than I would like, but it's the least bad of the
approaches I've come up with.
|
|\ \ \ \
| | | | |
| | | | | |
Fix documentation related to `config.assets.cache_store` [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- sprockets-rails no longer supports customizing cache store after
rails/sprockets-rails@ecaeb27 using `config.assets.cache_store`.
- Instead we need to configure it using block syntax.
- Fixes #19835.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Added references option to join tables
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes issue #22960
When creating join tables with the command
rails g migration CreateJoinTableShowroomUser showroom:references user:references
The migration will use references to create the joins and output:
class CreateJoinTableShowroomUser < ActiveRecord::Migration
def change
create_join_table :showrooms, :users do |t|
t.references :showroom, index: true, foreign_key: true
t.references :user, index: true, foreign_key: true
end
end
end
This allows for proper refrences with indexes and foreign keys to be easily used when
adding join tables. Without `:refrences` the normal output is generated:
class CreateJoinTableShowroomUser < ActiveRecord::Migration[5.0]
def change
create_join_table :showrooms, :users do |t|
# t.index [:showroom_id, :user_id]
# t.index [:user_id, :showroom_id]
end
end
end
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Avoid extra `show variables` in migration
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`initialize_schema_migrations_table` is called in every migrations.
https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/migration.rb#L1080
https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/schema.rb#L51
This means that extra `show variables` is called regardless of the
existence of `schema_migrations` table.
This change is to avoid extra `show variables` if `schema_migrations`
table exists.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Make to primary key instead of an unique index for internal tables
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
None of the other components use them, so we should be consistent.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
kamipo/remove_duplicated_composite_primary_key_tests
Remove duplicated composite primary key tests
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Extract `ExplainPrettyPrinter` to appropriate files
|
| |/ / / / / / |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 96355e87cba247246234386b0af9273cc5d59db9, reversing
changes made to a00c36feea6c0271b5ad48a949ef294514fdef52.
See https://github.com/rails/rails/pull/23366#issuecomment-177714429
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use `t.index` in `create_table` instead of `add_index` in test schema
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | | |
For reduce bootstrap queries in tests.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Added test for backward compatibility of null constraints on timestamp columns
|
| |/ / / / / |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
`OID::Money.precision` is unused since #15239
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
p PostgreSQLAdapter::OID::Money.precision
# => 19
p PostgreSQLAdapter::OID::Money.new.precision
# => nil
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Update Gemfile.lock
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
- Leftover from https://github.com/rails/rails/commit/93abf58787396661230f31c7a2f58c18f30dbec9.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
yui-knk/override_calculate_constructables_at_each_concrete_class
Remove `case macro` from `calculate_constructable`
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Rails has abstract Reflection classes (`MacroReflection`,
`AssociationReflection` etc.) and concrete Reflection classes
(e.g. `HasManyReflection`, `HasOneReflection` etc.).
In many case `calculate_constructable` returns `true`, so
change `calculate_constructable` to always return `true` and
override this method if necessary.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
clarify the touch true option does not trigger after_save/update [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
I've gotten tripped up more than a few times on this, thinking that
using `belongs_to` with `touch: true` would trigger my after_save or
after_update callbacks. The same text is in the documentation for the
touch method itself, but I think its helpful to repeat it again here.
It might save people some time.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Move Action Cable back to the main build
|
| | | | | | | | |
|
| | |_|/ / / /
| |/| | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
make rake proxy work in rails engines
|
| | | | | | | | | |
|