aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Experimental: Improve performance of ActionView by preventing method cache ↵Yehuda Katz2009-08-092-13/+31
| | | | | | | | | | | | | | | | | | | | | | | | flushing due to runtime Kernel#extend: * The helper module adds a new _helper_serial property onto AbstractController subclasses * When #helper is used to add helpers to a class, the serial number is updated * An ActionView subclass is created and cached based on this serial number. * That subclass includes the helper module from the controller * Subsequent requests using the same controller with the same serial will result in reusing that subclass, rather than being forced to take an action (like include or extend) that will result in a global method cache flush on MRI and a flush of the entire AV class' cache on JRuby. * For now, this optimization is not applied to the RJS helpers, which results in a global method cache flush in MRI and a flush of the JavaScriptGenerator class in JRuby only when using RJS. * Since the effects are limited to using RJS, and would only affect JavaScriptGenerator in JRuby (as opposed to the entire view object), it seems worthwhile to apply this now. * This resulted in a significant performance improvement. I will have benchmarks in the next day or two that show the performance impact of the last several commits. * There is a small chance this could break existing code (although I'm not sure how). If that happens, please report it immediately.
* Cache controller_path on the AV instance to avoid needing to make additional ↵Yehuda Katz2009-08-091-1/+3
| | | | calls back into the controller for each attempt (this was done because these calls were adding up significantly in partial rendering and showing up on profiles)
* Use response_body rather than performed?Yehuda Katz2009-08-092-2/+2
|
* Rendering a template from ActionView will default to looking for partials ↵Yehuda Katz2009-08-093-2/+5
| | | | | | | | | only in the current mime type. * The old behavior was tested only as a side-effect of a different test--the original tests remain; a new template in the XML mime was added. * If you are relying on the current behavior and object to this change, please participate in http://groups.google.com/group/rubyonrails-core/browse_thread/thread/6ef25f3c108389bd
* Cache some more things to improve partial perfYehuda Katz2009-08-092-5/+9
|
* Went from 25% slower partials (vs. 2.3) to 10% faster. More to come.Yehuda Katz2009-08-093-10/+23
|
* Support a warmup for JRubyYehuda Katz2009-08-091-7/+6
|
* Update minimal.rb to benchmark partialsYehuda Katz2009-08-096-5/+50
|
* Clean up partial object some more; replace passing around a block to a ↵Yehuda Katz2009-08-092-36/+39
| | | | single block ivar
* Clean up initializer and some of the internals of PartialRendererYehuda Katz2009-08-092-49/+45
|
* Ruby 1.9 compat: can't implicitly set instance var using block argJeremy Kemper2009-08-081-2/+2
|
* Don't define a default primary key in the schema dumper.Tristan Dunn2009-08-082-1/+8
| | | | | | [#1908 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix binary fixture test on WindowsRob2009-08-081-1/+1
| | | | | | [#2597 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* MySQL: fix diacritic uniqueness test by setting the default character set ↵Hugo Peixoto2009-08-081-2/+2
| | | | | | | | and collation to utf8/utf8_unicode_ci [#2883 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Merge branch 'patches'Michael Koziarski2009-08-092-1/+30
|\
| * Don't call additional methods on builders passed to the atom_feed helper.Michael Koziarski2009-08-092-1/+30
| | | | | | | | | | | | Additionally, actually test that the atom_feed helper works with :xml as an option. [#1836 state:committed]
| * Adding :from scoping to ActiveRecord calculationsMatt Duncan2009-08-093-0/+10
| | | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1229 state:committed]
* | Add :redirect to the testable RJS statements [#2612 state:resolved]Jon Wood2009-08-092-3/+17
| | | | | | | | | | | | | | Example : assert_select_rjs :redirect, root_path Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Use Pathname for checking if sqlite path is absolutePratik Naik2009-08-091-1/+5
| |
* | Make sure db:drop doesn't fail when sqlite db is given by an absolute path ↵bastilian2009-08-091-1/+1
| | | | | | | | | | | | [#1789 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Enumerable#sum now works will all enumerables, even if they don't respond to ↵Marc-Andre Lafortune2009-08-082-4/+6
| | | | | | | | | | | | | | | | :size [#2489 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | Adding :from scoping to ActiveRecord calculationsMatt Duncan2009-08-093-0/+10
| | | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1229 state:committed]
* | Fix HTTP basic authentication for long credentials [#2572 state:resolved]Jan Schwenzien2009-08-092-1/+26
|/ | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Update truncate documentation / examples to more clearly demonstrate its ↵Steve St. Martin2009-08-081-8/+10
| | | | | | | | actual behavior [#3016 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Depend on rubygems 1.3.2Michael Koziarski2009-08-091-1/+1
| | | | Also move the min_version definition up a line so it's present in the rescue block down below.
* Fix exclusive range patch to use begin/end instead of min/max. [#2981 ↵Adam Keys2009-08-082-4/+22
| | | | | | | status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Users can now pass :branch for git plugins and :revision for subversion pluginsMatt Duncan2009-08-082-1/+25
| | | | | | [#2352 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Improved coverage for session_migration generator. [#3008 status:resolved]José Valim2009-08-082-3/+7
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed reference to AR::SessionStore::Session.table_name in session migrationsElad Meidar2009-08-083-2/+20
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* HTTP proxy supportMarshall Huss2009-08-086-3/+118
| | | | | | [#2133 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Allow content_tag options to take an array [#1741 state:resolved] ↵rizwanreza2009-08-082-9/+20
| | | | | | | | | | [rizwanreza, Nick Quaranto] Example: content_tag('p', "limelight", :class => ["song", "play"]) # => <p class="song play">limelight</p> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure hm:t#create/create! throws ActiveRecord::RecordNotSaved when the ↵Pratik Naik2009-08-082-0/+11
| | | | owner is new
* Add test ensuring redirect_to uses the given protocol [#2886]Dan Croak2009-08-081-0/+10
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* DRY migration's rollback/forward methodsPratik Naik2009-08-081-14/+15
|
* Simplyfy validates_length_of and remove putsPratik Naik2009-08-082-5/+7
|
* validates_length_of with maximum should allow nil [#2309 status:resolved]jzw2009-08-082-5/+11
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Allow radio buttons to work with booleans.José Valim2009-08-082-2/+12
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Add :include_blank option for select_tag [#1987 status:resolved]rizwanreza2009-08-082-0/+19
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure db:drop:all doesn't error out on exception [#2997 state:resolved] ↵Pratik Naik2009-08-081-2/+6
| | | | [Anthony Caliendo]
* Add rake db:forward - opposite of db:rollback [#768 state:resolved]Cristi Balan2009-08-083-0/+28
| | | | | | | | Example: rake db:forward # performs the next migration rake db:forward STEP=4 # performs the next 4 migrations Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Polymorphic routes generates collection URL from model class [#1089 ↵Niklas Holmgren2009-08-082-0/+38
| | | | | | | state:resolved] Signed-off-by: Dan Pickett <dpickett@enlightsolutions.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Merge commit 'jose/responder'Yehuda Katz2009-08-0811-67/+89
|\
| * Added rubygems to generators load_paths, but we only load generators from ↵José Valim2009-08-083-21/+43
| | | | | | | | gems that are alraedy activated. This fixes the version problem and avoid silly conflicts.
| * Rename Rails::Generators::ActionORM to Rails::Generators::ActiveModel.José Valim2009-08-084-15/+15
| |
| * Renamed ActionController::Renderer to ActionController::Responder and ↵José Valim2009-08-084-31/+31
| | | | | | | | ActionController::MimeResponds::Responder to ActionController::MimeResponds::Collector.
* | Fixes "Cached fragment hit" written to log even if fragment is not cached ↵Yehuda Katz2009-08-082-2/+17
|/ | | | (Erik Andrejko) [#2917 state:resolved]
* Fixed a bug in JSON decoding with Yaml backend, where a combination of ↵Bas Van Klinkenberg2009-08-082-8/+17
| | | | | | dates, escaped or unicode encoded data and arrays would make the parser fail with a ParseError exception. [#2831 state:resolved] Signed-off-by: Yehuda Katz <wycats@gmail.com>
* First pass at making partial rendering an Object. More cleanup to come.Yehuda Katz2009-08-084-73/+93
|
* remove duplicate call to stringify_keys [#2587 status:resolved]Steve St. Martin2009-08-081-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add test to verify that the new :inverse_of association option will indeed ↵Wolfram Arnold2009-08-082-0/+60
| | | | | | | | fix the validation problem for a belongs_to relationship that validates_presence_of the parent, when both the parent and the child are new (in-memory) records. Also check that this works when the parents adds child via nested_attributes_for. Lastly, add a require 'models/pet' to association_validation_test.rb, so that test can be run independently (was failing due to that missing dependency). [#2815 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 08:24:53 +0000