| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
More robust PostgreSQL database duplication check
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
kamipo/eval_active_storage_attached_name_only_once
Evaluate `@active_storage_attached_#{name}` only once
|
| | |
| | |
| | |
| | |
| | | |
Currently `"@active_storage_attached_#{name}"` in `define_method` is
evaluated every call. It is better to evaluate it only once.
|
|\ \ \
| | | |
| | | | |
Add `null: false` to Active Storage tables
|
| |/ /
| | |
| | |
| | | |
These columns aren't intended nullable.
|
| | |
| | |
| | | |
Fixes #29045.
|
| | | |
|
|/ / |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Fix generator example code [ci skip]
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Fix RDoc formatting: `+` doesn't work with `@` [ci skip]
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
refs: https://github.com/rails/rails/pull/30161
```
$ echo "+@size+" | rdoc --pipe
<p>+@size+</p>
$ echo "<tt>@size</tt>" | rdoc --pipe
<p><code>@size</code></p>
```
[ci skip]
|
|\ \
| | |
| | | |
[ci skip] Update testing.md [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Fix formatting of Active Storage docs [ci skip]
|
|/ /
| |
| |
| | |
Follow up of #30188.
|
|\ \
| | |
| | | |
Fix formatting of Active Storage docs [ci skip]
|
|/ /
| |
| |
| |
| | |
* Use `+` instead of backquote.
* Remove escape from class to be link
|
| | |
|
|\ \
| | |
| | | |
Start `@reaper.run` after connection pool initialized
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise `ConnectionPool#reap` may run before `@connections` has
initialized.
https://travis-ci.org/rails/rails/jobs/263037427#L888-L890
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Isolate ActiveStorage namespaces
* Rename migrations task
[Rafael Mendonça França + Dino Maric]
|
|\ \ \
| | | |
| | | | |
Improve railties generators tests
|
| | | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Improve app generator tests.
Ensure that generation `config/application.rb` is correct.
Ensure that generation `config/application.rb` is correct.
|
|\ \ \
| | | |
| | | | |
Fix random CI failure due to non-deterministic sorting order
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
```
rails/activerecord$ bundle exec rake postgresql:test --verbose TESTOPTS="--seed=36062"
Failure:
AssociationsJoinModelTest#test_has_many_through_polymorphic_has_one
[/home/travis/build/rails/rails/activerecord/test/cases/associations/join_model_test.rb:407]:
--- expected
+++ actual
@@ -1 +1 @@
-[
#<Tagging id: 1, tag_id: 1, super_tag_id: 2, taggable_type: "Post", taggable_id: 1, comment: nil>,
#<Tagging id: 2, tag_id: 1, super_tag_id: nil, taggable_type: "Post", taggable_id: 2, comment: nil>
]
+#<ActiveRecord::Associations::CollectionProxy [
#<Tagging id: 2, tag_id: 1, super_tag_id: nil, taggable_type: "Post", taggable_id: 2, comment: nil>,
#<Tagging id: 1, tag_id: 1, super_tag_id: 2, taggable_type: "Post", taggable_id: 1, comment: nil>
]>
```
|
|\ \ \
| |_|/
|/| | |
Fix a typo in code comment [ci skip]
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
This reverts commit a8f59044fb18ce718367ffe4cd3ec0259c766b5f.
See discussion on https://github.com/rails/rails/pull/30016.
|
| |
| |
| |
| | |
This reverts commit fd7f978a5068921380308fe439af3923566c8f61.
|
|\ \
| | |
| | | |
Fix random CI failure DirtyTest
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
```
rails/activerecord$ bundle exec rake postgresql:test TESTOPTS="--seed=26536"
..(compressed)....F
Failure:
DirtyTest#test_save_should_not_save_serialized_attribute_with_partial_writes_if_not_present [/home/travis/build/rails/rails/activerecord/test/cases/dirty_test.rb:473]:
Expected nil to not be nil.
```
|
|\ \
| |/
|/| |
Fix broken RDoc formatting
|
|/
|
|
|
| |
The `@` ivar format doesn’t work with RDoc's `+` code formatting; needs `<tt>`.
[ci skip]
|
|\
| |
| | |
Fix engine command
|
| | |
|
|\ \
| | |
| | | |
Use the same key as presented in doc
|
| | |
| | |
| | |
| | | |
Ref: https://github.com/rails/rails/blob/a8217bb594a625fb46a6af1488c0bde4aeac4986/railties/lib/rails/generators/rails/app/templates/config/storage.yml#L24
|
|\ \ \
| | | |
| | | | |
Fix non escaped character
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Add missed `require`
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`ActiveRecord::ConnectionAdapters::QueryCache::ConnectionPoolConfiguration`
depends on `Concurrent::Map`.
|
|\ \ \ \
| | | | |
| | | | | |
ActiveStorage:Filter out Minitest backtrace.
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
Filter out Minitest backtrace while allowing backtrace from other
libraries to be shown.
|
|\ \ \ \
| | | | |
| | | | | |
Simplify `git_source` in Gemfile
|
| |/ / /
| | | |
| | | |
| | | | |
Follow up of https://github.com/rails/rails/commit/0b8441bd415c444b8d4afbfc93af79ec7677aa2c
|