| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
[ci skip] Fix rails_command comments
|
| | |
|
|\ \
| | |
| | | |
Fix rubocop issues
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove redundant `unless current_adapter?(:OracleAdapter)`
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[ci skip]
Closes #30012
|
| |/ /
|/| |
| | |
| | | |
And make reference to `Relation`.
|
|\ \ \
| | | |
| | | | |
Fix typo in assert_changes error message
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
albertoalmagro/set-ruby-version-in-gemfile-and-ruby-version-by-default
Set Ruby version in Gemfile and .ruby-version by default
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Avoid duplicate clauses when using #or
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Condenses the clauses that are common to both sides of the OR and put them outside, before the OR
This fix the current behavior where the number of conditions is exponential based on the number of times #or is used.
|
|\ \ \ \
| | | | |
| | | | | |
Fix test directory to correct path
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Together, fix to the following lint violation.
```
rails/actionview/test/ujs/public/test/data-confirm.js
303:11 error Strings must use singlequote quotes
rails/actionview/test/ujs/public/test/data-remote.js
414:32 error Extra semicolon semi
✖ 2 problems (2 errors, 0 warnings)
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix testing helpers that use Action View's capturing helpers (e.g. content_for)
|
| | |/ / /
| |/| | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ Orhan Toy & Kasper Timm Hansen ]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix `warning: method redefined;`
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This fixes the following warning:
```
/tmp/d20170727-7039-kmdtb1/app/app/models/user.rb:5: warning: method redefined; discarding old model_name
rails/activemodel/lib/active_model/naming.rb:222: warning: previous definition of model_name was here
```
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Change http postgresql.org links to https [ci skip]
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
It seems that it accepts only HTTPS connections.
Ref: https://github.com/postgres/postgres/commit/7f77cbd996855a06fb742ea11adbe55c42b48fe2
|
|\ \ \ \
| |_|_|/
|/| | | |
Use frozen string literal in actionpack/
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Building `where_clause` in `UniquenessValidator` is no longer needed
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Building `where_clause` manually was introduced at #26073 to include
both `comparison` and `binds` in `where_clause`. Since 213796f,
`comparison` includes `binds`, so it is enough to use `where` simply.
|
|\ \ \ \
| | | | |
| | | | | |
Use `predicate_builder.build_bind_attribute` wherever possible
|
| | |_|/
| |/| |
| | | |
| | | | |
For less duplicated code.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rails 5.1 introduce an `ActiveSupport::Duration::Scalar` class as
a wrapper around a numeric value as a way of ensuring a duration
was the outcome of an expression. However the implementation was
missing support for modulo operations. This commit adds support
for those operations and should result in a duration being
returned from expressions involving them.
Fixes #29603 and #29743.
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] update routing guide
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
commit 4a3d295f3011e771cddead80de7497ca15d15c13
Author: Yauheni Dakuka <yauheni.dakuka@gmail.com>
Date: Fri Jul 28 14:31:35 2017 +0300
Update routing.md
commit 620a4ce47288e3ef6504290c78f931214968e7e3
Author: Yauheni Dakuka <yauheni.dakuka@gmail.com>
Date: Fri Jul 28 14:19:29 2017 +0300
[ci skip] update routing guide
|
|\ \ \ \
| |/ / /
|/| | | |
[ci skip] update routing guide
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We were expecting those classes to be loaded when an association is
defined but they are not.
If you add a debugger on the first line of any of those classes and try
to define the corresponding association you will see that the classes
are not loaded.
Fixes #26273
|
|\ \ \
| | | |
| | | | |
Fix division where a duration is the denominator
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
PR #29163 introduced a change in behavior when a duration was
the denominator in a calculation - this was incorrect as dividing
by a duration should always return a `Numeric`. The behavior of
previous versions of Rails has been restored.
Fixes #29592.
|
|\ \ \ \
| |/ / /
|/| | | |
Fix an AR test of schema dump when using Oracle
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix search input's type & placeholder conflict in Routing Error page
|
| | |_|/
| |/| | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Anywhere that we're doing `self.class.unscoped.where(primary_key => id)`
is somewhere that someone may want to extend. Even if this method isn't
public API yet, this will make it easier for us to eventually expose an
API around this. Plus, duplicated code makes me sad.
|
| | | |
|
| |/
|/|
| |
| | |
Pointing at Rails master generally requires pointing at Arel master
|
|\ \
| | |
| | | |
Remove single element array preprocess
|
| | |
| | |
| | |
| | |
| | | |
Since 213796f, array predicate handler supports making binds, so the
preprocess is no longer needed.
|
|\ \ \
| | | |
| | | | |
Clarify add_column limit documentation
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The limit option is ignored by PostgreSQL and may be ignored by 3rd
party backends. Make this clear in the docs. Fixes #29922.
|
|\ \ \ \
| |/ / /
|/| | | |
|