aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Improvement on Activerecord CHANGELOGthiagoaugusto2015-05-011-1/+1
| | | | |
* | | | | Merge pull request #19970 from robertomiranda/patch-3Kasper Timm Hansen2015-05-011-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Update documentation to contain a 24 char token [ci skip]
| * | | | | Update documentation to contain a 24 char token [ci skip]Roberto Miranda2015-05-011-1/+1
|/ / / / /
* | | | | add test-case for `link_to_if` behavior with a block.Yves Senn2015-05-011-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This illustrates the purpose of the block for `link_to_if` and `link_to_unless` helper methods. It should help to prevent further mistakes like #19844.
* | | | | Revert "Merge pull request #19844 from ↵Yves Senn2015-05-013-10/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stevenspiel/link_to_if_block_helper_addition" This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3. :sweat: The block is not supposed to be passed to `link_to`. It's used for a customized behavior of the `condtion = false` case. The docs illustrate that like so: ``` <%= link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user }) end %> ```
* | | | | Merge pull request #19844 from stevenspiel/link_to_if_block_helper_additionYves Senn2015-05-013-1/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Update url_helper.rb
| * | | | | Update url_helper.rbSteven Spiel2015-04-211-1/+1
| | | | | | | | | | | | | | | | | | add block to link_to_if when condition is true
* | | | | | Merge pull request #19969 from y-yagi/fix_job_helper_methodYves Senn2015-05-013-2/+30
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | match a expected value with message of `assert_equal` in AJ helper methods
| * | | | | | match a expected value with message of `assert_equal` in AJ helper methodsyuuji.yaginuma2015-05-011-2/+2
|/ / / / / /
* | | | | | Merge pull request #19962 from prathamesh-sonpatki/nodoc-validate-index-lengthYves Senn2015-04-301-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Nodoc validate_index_length! method
| * | | | | | Nodoc validate_index_length! methodPrathamesh Sonpatki2015-04-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - This method is used only by adapters to validate length of new index names.
* | | | | | | Merge pull request #19961 from prathamesh-sonpatki/pg-docsRichard Schneeman2015-04-302-2/+5
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | Added documentation for PostGreSQL database_statements [ci skip]
| * | | | | | Added documentation for PostGreSQL database_statements [ci skip]Prathamesh Sonpatki2015-04-302-2/+5
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Added documentation for index_name_exists? and rename_index. - Also changed rails to \Rails in documentation of allowed_index_name_length.
* | | | | | Merge pull request #19959 from imtayadeway/tw/caching-docsZachary Scott2015-04-291-11/+11
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix style/grammar/typos in Caching guide.
| * | | | | | Fix style/grammar/typos in Caching guide.Tim Wade2015-04-291-11/+11
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | * avoid using unnecessary commas * fix some typos
* | | | | | Add doc for original_exception in ActiveJob::DeserializationError [ci skip]Zachary Scott2015-04-291-0/+2
| | | | | |
* | | | | | Add initial doc for Core in AJ [ci skip]Zachary Scott2015-04-291-0/+2
| | | | | |
* | | | | | Add initial doc for Enqueuing module [ci skip]Zachary Scott2015-04-291-0/+1
| | | | | |
* | | | | | Rails should be nodoc'd here [ci skip]Zachary Scott2015-04-291-1/+1
| | | | | |
* | | | | | Merge pull request #19957 from rywall/patch-2Zachary Scott2015-04-291-0/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Document :tld_length option for cookies.
| * | | | | | Document :tld_length option for cookies.Ryan Wallace2015-04-291-0/+3
| | |_|/ / / | |/| | | |
* | | | | | Merge pull request #19952 from vngrs/activejob_missing_error_messagesYves Senn2015-04-294-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add missing error messages for sucker_punch, sneakers and qu
| * | | | | | Add missing error messages for sucker_punch, sneakers and qu activejob ↵Mehmet Emin İNAÇ2015-04-294-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | adapters [ci skip] fix error message change raise to use rails conventions fix misspells
* | | | | | | Merge pull request #19949 from thiagoaugusto/create-thiago-punctuation-fixYves Senn2015-04-291-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | CHANGELOG punctuation fix
| * | | | | | | CHANGELOG punctuation fixThiago Augusto2015-04-291-1/+1
| | |/ / / / / | |/| | | | | | | | | | | | Punctuation fix
* / | | | | | Revert "Merge pull request #19817 from tpitale/4_2-release-notes-fix"Godfrey Chan2015-04-281-2/+3
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 00aa1afae3821dd858dec7111bcdf230b12040d7, reversing changes made to b584cc68fc28492147ed3ed127ad8a7441ca8161. Reason: As far as we can tell, this should not be the case. Both localhost, 127.0.0.1 and ::1 is "supposed to work", so this is probably a bug somewhere. Reopening #19815 instead.
* | | | | | Merge pull request #19945 from thenickcox/migration_generator_docsZachary Scott2015-04-281-4/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Correct grammar, add docs to ActiveRecord migration generator
| * | | | | | [ci skip] Correct grammar, add docs to ActiveRecord migration generatorNick Cox2015-04-281-4/+5
| | | | | | |
* | | | | | | Merge pull request #19941 from javan/actionmailer-cache-noopRafael Mendonça França2015-04-282-2/+14
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Make ActionMailer #cache helper a no-op, not an exception
| * | | | | | | Make ActionMailer #cache helper a no-op, not an exceptionJavan Makhmali2015-04-282-2/+14
|/ / / / / / /
* | | | | | | Merge pull request #19939 from artofhuman/remove-mocha-from-some-testsRafael Mendonça França2015-04-281-10/+13
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | Remove use of mocha in the named base tests
| * | | | | | Remove use of mocha in the named base testsSemyon Pupkov2015-04-281-10/+13
| | | | | | |
* | | | | | | Merge pull request #19942 from earthrid/masterZachary Scott2015-04-281-4/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Rewording
| * | | | | | | RewordingKevin Busby2015-04-281-4/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rewording in accordance with the documentation guidelines (‘Prefer wordings that avoid "you"s and "your”s.’) and to remove in particular “if you'd call”.
* | | | | | | Merge pull request #19917 from senny/preview_null_mailYves Senn2015-04-285-6/+55
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Previews when `mail` wasn't called (NullMail instances).
| * | | | | | | mailer previews for `NullMail` instances. Closes #19849.Yves Senn2015-04-285-6/+47
| | | | | | | |
| * | | | | | | mailer previews, make sure labels and values line up.Yves Senn2015-04-282-0/+8
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While this was true before when every `dd` had a value, this patch makes sure that everything keeps lining up even when the `dd` node is blank.
* | | | | | | Merge pull request #19932 from axilleas/api_docs_guidelinesYves Senn2015-04-282-2/+7
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | Make sure you execute rake rdoc from rails root directory [ci skip]
| * | | | | | Update instructions to build guides locally [ci skip]Achilleas Pipinellis2015-04-282-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Make clear where rake rdoc is executed 2. Make clear where the generated HTML files for the guides are stored 3. Use bundler 1.3.5 or later
* | | | | | | Merge pull request #19935 from eliotsykes/clarify-configuring-default-test-orderCarlos Antonio da Silva2015-04-281-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Clarify test_order default configuration behaviour [ci skip]
| * | | | | | | Clarify test_order default configuration behaviour [ci skip]Eliot Sykes2015-04-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explain config.active_support.test_order defaults to :random in newly-generated applications thanks to generated config/environments/test.rb, otherwise default is :sorted (until Rails 5.0).
* | | | | | | | Merge pull request #19937 from tak1n/masterCarlos Antonio da Silva2015-04-281-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fixed typo in documentation
| * | | | | | | | fixed typoBenny Klotz2015-04-281-2/+2
| | |_|/ / / / / | |/| | | | | |
* | | | | | | | Merge pull request #19931 from prathamesh-sonpatki/note-about-non-get-linksYves Senn2015-04-281-0/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Added note about non-GET links getting converted to GET links in mailer Added note about non-GET links getting converted to GET links in mailer templates [ci skip]
| * | | | | | | | Added note about non-GET links getting converted to GET links in mailer ↵Prathamesh Sonpatki2015-04-281-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | templates [ci skip]
* | | | | | | | | Merge pull request #19930 from axilleas/doc_smtp_plain_auth_fixYves Senn2015-04-281-2/+2
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | AUTH PLAIN is Base64 encoded [ci skip]
| * | | | | | | | AUTH PLAIN is Base64 encoded [ci skip]Achilleas Pipinellis2015-04-281-2/+2
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Contrary to what the name suggests, PLAIN SMTP authentication is not sent in plain text but is Base64 encoded like the LOGIN method. Their difference is described in the third link below. * https://tools.ietf.org/html/rfc4954 * https://en.wikipedia.org/wiki/SMTP_Authentication * http://www.samlogic.net/articles/smtp-commands-reference-auth.htm
* | / / / / / / guides, bring back minitest assertion table. [ci skip]Yves Senn2015-04-281-3/+43
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails has different naming conventions for the inverse assertion methods. While minitest uses `refute` we use `_not`. We should have a table listing the common assertions that you want to use in the Rails context. Refs #18305.
* | | | | | | Merge pull request #19907 from artofhuman/sneakers-updateYves Senn2015-04-282-8/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Unlock sneakers adapter version
| * | | | | | | Unlock sneakers adapter versionSemyon Pupkov2015-04-282-8/+8
| | | | | | | |