Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| | * | | | Refactor convert_direct_upload_option_to_url | Rafael Mendonça França | 2017-08-03 | 2 | -3/+35 | |
| | | | | | | | | | | | | | | | | | | | | Also make sure file_field doesn't mutate the original options passed in. | |||||
| | * | | | Make sure Action View doesn't break with Active Storage | Rafael Mendonça França | 2017-08-03 | 3 | -1/+50 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception. | |||||
| * | | | | Active Storage routes are now part of the default routes | David Heinemeier Hansson | 2017-08-03 | 1 | -9/+37 | |
| |/ / / | | | | | | | | | | | | | It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented. | |||||
| * | | | Same issue from AR getting loaded earlier | David Heinemeier Hansson | 2017-08-03 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | cc @rafaelfranca | |||||
| * | | | Including new default classes in loading test | David Heinemeier Hansson | 2017-08-03 | 1 | -3/+3 | |
| | | | | ||||||
| * | | | Active Storage loads AR earlier to extend it so require env later | David Heinemeier Hansson | 2017-08-03 | 1 | -3/+7 | |
| | | | | ||||||
| * | | | There is no reason to single line methods here | Rafael Mendonça França | 2017-08-03 | 1 | -4/+12 | |
| |/ / | | | | | | | | | | | | | I know those methods are unlikely to change but having one line method is hard to read and also hard to modify. | |||||
| * | | Generating the app is where the exception is now raised | David Heinemeier Hansson | 2017-08-03 | 1 | -1/+1 | |
| | | | ||||||
| * | | Can't initialize a message verifier without a key base | David Heinemeier Hansson | 2017-08-03 | 1 | -1/+3 | |
| | | | ||||||
| * | | Merge pull request #30053 from ffmike/patch-2 | Richard Schneeman | 2017-08-03 | 1 | -1/+2 | |
| |\ \ | | |/ | |/| | Add Azure gems to README | |||||
| | * | Tweak requires | Mike Gunderloy | 2017-08-02 | 1 | -1/+1 | |
| | | | | | | | | | Omit azure-core (it's required by azure-storage), remove require:false to match other points. | |||||
| | * | Use release azure-core gem | Mike Gunderloy | 2017-08-02 | 1 | -1/+1 | |
| | | | ||||||
| | * | Update README.md | Mike Gunderloy | 2017-08-02 | 1 | -1/+1 | |
| | | | ||||||
| | * | Add Azure gems to README | Mike Gunderloy | 2017-08-02 | 1 | -1/+2 | |
| |/ | ||||||
| * | Merge pull request #30046 from ↵ | Rafael França | 2017-08-02 | 17 | -28/+27 | |
| |\ | | | | | | | | | | | | | kamipo/fix_string_literals_violations_for_active_storage Fix `Style/StringLiterals` violations for Active Storage | |||||
| | * | Fix `Style/StringLiterals` violations for Active Storage | Ryuta Kamizono | 2017-08-03 | 17 | -28/+27 | |
| |/ | | | | | | | | | | | | | | | | | | | | | | | ``` % be rubocop -a --only Style/StringLiterals activestorage Inspecting 74 files ........................................CCCCCCCCCC.C........CC.......C.C.. (snip) 74 files inspected, 31 offenses detected, 31 offenses corrected ``` | |||||
| * | Merge branch 'master' into active-storage-import | David Heinemeier Hansson | 2017-08-02 | 38 | -110/+211 | |
| |\ | ||||||
| * \ | Merge pull request #30040 from rbarysas/active-storage-import | Ryuta Kamizono | 2017-08-02 | 1 | -0/+1 | |
| |\ \ | | | | | | | | | Add Azure to the available services list [ci skip] | |||||
| | * | | Add Azure to the available services list | Rolandas Barysas | 2017-08-02 | 1 | -0/+1 | |
| |/ / | ||||||
| * | | Merge pull request #30035 from ytbryan/patch-1 | Ryuta Kamizono | 2017-08-02 | 1 | -3/+1 | |
| |\ \ | | | | | | | | | Add Azure to readme [ci skip] | |||||
| | * | | Add Azure to readme | Bryan Lim | 2017-08-02 | 1 | -3/+1 | |
| |/ / | | | | | | | previously https://github.com/rails/activestorage/pull/86 | |||||
| * | | Skip if credentials aren't provided | David Heinemeier Hansson | 2017-08-01 | 2 | -2/+2 | |
| | | | ||||||
| * | | Fix dummy app for inclusion in Rails | David Heinemeier Hansson | 2017-08-01 | 1 | -2/+1 | |
| | | | ||||||
| * | | Remove circular dependency | David Heinemeier Hansson | 2017-08-01 | 1 | -2/+0 | |
| | | | ||||||
| * | | Merge branch 'master' into active-storage-import | David Heinemeier Hansson | 2017-08-01 | 17 | -35/+71 | |
| |\ \ | ||||||
| * | | | Prevent interpolation of ERB elements | David Heinemeier Hansson | 2017-08-01 | 1 | -6/+6 | |
| | | | | ||||||
| * | | | Add the storage.yml file by default | David Heinemeier Hansson | 2017-08-01 | 1 | -0/+1 | |
| | | | | ||||||
| * | | | Follow same format as action_cable | David Heinemeier Hansson | 2017-08-01 | 1 | -1/+3 | |
| | | | | ||||||
| * | | | Cut down on installation advice | David Heinemeier Hansson | 2017-08-01 | 1 | -8/+4 | |
| | | | | ||||||
| * | | | Drop README terms no longer relevant | David Heinemeier Hansson | 2017-08-01 | 1 | -12/+0 | |
| | | | | ||||||
| * | | | Add require | David Heinemeier Hansson | 2017-08-01 | 1 | -0/+1 | |
| | | | | ||||||
| * | | | We moved to storage.yml | David Heinemeier Hansson | 2017-08-01 | 2 | -35/+1 | |
| | | | | ||||||
| * | | | Rely on top-level files | David Heinemeier Hansson | 2017-08-01 | 2 | -150/+0 | |
| | | | | ||||||
| * | | | Merge pull request #30034 from ffmike/patch-1 | Guillermo Iguaran | 2017-08-01 | 1 | -0/+8 | |
| |\ \ \ | | | | | | | | | | | Add Azure configuration to Active Storage template | |||||
| | * | | | Add Azure configuration to Active Storage template | Mike Gunderloy | 2017-08-01 | 1 | -0/+8 | |
| |/ / / | | | | | | | | | | | | | | | | | With Active Storage supporting Azure, we should show people how to set it up. Incorporates the minor changes originally in https://github.com/rails/activestorage/pull/88 as well | |||||
| * | | | Merge pull request #30030 from claudiob/only-disk | Guillermo Iguaran | 2017-08-01 | 1 | -1/+3 | |
| |\ \ \ | | | | | | | | | | | Let ActiveStorage tests pass only for Disk | |||||
| | * | | | Let ActiveStorage tests pass only for Disk | claudiob | 2017-08-01 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you have a "service/configurations.yml" file, but every single line is commented out, then an error occurs when running tests: ``` git:active-storage-import~/code/rails/activestorage$ rake ~/code/rails/activestorage/test/test_helper.rb:17:in `<top (required)>': undefined method `deep_symbolize_keys' for false:FalseClass (NoMethodError) from ~/code/rails/activestorage/test/controllers/direct_uploads_controller_test.rb:1:in `require' ``` The reason is that `YAML.load(..an empty file content..)` simply returns `false`, and not `{}`. This PR fixes this behavior so tests can also run when no remote service is available. | |||||
| * | | | | Merge pull request #30032 from claudiob/remove-httparty | Guillermo Iguaran | 2017-08-01 | 5 | -21/+18 | |
| |\ \ \ \ | | |/ / / | |/| | | | Remove HTTParty dependency | |||||
| | * | | | Don't depend on HTTParty | claudiob | 2017-08-01 | 5 | -21/+18 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | "httparty" is only added in #30020 to write two tests to make PUT requests against S3 and GCS. The same requests can be made with net/http, removing a dependency from the Gemfile. | |||||
| * | | | Setup travis to be able to run CI tests against S3 | David Heinemeier Hansson | 2017-07-31 | 5 | -33/+33 | |
| | | | | ||||||
| * | | | Move the direct_upload: true convenience option from the activestorage ↵ | David Heinemeier Hansson | 2017-07-31 | 3 | -20/+10 | |
| | | | | | | | | | | | | | | | | helper into actionview | |||||
| * | | | Move to new storage.yml location | David Heinemeier Hansson | 2017-07-31 | 1 | -0/+0 | |
| | | | | ||||||
| * | | | Directory and config installation now done by app_generator | David Heinemeier Hansson | 2017-07-31 | 1 | -7/+0 | |
| | | | | ||||||
| * | | | Create the skeleton directories needed and ignore accordingly | David Heinemeier Hansson | 2017-07-31 | 2 | -0/+8 | |
| | | | | ||||||
| * | | | Fix gitignore to be relative | David Heinemeier Hansson | 2017-07-31 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Follow form from actioncable | David Heinemeier Hansson | 2017-07-31 | 1 | -1/+4 | |
| | | | | ||||||
| * | | | Load activestorage by default | David Heinemeier Hansson | 2017-07-31 | 2 | -0/+8 | |
| | | | | ||||||
| * | | | Use config/storage.yml as part of the skeleton and loading | David Heinemeier Hansson | 2017-07-31 | 9 | -43/+48 | |
| | | | | ||||||
| * | | | Resolve gemspec typo | David Heinemeier Hansson | 2017-07-31 | 2 | -1/+86 | |
| | | | | ||||||
| * | | | No longer used | David Heinemeier Hansson | 2017-07-31 | 1 | -23/+0 | |
| | | | |