rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \| \| \|	Merge pull request #29619 from kamipo/deprecate_delegating_to_arel_in_relation	Kasper Timm Hansen	2017-06-29	3	-0/+21
\|\ \ \ \ \ \ \ \ \| \|_\|_\|_\|_\|_\|/ / \|/\| \| \| \| \| \| \|	Deprecate delegating to `arel` in `Relation`
\| * \| \| \| \| \| \|	Deprecate delegating to `arel` in `Relation`	Ryuta Kamizono	2017-06-29	3	-0/+21
\|/ / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Active Record doesn't rely delegating to `arel` in the internal since 425f2ca. The delegation is a lower priority than delegating to `klass`, so it is pretty unclear which method is delegated to `arel`. For example, `bind_values` method was removed at b06f64c (a series of changes https://github.com/rails/rails/compare/79f71d3...b06f64c). But a relation still could respond to the method because `arel` also have the same named method (#28976). Removing the delegation will achieve predictable behavior.
* \| \| \| \| \| \|	Merge pull request #29616 from kamipo/remove_unused_aliased_table_name	Rafael França	2017-06-29	2	-9/+0
\|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove unused `aliased_table_name` in `Association`
\| * \| \| \| \| \| \|	Remove unused `aliased_table_name` in `Association`	Ryuta Kamizono	2017-06-29	2	-9/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	`aliased_table_name` in `Association` was added at a3502c4. `aliased_table_name` in `JoinDependency` (added at 55854c4) is used, but it looks like that added one in `Association` is never used from the beginning.
* \| \| \| \| \| \| \|	Merge pull request #29569 from kamipo/fix_to_scoping_is_correctly_restored	Rafael França	2017-06-29	3	-4/+14
\|\ \ \ \ \ \ \ \ \| \|_\|/ / / / / / \|/\| \| \| \| \| \| \|	Fix to scoping is correctly restored
\| * \| \| \| \| \| \|	Fix to scoping is correctly restored	Ryuta Kamizono	2017-06-29	3	-4/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This regression was caused by #23004. If STI subclass is using scoping in parent class scoping, `current_scope` in subclass is never restored. I fixed to restore `current_scope` to previous value correctly.
* \| \| \| \| \| \| \|	Merge pull request #28932 from ↵	Rafael França	2017-06-28	1	-10/+0
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	kamipo/remove_method_missing_in_relation_delegation Remove `method_missing` in `Relation::Delegation`
\| * \| \| \| \| \| \| \|	Remove `method_missing` in `Relation::Delegation`	Ryuta Kamizono	2017-04-30	1	-10/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The `method_missing` is never reached since 64c53d7c.
* \| \| \| \| \| \| \| \|	Merge pull request #29612 from kamipo/use_quote_method_rather_than_single_quote	Rafael França	2017-06-28	5	-13/+12
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use `quote` method rather than single quotes to identifiers in SQL
\| * \| \| \| \| \| \| \| \|	Use `quote` method rather than single quotes to identifiers in SQL	Ryuta Kamizono	2017-06-29	5	-13/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Because identifiers in SQL could include a single quote. Related #24950, #26784.
* \| \| \| \| \| \| \| \| \|	Merge pull request #29129 from kamipo/prevent_extra_through_scope	Rafael França	2017-06-28	1	-2/+4
\|\ \ \ \ \ \ \ \ \ \ \| \|_\|_\|/ / / / / / / \|/\| \| \| \| \| \| \| \| \|	Prevent extra `through_scope`
\| * \| \| \| \| \| \| \| \|	Prevent extra `through_scope`	Ryuta Kamizono	2017-05-18	1	-2/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We can reuse `through_scope` for `reset_association`.
* \| \| \| \| \| \| \| \| \|	Merge pull request #29301 from kamipo/receiver_in_scope_should_be_relation	Rafael França	2017-06-28	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The receiver in a scope should be a `relation`
\| * \| \| \| \| \| \| \| \| \|	The receiver in a scope should be a `relation`	Ryuta Kamizono	2017-06-01	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Currently the receiver in a scope is `klass`, not `relation`. I think it is a strange because the receiver in `default_scope` and a scope on association is `relation`. I fixed to the receiver is to be a `relation` properly for consistency.
* \| \| \| \| \| \| \| \| \| \|	Merge pull request #29416 from kamipo/remove_unused_subject_model	Rafael França	2017-06-28	1	-14/+0
\|\ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove unused `Subject` model in tests
\| * \| \| \| \| \| \| \| \| \| \|	Remove unused `Subject` model in tests	Ryuta Kamizono	2017-06-11	1	-14/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Because `subjects` table doesn't exist.
* \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29076 from ↵	Rafael França	2017-06-28	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	kamipo/use_timestamp_attributes_for_update_in_model Use `timestamp_attributes_for_update_in_model` rather than `timestamp_attributes_for_update`
\| * \| \| \| \| \| \| \| \| \| \| \|	Use `timestamp_attributes_for_update_in_model` rather than ↵	Ryuta Kamizono	2017-05-14	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	`timestamp_attributes_for_update`
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #28928 from kamipo/remove_habtm_initialize	Rafael França	2017-06-28	1	-4/+0
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \|_\|_\|_\|_\|_\|_\|/ / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \|	Remove `HasAndBelongsToManyReflection#initialize`
\| * \| \| \| \| \| \| \| \| \| \| \|	Remove `HasAndBelongsToManyReflection#initialize`	Ryuta Kamizono	2017-04-29	1	-4/+0
\| \| \|_\|_\|_\|_\|/ / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It is delegating `super` only.
* \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29405 from kamipo/locked_should_not_build_arel	Rafael França	2017-06-28	7	-9/+13
\|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	`Relation#locked?` should not build arel
\| * \| \| \| \| \| \| \| \| \| \| \|	Remove delegating to arel in a relation	Ryuta Kamizono	2017-06-29	6	-9/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The delegation was needed since passing `relation` with `relation.bound_attributes`. It should use `relation.arel` in that case.
\| * \| \| \| \| \| \| \| \| \| \| \|	`Relation#locked?` should not build arel	Ryuta Kamizono	2017-06-20	2	-1/+7
\| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29614 from kamipo/show_query_cache_keys_2	Rafael França	2017-06-28	1	-1/+2
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Show query cache keys in `test_middleware_caches`
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Show query cache keys in `test_middleware_caches`	Ryuta Kamizono	2017-06-29	1	-1/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	`test_middleware_caches` also failed same as #29600. https://travis-ci.org/rails/rails/jobs/248017174#L487-L489
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29601 from ↵	Rafael Mendonça França	2017-06-28	3	-11/+22
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	kamipo/fix_eager_loading_to_respect_store_full_sti_class Fix eager loading to respect `store_full_sti_class` setting
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix eager loading to respect `store_full_sti_class` setting	Ryuta Kamizono	2017-06-29	3	-11/+22
\| \| \|_\|_\|_\|_\|_\|_\|/ / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29610 from ↵	Rafael França	2017-06-28	5	-9/+8
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	kamipo/dont_passing_klass_connection_to_association_scope Don't passing `klass.connection` to `AssociationScope`
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	Don't passing `klass.connection` to `AssociationScope`	Ryuta Kamizono	2017-06-29	5	-9/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Passing `klass.connection` is redundant because `AssociationScope` is passed an association itself and an association has `klass`.
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29611 from kamipo/add_test_case_for_unscoping_default_scope	Rafael França	2017-06-28	1	-2/+3
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add a test case for unscoping `default_scope` in associations
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add a test case for unscoping `default_scope` in associations	Ryuta Kamizono	2017-06-29	1	-2/+3
\| \|/ / / / / / / / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Unscoping `default_scope` in associations has already supported (#17360 for preloading, c9cf8b8 for eager loading). Fixes #20679. Closes #16531.
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29609 from tsukasaoishi/query_cache_from_beginning	Rafael França	2017-06-28	3	-20/+13
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \|_\|_\|/ / / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	Enable query cache if set a configurations
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	Enable query cache if set a configurations	Tsukasa OISHI	2017-06-29	3	-20/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ActiveRecord query cache is available when a connection is connected. Therefore, query cache is unavailable when entering the ActiveRecord::Base.cache block without being connected. ```ruby ActiveRecord::Base.cache do Task.find(1) # access to database. Task.find(1) # access to database. unavailable query cache end ``` If we use query cache with batch script etc, we need to connect before that. ```ruby Task.connection ActiveRecord::Base.cache do Task.find(1) # access to database. Task.find(1) # available query cache end ``` Before version 3.1, query cache had been enabled if a configuration was set up. In order to solve the `DATABASE_URL` issue(#8074), ActiveRecord has checked whether a connection is connected or not. Today, ActiveRecord.configurations respect `DATABASE_URL`. https://github.com/rails/rails/blob/master/activerecord/lib/active_record/core.rb#L46
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29613 from jajajames/jajajames-patch-1	Richard Schneeman	2017-06-28	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \|_\|_\|/ / / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix grammar for documentation of rails/command.rb [ci skip]
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix grammar for documentation of rails/command.rb [ci skip]	James Bush	2017-06-28	1	-1/+1
\|/ / / / / / / / / / / / / /
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29604 from ↵	Rafael França	2017-06-28	2	-5/+2
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	kamipo/fix_ids_reader_to_respect_case_sensitive_pk Fix `ids_reader` to respect case sensitive primary key
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Fix `ids_reader` to respect case sensitive primary key	Ryuta Kamizono	2017-06-28	2	-5/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	```ruby car = Car.create!(name: "Tofaş") # Before car.bulb_ids # => SELECT "bulbs".ID FROM "bulbs" WHERE "bulbs"."name" = $1 AND "bulbs"."car_id" = $2 [["name", "defaulty"], ["car_id", 3]] # After car.bulb_ids # => SELECT "bulbs"."ID" FROM "bulbs" WHERE "bulbs"."name" = $1 AND "bulbs"."car_id" = $2 [["name", "defaulty"], ["car_id", 3]] ```
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29602 from kamipo/use_reload_in_test_find_first_after_reload	Rafael França	2017-06-28	1	-10/+10
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \|_\|/ / / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \|	Use `reload` in `test_find_first_after_reload`
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Use `reload` in `test_find_first_after_reload`	Ryuta Kamizono	2017-06-28	1	-10/+10
\| \|/ / / / / / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	And use `assert_same` instead of `assert_equal` and tiny fix assert message s/#reload/#reset/. Follow up of #29511.
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29600 from kamipo/show_query_cache_keys	Rafael França	2017-06-28	1	-1/+2
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Show query cache keys in `test_exceptional_middleware_clears_and_disables_cache_on_error`
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Show query cache keys in ↵	Ryuta Kamizono	2017-06-28	1	-1/+2
\| \|/ / / / / / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	`test_exceptional_middleware_clears_and_disables_cache_on_error` `test_exceptional_middleware_clears_and_disables_cache_on_error` in postgresql adapter sometime fails recently. Show the query cache keys to investigte the cause. https://travis-ci.org/rails/rails/jobs/246467252#L490-L493
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29588 from greysteil/add-gemspec-links	Rafael França	2017-06-28	8	-0/+40
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add source code and changelog links to gemspecs
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Add source code and changelog links to gemspecs	Grey Baker	2017-06-28	8	-0/+40
\| \| \|_\|_\|_\|_\|_\|_\|_\|_\|_\|/ / \| \|/\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29595 from fatkodima/result_lambda_class_checking	Rafael França	2017-06-28	2	-2/+2
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda	fatkodima	2017-06-27	2	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \| \|	:scissors:	Ryuta Kamizono	2017-06-28	2	-5/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[ci skip]
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29593 from kratob/master	Eileen M. Uchitelle	2017-06-28	3	-0/+23
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \|_\|_\|/ / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \|	ActiveRecord: do not create "has many through" records that have been removed
\| * \| \| \| \| \| \| \| \| \| \| \| \|	ActiveRecord: do not create "has many through" records that have been removed	Tobias Kraze	2017-06-28	3	-0/+23
\| \| \|/ / / / / / / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	If a record was built on a HasManyThroughAssociation, then removed, and then the record was saved, the removed record would be created anyways.
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #29533 from jdelStrother/missing_url_formats	Richard Schneeman	2017-06-27	2	-0/+11
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix missing formats in route-set URLs
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Fix missing formats in route-set URLs	Jonathan del Strother	2017-06-23	2	-0/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Before this change, handle_positional_args would end up mutating @segment_keys if inner_options included path components. Subsequent calls would then be missing the implicit path components. eg: user_path(1, :json) # => "/users/1.json" (correct) user_path(1, format: :json) # => "/users/1.json" (correct, but @segment_keys was mutated) user_path(1, :json) # => "/users/1" (oh no!)