Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use cached column information to instantiate time object | Carlos Antonio da Silva | 2012-08-18 | 1 | -6/+6 |
| | |||||
* | Refactor blank date parameter validation | Carlos Antonio da Silva | 2012-08-18 | 1 | -2/+6 |
| | |||||
* | Refactor missing parameter validation based on position | Carlos Antonio da Silva | 2012-08-18 | 2 | -8/+12 |
| | |||||
* | Reuse already fetched column to check for :time | Carlos Antonio da Silva | 2012-08-18 | 1 | -5/+6 |
| | | | | | Avoid doing a new column lookup for the attribute, since we already have the column to check for the klass. | ||||
* | Refactor some code in multiparameter assignment | Carlos Antonio da Silva | 2012-08-18 | 1 | -26/+25 |
| | | | | | Move some methods to the top to better organize them, since they're used right at the beginning of the multiparameter assignment method chain. | ||||
* | Extract nested parameter assignment to a separate method | Carlos Antonio da Silva | 2012-08-18 | 1 | -3/+6 |
| | |||||
* | Merge pull request #6903 from guilleiguaran/dalli-memcache-store | Santiago Pastorino | 2012-08-17 | 5 | -42/+37 |
|\ | | | | | Replace deprecated `memcache-client` gem with `dalli` in ActiveSupport::Cache::MemCacheStore | ||||
| * | Add test to cover increment/decrement of non-existing key in MemCacheStore | Guillermo Iguaran | 2012-08-17 | 1 | -0/+2 |
| | | |||||
| * | Replace deprecated `memcache-client` gem with `dalli` in ↵ | Guillermo Iguaran | 2012-08-17 | 5 | -42/+35 |
|/ | | | | | | ActiveSupport::Cache::MemCacheStore memcache-client was deprecated in favour of dalli in 2010. | ||||
* | Merge pull request #7380 from ↵ | Aaron Patterson | 2012-08-17 | 2 | -2/+21 |
|\ | | | | | | | | | ernie/fix-nomethoderror-on-non-attribute-equalities Fix merge error when Equality LHS is non-attribute | ||||
| * | Fix merge error when Equality LHS is non-attribute | Ernie Miller | 2012-08-17 | 2 | -2/+21 |
| | | | | | | | | | | | | | | | | | | This is at best a band-aid for a more proper fix, since it won't truly handle the removal of the previous equality condition of these other nodes. I'm planning to put in some work on ARel toward supporting that goal. Related: rails/arel#130, ernie/squeel#153, ernie/squeel#156 | ||||
* | | Merge pull request #7381 from IPGlider/master | Rafael Mendonça França | 2012-08-17 | 1 | -2/+2 |
|\ \ | | | | | | | Update to activerecord-deprecated_finders on generator | ||||
| * | | Update to activerecord-deprecated_finders on generator | Miguel Herranz | 2012-08-17 | 1 | -2/+2 |
|/ / | |||||
* | | Pull more serialize code into a lazy included module | Jon Leighton | 2012-08-17 | 1 | -60/+63 |
| | | |||||
* | | don't call method unless we need to | Jon Leighton | 2012-08-17 | 1 | -1/+1 |
| | | |||||
* | | align them assignments | Jon Leighton | 2012-08-17 | 1 | -4/+4 |
| | | |||||
* | | Optimize for the happy path | Jon Leighton | 2012-08-17 | 1 | -11/+14 |
| | | | | | | | | | | | | Checking respond_to? incurs overhead, and most of the time when assigning attributes it will return true. So just handle the NoMethodError instead. | ||||
* | | Avoid #any? | Jon Leighton | 2012-08-17 | 1 | -1/+1 |
| | | | | | | | | | | | | any? will check that each item in the array is truthy, as opposed to !empty? which will simply check that the array has length. For an empty array, !empty? still seems to be faster than any? | ||||
* | | The default value can be set once in #column_defaults | Jon Leighton | 2012-08-17 | 2 | -9/+16 |
| | | | | | | | | Rather than doing it every time an instance is instantiated. | ||||
* | | Optimize instantiation for models which don't use serialize | Jon Leighton | 2012-08-17 | 1 | -13/+20 |
| | | | | | | | | Those z's were hard to type. | ||||
* | | Avoid deep_dup when intantiating. | Jon Leighton | 2012-08-17 | 1 | -2/+5 |
| | | | | | | | | | | deep_dup is slow. we only need to dup the values, so just do that directly. | ||||
* | | column default extraction should handle newlines. | Aaron Patterson | 2012-08-17 | 2 | -2/+10 |
| | | | | | | | | Fixes #7374 | ||||
* | | Merge pull request #7352 from aripollak/microsecond-timestamp | Rafael Mendonça França | 2012-08-17 | 4 | -3/+10 |
|\ \ | | | | | | | Fix occasional microsecond conversion inaccuracy | ||||
| * | | Fix occasional microsecond conversion inaccuracy | Ari Pollak | 2012-08-15 | 4 | -3/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::ConnectionAdapters::Column#microseconds did an unnecessary conversion to from Rational to float when calculating the integer number of microseconds. Some terminating decimal numbers in base10 are repeating decimal numbers in base2 (the format of float), and occasionally this causes a rounding error. Patch & explanation originally from Logan Bowers. | ||||
* | | | Merge pull request #7373 from hollowspace/patch-1 | Vijay Dev | 2012-08-17 | 1 | -10/+10 |
|\ \ \ | | | | | | | | | Fix slightly broken Markdown syntax in actionpack/CHANGELOG.md | ||||
| * | | | Fix slightly broken Markdown syntax in actionpack/CHANGELOG.md | hollowspace | 2012-08-17 | 1 | -10/+10 |
| | | | | |||||
* | | | | Increase benchmark time to 20 seconds. | Jon Leighton | 2012-08-17 | 1 | -18/+18 |
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | I think that 5 seconds was a bit low for our purposes. Also enable it to be configured via env vars. We also need to scale the number of records up/down depending on how long we're running the benchmark for. | ||||
* | | | Use benchmark/ips to measure AR performance | Jon Leighton | 2012-08-17 | 2 | -39/+36 |
| | | | | | | | | | | | | | | | | | | This means we can more easily compare numbers, and we don't have to specify a single N for all reports, which previously meant that some tests were running many more/fewer iterations than necessary. | ||||
* | | | Renaming active_record_deprecated_finders to activerecord-deprecated_finders | Jon Leighton | 2012-08-17 | 7 | -13/+13 |
|/ / | | | | | | | For consistency with the other AR extension plugins we are creating. | ||||
* | | Merge pull request #7024 from bogdan/strict_validation_custom_exception | Rafael Mendonça França | 2012-08-16 | 5 | -5/+40 |
|\ \ | | | | | | | | | | | | | | | | | | | AM::Validation#validates: custom exception for :strict option Conflicts: activemodel/CHANGELOG.md | ||||
| * | | AM::Validation#validates: ability to pass custom exception to `:strict` option | Bogdan Gusiev | 2012-08-06 | 5 | -4/+32 |
| | | | |||||
* | | | Remove the active_model require from action_dispatch. | Rafael Mendonça França | 2012-08-16 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | Since we removed the ActiveModel dependenxy from ActionPack at 166dbaa7526a96fdf046f093f25b0a134b277a68 we don't need to require it anymore. Closes #7370 | ||||
* | | | remove reference to humans.txt from release notes | Vijay Dev | 2012-08-16 | 1 | -2/+0 |
| | | | | | | | | | | | | This was reverted in https://github.com/rails/rails/commit/fb883318c8b82b3570cee022ddf6886f9052245d | ||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-08-16 | 20 | -87/+176 |
|\ \ \ | |_|/ |/| | | |||||
| * | | copy edits [ci skip] | Vijay Dev | 2012-08-16 | 2 | -13/+13 |
| | | | |||||
| * | | tiny formatting fix in i18n guide [ci skip] | Vijay Dev | 2012-08-15 | 1 | -1/+1 |
| | | | |||||
| * | | Minor language fix. [ci skip] | Erich Menge | 2012-08-15 | 1 | -2/+2 |
| | | | |||||
| * | | corrected grammar [ci skip] | Mikhail | 2012-08-14 | 1 | -2/+2 |
| | | | |||||
| * | | add breathing to reading sentences for flow, cut down the run-ons [ci skip] | Soon Van | 2012-08-13 | 2 | -16/+16 |
| | | | |||||
| * | | space for stack overflow; not when you get into things [ci skip] | Soon Van | 2012-08-13 | 2 | -4/+4 |
| | | | |||||
| * | | Add mini-profiler to performance testing, useful links | Philipp Weißensteiner | 2012-08-12 | 1 | -1/+2 |
| | | | |||||
| * | | Minor punctuation fix in api documentation guide [ci skip] | Carlos Antonio da Silva | 2012-08-11 | 1 | -1/+1 |
| | | | |||||
| * | | proper casing in pronouns; relocate the pro git book [ci skip] | Soon Van | 2012-08-11 | 4 | -36/+36 |
| | | | | | | | | | | | | | | | | | | | | | | | | - Cases in point - GitHub, Git, Twitter and Rails should start with capitals when used outside code context - Pro Git found - URL has been updated for its new home - Faces for links - More descriptive titles on link prompt instead of "here" | ||||
| * | | Fix caching guide (plural model name) [ci skip] | Franco Catena | 2012-08-10 | 1 | -2/+2 |
| | | | |||||
| * | | Document the namespacing of controller actions per this discussion: | schneems | 2012-08-09 | 1 | -0/+11 |
| | | | | | | | | | https://github.com/rails/journey/issues/40 | ||||
| * | | add around_create callback documentation for ActiveModel::Callbacks | andrea longhi | 2012-08-08 | 1 | -0/+11 |
| | | | |||||
| * | | For adding non css/js files to precompile array | lulalala | 2012-08-07 | 1 | -0/+2 |
| | | | |||||
| * | | Update list of finder methods | Oscar Del Ben | 2012-08-06 | 1 | -0/+3 |
| | | | |||||
| * | | edit of previous content | Weston Platter | 2012-08-04 | 1 | -19/+59 |
| | | | | | | | | | | | | | | | | | | explains how to add/override engine classes in the main rails app via 1) Class#class_eval 2) ActiveSupport::Concern | ||||
| * | | Add extra documentation to the locale file. | Steve Klabnik | 2012-08-04 | 1 | -2/+21 |
| | | |