aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Prevent conflict between mime types and Object methodsMircea Pricop2012-07-064-2/+33
| | | | | | | | | | | | | | | | | | | | | | | Assuming the type ":touch", Collector.new was calling send(:touch), which instead of triggering method_missing and generating a new collector method, actually invoked the private method `touch` inherited from Object. By generating the method for each mime type as it is registered, the private methods on Object can never be reached by `send`, because the `Collector` will have them before `send` is called on it. To do this, a callback mechanism was added to Mime::Type This allows someone to add a callback for whenever a new mime type is registered. The callback then gets called with the new mime as a parameter. This is then used in AbstractController::Collector to generate new collector methods after each mime is registered.
* Show the records in Relation#inspectJon Leighton2012-07-063-6/+17
| | | | | | | | | | | | | | | | | The reason for removing the previous implementation of `#inspect` was that it hid from you that you were dealing with a `Relation` rather than an `Array`. But it is still useful to be able to see the records, particularly if you're writing something like the following in tests: assert_equal [foo], Post.where(:bar) If the assertion fails, you want to see what records were actually loaded. So this implementation makes it clear that you've got a `Relation`, but also shows your records.
* Merge pull request #6927 from parndt/patch-3Carlos Antonio da Silva2012-07-052-3/+3
|\ | | | | Make ArgumentError message more consistent in nested attributes
| * Made ArgumentError messages consistent.Philip Arndt2012-07-062-3/+3
| |
* | Revert "push parameter instantiation to one method"Aaron Patterson2012-07-051-1/+1
| | | | | | | | | | | | | | This reverts commit 9669f6f7883787aa209207cab68b1069636aed9e. This breaks Sam Ruby's tests for some reason. Revert until we figure it out.
* | Merge branch 'master' into testcleanAaron Patterson2012-07-059-6/+81
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Add documentation for inheritance_column method Use ArgumentError vs. RuntimeError, which is more precise. CSV fixtures aren't supported by default anymore, update generated test_helper.rb to reflect that fix quoting for ActiveSupport::Duration instances Add few information on the field types Add the options method to action_controller testcase.
| * \ Merge pull request #6976 from vitorbal/masterCarlos Antonio da Silva2012-07-051-1/+3
| |\ \ | | | | | | | | Add documentation for inheritance_column method [ci skip]
| | * | Add documentation for inheritance_column methodVitor Balocco2012-07-051-1/+3
| |/ /
| * | Merge pull request #6957 from francois2metz/options_methodCarlos Antonio da Silva2012-07-052-2/+12
| |\ \ | | | | | | | | Add the options method to action_controller testcase.
| | * | Add the options method to action_controller testcase.François de Metz2012-07-042-2/+12
| | | | | | | | | | | | | | | | Signed-off-by: François de Metz <francois@stormz.me>
| * | | Merge pull request #6959 from robin850/patch-1José Valim2012-07-051-0/+49
| |\ \ \ | | | | | | | | | | Add few information on the field types
| | * | | Add few information on the field typesRobin Dupret2012-07-041-0/+49
| | |/ /
| * | | Merge pull request #6967 from frodsan/quite_as_durationRafael Mendonça França2012-07-053-1/+15
| |\ \ \ | | | | | | | | | | fix quoting for ActiveSupport::Duration instances
| | * | | fix quoting for ActiveSupport::Duration instancesFrancesco Rodriguez2012-07-043-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes quoting for ActiveSupport::Duration instances: # before >> ActiveRecord::Base.connection.quote 30.minutes => "'--- 1800\n...\n'" # after >> ActiveRecord::Base.connection.quote 30.minutes => "1800" Also, adds a test for type casting ActiveSupport::Duration instances. Related to #1119.
| * | | | Merge pull request #6969 from mkdynamic/patch-1Jeremy Kemper2012-07-041-1/+1
| |\ \ \ \ | | | | | | | | | | | | Use ArgumentError vs. RuntimeError, which is more precise
| | * | | | Use ArgumentError vs. RuntimeError, which is more precise.Mark Dodwell2012-07-041-1/+1
| |/ / / /
| * | | | Merge pull request #6968 from guilleiguaran/update-test-helperRafael Mendonça França2012-07-041-1/+1
| |\ \ \ \ | | | | | | | | | | | | CSV fixtures aren't supported by default anymore, update generated test_helper.rb to reflect that
| | * | | | CSV fixtures aren't supported by default anymore, update generated ↵Guillermo Iguaran2012-07-041-1/+1
| |/ / / / | | | | | | | | | | | | | | | test_helper.rb to reflect that
* | | | | Merge branch 'master' into testcleanAaron Patterson2012-07-045-13/+19
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: activesupport gem dependencies should reflect the versions we actually use fix link and add activeresource link in release notes page [ci skip] Update 4.0 Release Notes Kill not used constant since removal of runner method
| * | | | activesupport gem dependencies should reflect the versions we actually useAaron Patterson2012-07-043-1/+2
| |/ / /
| * | | Merge pull request #6961 from frodsan/fix_release_noteSantiago Pastorino2012-07-041-2/+2
| |\ \ \ | | |/ / | |/| | fix link and add activeresource link in release notes page [ci skip]
| | * | fix link and add activeresource link in release notes page [ci skip]Francesco Rodriguez2012-07-041-2/+2
| |/ /
| * | Update 4.0 Release NotesRafael Mendonça França2012-07-041-1/+15
| | | | | | | | | | | | Related with 17d2115e3df6caf15d554b44e28177069fa3ed5b
| * | Kill not used constant since removal of runner methodCarlos Antonio da Silva2012-07-031-9/+0
| | | | | | | | | | | | Runner method was removed in ada571bfcdbad669ae43a4dd18277ef227680a0b.
* | | push parameter instantiation to one methodAaron Patterson2012-07-031-1/+1
| | |
* | | add Mime.fetch so we can have default mime typesAaron Patterson2012-07-032-2/+6
| | |
* | | make the default environment have actual defaultsAaron Patterson2012-07-032-3/+16
| | | | | | | | | | | | | | | | | | instead of deleting keys on every instantiation, create defaults we actually use. eventually we can pass an environment in to the request, and create a new req / res object on each call.
* | | assing the request on the response only onceAaron Patterson2012-07-031-4/+5
| | |
* | | group things that are alikeAaron Patterson2012-07-032-10/+10
| | |
* | | push functional test specific methods to it's own moduleAaron Patterson2012-07-032-9/+15
| | |
* | | test should be testing to_param not to_s, remove Array subclassAaron Patterson2012-07-032-7/+3
| | |
* | | push the cookie writing stuff out of the controllerAaron Patterson2012-07-032-23/+8
| | | | | | | | | | | | merging cookies is responsibility of the test runner
* | | extend the controller with special logic on recycleAaron Patterson2012-07-032-16/+28
| | | | | | | | | | | | | | | | | | For some reason, this special logic is only supposed to be executed on the second request. For now, we'll extend on recycle, but we should figure out why this functionality can't be run on every request
* | | push req / res setting to the test runnerAaron Patterson2012-07-032-5/+10
| | | | | | | | | | | | | | | Try to avoid making the controller mutate itself so that we can eventually make the response async
* | | extract response setting to a methodAaron Patterson2012-07-031-2/+8
|/ /
* | remove duplicate requires of mocha.Aaron Patterson2012-07-033-4/+0
| | | | | | | | | | Mocha is already required by AS::TestCase, so remove the duplicate requires.
* | remove the runner method copied from minitestAaron Patterson2012-07-031-20/+7
| |
* | hook mocha in through m/t before_setup, after_teardown hooksAaron Patterson2012-07-034-9/+26
| |
* | Merge pull request #6948 from frodsan/plugin_skip_ignoreRafael Mendonça França2012-07-032-1/+9
|\ \ | | | | | | remove test/dummy from gitignore when "plugin new -T"
| * | remove test/dummy from gitignore when "plugin new -T"Francesco Rodriguez2012-07-032-1/+9
| | |
* | | Merge branch 'lexmag-reference_statements'Rafael Mendonça França2012-07-038-40/+226
|\ \ \ | |/ / |/| | | | | Closes #6920
| * | Don't need to use delete in the options hashRafael Mendonça França2012-07-032-3/+2
| | |
| * | Add changelog entry for references statementsAleksey Magusev2012-07-031-0/+13
| | |
| * | Refactor references schema definitionsAleksey Magusev2012-07-032-34/+24
| | |
| * | Make references statements reversibleAleksey Magusev2012-07-032-4/+40
| | |
| * | Add references schema statementsAleksey Magusev2012-07-033-1/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Examples: add_reference :products, :supplier, polymorphic: true, index: true remove_reference :products, :user `add_belongs_to` and `remove_belongs_to` are acceptable.
* | | Merge pull request #6946 from threedaymonk/queue-refsAaron Patterson2012-07-033-45/+132
|\ \ \ | |/ / |/| | Ensure that queued jobs are marshallable
| * | Make TestQueueTest work with marshalling queuePaul Battley2012-07-031-25/+60
| | | | | | | | | | | | | | | This requires all jobs to be instances of named classes, without block implementations of methods.
| * | Ensure jobs do not refer to the queuePaul Battley2012-07-031-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | Jobs pushed to the queue should not contain a reference to it. As the queue itself cannot be marshalled, and as a consequence of checking the marshallability of all jobs in the test environment, we can now guarantee this to be the case in the test environment when using the default TestQueue implementation.
| * | Ensure test jobs are marshallablePaul Battley2012-07-032-8/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By marshalling and unmarshalling jobs when adding them to the test queue, we can ensure that jobs created during test runs are valid candidates for marshalling, and, thus, that they can be used with queueing backends other than the default simple in-process implementation. This will also be used in a subsequent commit to ensure that jobs pushed to the queue do not contain a reference to the queue itself.