| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Added more tests for reserved hash keys of ActiveJob::Arguments.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Added tests for checking all reserved hash keys of ActiveJob::Arguments.
- Moved unrelated code from the test to the correct place, i.e. newly created
test.
|
|\ \ \ \ \ \ \
| |_|_|_|/ / /
|/| | | | | | |
use rails 5 favicon.ico for rails guides [ci skip]
|
| | |_|/ / /
| |/| | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Document and Match the Rails logger interface
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features.
We are also matching the stdout logging interface to the default logger in bootstrap https://github.com/rails/rails/blob/f5a5988352b165143f0f9d622707c351c1470882/railties/lib/rails/application/bootstrap.rb#L42-L45.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Creates development and test databases in db:migrate task
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts a334425caff9b2140d5e99fcfc2eb8c4ab10bdfa.
The main reason is that now the workflow is inconsistent when using
spring.
When using spring `RAILS_ENV` is always set, so only one database is
created.
This means that in development `bin/rake db:create` and `bundle exec
rake db:create` have different results.
It also breaks the `bin/setup` script since `bin/rake db:setup
db:test:prepare` will fail.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
fix a comment in atom_feed_helper.rb
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improve ActiveSupport::Dependencies code understanding
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In a previous patch, all log-related stuff was removed. However,
some logs are still useful to understand the code. Therefore, in
this patch, I put those log messages back as comments.
[ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This configuration improves git diff, git log -p -W, git grep -p, ...,
and allows to inspect the history of a method with a command like
git log -L:new_constants_in:activesupport/lib/active_support/dependencies.rb
Let me also appeal to authority by saying it is present in the Ruby
repository as well
https://github.com/ruby/ruby/blob/trunk/.gitattributes
:)
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If the code reaches that line new_constants is no longer needed.
We only need here to iterate over it to discard stuff and done.
Note that constant_watch_stack.new_constants returns a new
reference each time it is invoked, so that #clear call was not
cleaning state in some internal structure (which would have been
a bit dirty as well at this level of coupling).
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This array literal cannot be reached. The previous begin either
returns to the caller via the explicit return in the ensure
block if all goes well, or else propagates whatever make the
begin block abort execution.
I have investigated the origin of this a bit. In the past the
ensure block didn't have a return call, see for example c08547d.
Later on the return was added in 4da4506, but the trailing
literal was left there.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
References #24205.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Lets have the server and the Rake task go through the same ropes, so we can
share all the file lookup, adding, and deleting code.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update action_controller_overview.md
|
|/ / / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Remove log-related stuff from ActiveSupport::Dependencies
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
In this patch, all log-related stuff in `ActiveSupport::Dependencies`
is removed because the logging is no longer useful.
|
|\ \ \ \
| | | | |
| | | | | |
Correct command for generating secret_key_base [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
[ci skip] Fix the FinderMethods#find document
|
|/ / / /
| | | |
| | | |
| | | | |
We should use #find_or_initialize_by and #find_or_create_by because #first_or_initialize and #first_or_create methods are not the public API
|
|\ \ \ \
| | | | |
| | | | | |
add `queue_classic` to list of provide `provider_job_id` [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
add headers to payload list [ci skip]
|
| | |/ /
| |/| |
| | | |
| | | | |
Follow up to #24115.
|
|\ \ \ \
| | | | |
| | | | | |
silence deprecation message for dynamic controller and actions on Action View test
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
View test
Follow up to #23980.
|
|\ \ \ \
| | | | |
| | | | | |
Add explanation about accepts_nested_attributes_for keys in the strong parameters docs
|
| |/ / /
| | | |
| | | |
| | | | |
parameters documentation [skip ci]
|
|\ \ \ \
| |/ / /
|/| | | |
Fix `warning: method redefined; discarding old female`
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
```
$ ARCONN=mysql2 be ruby -w -Itest test/cases/scoping/default_scoping_test.rb
Using mysql2
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: method redefined; discarding old female
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: previous definition of female was here
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: method redefined; discarding old male
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/scoping/named.rb:158: warning: previous definition of male was here
```
|
|\ \ \
| | | |
| | | | |
Fix Gemfile.lock
|
|/ / /
| | |
| | |
| | |
| | | |
- Resque version was locked to < 1.26 in 92f869a0c85268 but
Gemfile.lock was not updated.
|
|\ \ \
| | | |
| | | | |
regenerate application_mailer.rb if it is missing
|
| | | | |
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/case_sensitive_comparison_for_non_string_column
The BINARY Operator is only needed for string columns
|
| | | |
| | | |
| | | |
| | | | |
Follow up to #13040.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Right now referencing the constant `AbstractController::Rendering`
causes `ActionView::Base` to be loaded, and thus the load hooks for
action_view are run. If that load hook references any part of action
view that then references action controller (such as
`ActionView::TestCase`), the constant `AbstractController::Rendering`
will attempt to be autoloaded and blow up.
With this change, `ActionView::LoadPaths` no longer requires
`ActionView::Base` (which it had no reason to require). There was a
needed class from `AbstractController::Base` in the Rendering module,
which I've moved into its own file so we don't need to load
all of `AbstractController::Base` there.
This commit fixes
https://github.com/rails/rails-controller-testing/issues/21
|
|\ \ \ \
| | | | |
| | | | | |
Clarify has_many :dependent option docs [ci skip]
|