| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Allow passing interpolations to #default_i18n_subject in mailers
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
# config/locales/en.yml
en:
user_mailer:
welcome:
subject: 'Hello, %{username}'
# app/mailers/user_mailer.rb
class UserMailer < ActionMailer::Base
def welcome(user)
mail(subject: default_i18n_subject(username: user.name))
end
end
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes improper database name when creating a new rails app with a '.'
Conflicts:
railties/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | |
| | | |
application. EG: `rails new something.awesome.com`
Conflicts:
railties/CHANGELOG.md
|
| | |
| | |
| | |
| | | |
https://github.com/rails/rails/commit/4beb4dececcf10c642c74fbcb8548c833e921a86#commitcomment-2482869
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since the default in Rails 4.0 is to run in 'threadsafe' mode we need
to eager load all of the paths in `autoload_paths` so we alias
`eager_load_paths` to it. This may have unintended consequences if
you have added 'lib' to `autoload_paths` such as loading unneeded
code or code intended only for development and/or test environments.
If this applies to your application you should thoroughly check what
is being eager loaded.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
or the ConnectionPool silently fails to close connections inside the Thread
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 4e05bfb8e254c3360a3ca4a6cb332995314338fe.
Reason: BlankTopic#blank? should not be removed to check that dynamic finder with a bang can find a model that responds to `blank?`
|
| | | |
|
| | |
| | |
| | |
| | | |
this would give us some more clues in case a test silently dies inside Thread
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Travis only has PostgreSQL 9.1.x but 9.2 is required for range datatypes.
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Postgresql range support
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The native JSON library bypasses the `to_json` overrides in
active_support/core_ext/object/to_json.rb by calling its native
implementation directly. However `ActiveRecord::Store` uses a
HWIA so `JSON.dump` will call our `to_json` instead with a
`State` object for options rather than a `Hash`. This generates
a warning when the `:encoding`, `:only` & `:except` keys are
accessed in `Hash#as_json` because the `State` object delegates
unknown keys to `instance_variable_get` in its `:[]` method.
Workaround this warning in the test by using a custom coder that
calls `ActiveSupport::JSON.encode` directly.
|
|\ \
| | |
| | | |
Adding the route_key and param_key tests
|
| | |
| | |
| | | |
This way all the tests are testing the same fields
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
* ASCII_STRING was not an ASCII String
* BYTE_STRING was not an in valid UTF-8 String
* added an assertion for non-UTF-8 String
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
|\ \
| | |
| | | |
Remove old asset tags API from docs
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit e9d2ad395ec2ef929d74752f3d71c80674044fbe.
Closes #8460
Conflicts:
activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb
activerecord/test/cases/dirty_test.rb
|
| | |
| | |
| | |
| | | |
Add a test case to ensure that fractional second updates are detected.
|
|\ \ \
| | | |
| | | | |
Revert locale
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 43e14f8ff203c21646f733d35bdde4e68da70a3b, reversing
changes made to bb17a0f085aba40a1952612f6c98b2a5804a1152.
Conflicts:
railties/lib/rails/generators/rails/app/templates/config/application.rb
railties/lib/rails/generators/rails/app/templates/config/initializers/locale.rb
Reason: setting the Time.zone in an after_initialize block can become a
problem for people upgrading, since it's not going to be available when
config/initializers run, and people might be relying on it.
An example that I noticed was with the Chronic gem, for date/time parsing.
It requires us to configure the time class to be Time.zone, and doing
that in an initializer no longer worked with these changes, so reverting
is the safer path for now.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
configuration"
This reverts commit 39374aa925a7d670b039c0c0c9aa9f4aef19466b.
|
| |/ /
| | |
| | |
| | | |
This reverts commit 46902908910c041e268429d674bbe084399cc664.
|
| | | |
|
|/ /
| |
| |
| | |
action_on_unpermitted_parameters is present
|
| |
| |
| |
| | |
This was a suggestion of @carlosantoniodasilva, thanks!
|
|\ \
| | |
| | | |
Remove unnecessary require
|