aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove deprecated config.serve_static_filesRafael Mendonça França2017-01-033-29/+4
|
* Remove deprecated `config.static_cache_control`Rafael Mendonça França2017-01-034-24/+6
|
* Merge pull request #21233 from ↵Rafael França2017-01-0325-114/+207
|\ | | | | | | | | mtsmfm/disable-referential-integrity-without-superuser-privileges Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser privileges
| * Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser ↵Fumiaki MATSUSHIMA2016-12-0325-114/+207
| | | | | | | | | | | | | | | | | | privileges ref: 72c1557254 - We must use `authors` fixture with `author_addresses` because of its foreign key constraint. - Tests require PostgreSQL >= 9.4.2 because it had a bug about `ALTER CONSTRAINTS` and fixed in 9.4.2.
* | Merge pull request #25522 from ↵Rafael França2017-01-033-20/+24
|\ \ | | | | | | | | | | | | kamipo/fix_select_rows_method_signature_for_consistency Fix `select_rows` method signature for consistency
| * | Fix `select_rows` method signature for consistencyRyuta Kamizono2017-01-043-20/+24
| | | | | | | | | | | | | | | | | | | | | | | | Related #22973, #24708. `select_all`, `select_one`, `select_value`, and `select_values` method signature is `(arel, name = nil, binds = [])`. But `select_rows` is `(sql, name = nil, binds = [])`.
* | | Remove unneeded requires at active recordRafael Mendonça França2017-01-033-5/+0
| | |
* | | Merge pull request #25626 from maclover7/jm-standardize-ac-readmeRafael França2017-01-031-0/+9
|\ \ \ | | | | | | | | Standardize Action Cable README.md
| * | | Standardize Action Cable README.mdJon Moss2016-07-021-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | All other Rails components feature this section, Action Cable should have it as well. [ci skip]
* | | | Merge pull request #26689 from kamipo/deprecate_passing_name_to_indexesRafael Mendonça França2017-01-037-5/+29
|\ \ \ \ | | | | | | | | | | | | | | | Deprecate passing `name` to `indexes` like `tables`
| * | | | Deprecate passing `name` to `indexes` like `tables`Ryuta Kamizono2017-01-047-5/+29
| | | | | | | | | | | | | | | | | | | | | | | | | Passing `name` to `tables` is already deprecated at #21601. Passing `name` to `indexes` is also unused.
* | | | | Remove deprecation of using ActiveRecord::Base instance in .updateRafael Mendonça França2017-01-033-6/+5
| | | | |
* | | | | Remove deprecated db:test:clone* tasksRafael Mendonça França2017-01-032-24/+4
| | | | |
* | | | | Merge pull request #27560 from kamipo/fix_test_name_deprecated_to_not_permittedRafael Mendonça França2017-01-031-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix test name `deprecated` to `not_permitted`
| * | | | | Fix test name `deprecated` to `not_permitted`Ryuta Kamizono2017-01-031-2/+2
|/ / / / / | | | | | | | | | | | | | | | Follow up to 4b6709e818177792735e99a70ec03210c0ac38dc.
* | | | | Merge pull request #27559 from maclover7/jm-ar-changelog-grammarJon Moss2017-01-031-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | Rephrase CHANGELOG.md entry
| * | | | Rephrase CHANGELOG.md entryJon Moss2017-01-031-1/+1
| | |/ / | |/| | | | | | | | | | | | | | | | | | Rephrase entry with better sounding English. [ci skip]
* | | | Merge pull request #25460 from maclover7/jm-uncachedSean Griffin2017-01-031-0/+21
|\ \ \ \ | |/ / / |/| | | Add explicit testing for `uncached` vs. `cached`
| * | | Add explicit testing for `uncached` vs. `cached`Jon Moss2016-06-211-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | There are a ton of middleware related tests in this file, and it seems like `cached vs. `uncached` is being neglected. Added in a test to confirm the expected behavior.
* | | | Generate indexed names in input even when objects are not persistedRafael Mendonça França2017-01-032-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you ask to generate multiple nested inputs using: field_for('comments[]', Comment.new) do |c| c.text_field :body Rails should generated the names like `post[comments][][body]`. To make sure we don't have regression the fake models now use the same implementation of `#to_param` as `ActiveRecord::Base` Fixes #26942
* | | | Merge pull request #26352 from kamipo/avoid_to_call_set_inverse_instance_twiceArthur Nogueira Neves2017-01-032-2/+2
|\ \ \ \ | | | | | | | | | | Avoid to call `set_inverse_instance` twice for `has_many` association
| * | | | Avoid to call `set_inverse_instance` twice for `has_many` associationRyuta Kamizono2016-12-282-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | `create`, `create!`, and `concat` in `has_many` association hits `set_inverse_instance` twice. It is enough to hit only once.
* | | | | Merge pull request #25927 from y-yagi/remove_needless_warning_for_hstoreSean Griffin2017-01-031-5/+0
|\ \ \ \ \ | | | | | | | | | | | | remove needless warning for hstore
| * | | | | remove needless warning for hstoreyuuji.yaginuma2016-08-151-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 5 supports only Postgresql 9.1 or higher, warning is needless because in the case of Postgresql 9.0 or less does not work.
* | | | | | Merge pull request #27517 from maclover7/jm-fix-27502Sean Griffin2017-01-033-0/+34
|\ \ \ \ \ \ | | | | | | | | | | | | | | Compare deserialized values for `PostgreSQL::OID::Hstore` types
| * | | | | | Compare deserialized values for `PostgreSQL::OID::Hstore` typesJon Moss2017-01-033-0/+34
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per the regression commit below, the commit changes the behavior of `#changed?`to consult the `#changed_in_place?` method on `Type::Value` classes. Per this change, `PostgreSQL::OID::Hstore` needs to override this method in order to compare the deserialized forms of the two arguments. In Ruby, two hashes are considered equal even if their key order is different. This commit helps to bring that behavior to `Hstore` values. Fixes regression introduced by 8e633e505880755e7e366ccec2210bbe2b5436e7 Fixes #27502
* | | | | | Merge pull request #24596 from maclover7/jm-cleanup-3Kasper Timm Hansen2017-01-032-4/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | Extract variant setter to process method
| * | | | | | Extract variant setter to process methodJon Moss2017-01-022-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide an API interface similar to how format is handled in Controllers. In situations where variants are not needed (ex: in Action Mailer) the method will simply trigger a no-op, and will not affect end users.
* | | | | | | [ci skip] Find and record the article! 🤓Kasper Timm Hansen2017-01-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #27555. [ Ben A. Morgan & Kasper Timm Hansen ]
* | | | | | | Raise ArgumentError when a instance of ActiveRecord::Base is passed toRafael Mendonça França2017-01-034-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | find and exists?
* | | | | | | Merge pull request #24814 from vipulnsward/24811-fix-double-tasksArthur Nogueira Neves2017-01-031-1/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Don't list out tasks as separately that are under lib, which cause them to be listed twice under Libraries and tasks.
| * | | | | | | Don't list out tasks as separately that are under lib, which cause them to ↵Vipul A M2016-07-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | be listed twice under Libraries and tasks. We already count and list it under libraries. Fixes #24811
* | | | | | | | Merge pull request #27363 from amatsuda/refined_array_sumSean Griffin2017-01-031-2/+7
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Refining Array#sum monkey-patch using Refinements
| * | | | | | | | Refining Array#sum monkey-patch using RefinementsAkira Matsuda2016-12-151-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because we don't want to see our ugly orig_sum method outside of this file
* | | | | | | | | Merge pull request #27548 from tylerhunt/fix-duplicate-disable-withSean Griffin2017-01-032-14/+25
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Prevent duplicate data-disable-with attributes
| * | | | | | | | | Prevent duplicate data-disable-with attributesTyler Hunt2017-01-032-14/+25
| | |_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using the hash form of the data option, prevent duplicate data-disable-with attributes from appearing in the submit tag due to both string and symbol forms of the hash key being present.
* | | | | | | | | Merge pull request #27538 from davidsherline/guides-bi-dir-associationsSean Griffin2017-01-031-23/+41
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Clarify Bi-directional Associations docs
| * | | | | | | | | Clarify Bi-directional Associations docsDavid Sherline2017-01-031-23/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails automatically finds bi-directional associations between models with well-named associations. However, when using non-standard naming, you have to use :inverse_of to explicitly tell Rails about the bi- directional association. With reference to #27516 [ci skip]
* | | | | | | | | | Merge pull request #27335 from kamipo/remove_duplicated_model_definitionSean Griffin2017-01-032-10/+4
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Remove duplicated model class definitions in `test/cases/base_test.rb`
| * | | | | | | | | | Remove duplicated model class definitions in `test/cases/base_test.rb`Ryuta Kamizono2016-12-122-10/+4
| | | | | | | | | | |
* | | | | | | | | | | Consistently apply adapter behavior when serializing arraysSean Griffin2017-01-035-17/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In f1a0fa9 we moved backend specific timestamp behavior out of the type and into the adapter. This was in line with our general attempt to reduce the number of adapter specific type subclasses. However, on PG, the array type performs all serialization, including database encoding in its serialize method. This means that we have converted the value into a string before reaching the database, so no adapter specific logic can be applied (and this also means that timestamp arrays were using the default `.to_s` method on the given object, which likely meant timestamps were being ignored in certain cases as well) Ultimately I want to do a more in depth refactoring which separates database serializer objects from the active model type objects, to give us a less awkward API for introducing the attributes API onto Active Model. However, in the short term, we follow the solution we've applied elsewhere for this. Move behavior off of the type and into the adapter, and use a data object to allow the type to communicate information up the stack. Fixes #27514.
* | | | | | | | | | | Merge pull request #27435 from kamipo/follow_up_25307Sean Griffin2017-01-033-4/+4
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Active Record supports MySQL >= 5.1.10
| * | | | | | | | | | | Active Record supports MySQL >= 5.1.10Ryuta Kamizono2016-12-223-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #25307 and #23458. Related with #27422. We are using `information_schema.referential_constraints` since #25307. The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is enough to support >= 5.1.10 at least. MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011. MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013.
* | | | | | | | | | | | Merge pull request #27491 from kamipo/add_missing_emit_warningSean Griffin2017-01-031-0/+5
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Add missing `emit_warning_if_needed` for `changed?`
| * | | | | | | | | | | | Add missing `emit_warning_if_needed` for `changed?`Ryuta Kamizono2016-12-291-0/+5
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #27537 from Le6ow5k1/stiAndrew White2017-01-034-10/+33
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / / / / / |/| | | | | | | | | | | | Cache results of computing model type
| * | | | | | | | | | | | Cache results of computing model typeKonstantin Lazarev2017-01-034-10/+33
|/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We faced a significant performance decrease when we started using STI without storing full namespaced class name in type column (because of PostgreSQL length limit for ENUM types). We realized that the cause of it is the slow STI model instantiation. Problematic method appears to be `ActiveRecord::Base.compute_type`, which is used to find the right class for STI model on every instantiation. It builds an array of candidate types and then iterates through it calling `safe_constantize` on every type until it finds appropriate constant. So if desired type isn't the first element in this array there will be at least one unsuccessful call to `safe_constantize`, which is very expensive, since it's defined in terms of `begin; rescue; end`. This commit is an attempt to speed up `compute_type` method simply by caching results of previous calls. ```ruby class MyCompany::MyApp::Business::Accounts::Base < ApplicationRecord self.table_name = 'accounts' self.store_full_sti_class = false end class MyCompany::MyApp::Business::Accounts::Free < Base end class MyCompany::MyApp::Business::Accounts::Standard < Base # patch .compute_type there end puts '======================= .compute_type =======================' Benchmark.ips do |x| x.report("original method") do MyCompany::MyApp::Business::Accounts::Free.send :compute_type, 'Free' end x.report("with types cached") do MyCompany::MyApp::Business::Accounts::Standard.send :compute_type, 'Standard' end x.compare! end ``` ``` ======================= .compute_type ======================= with types cached: 1529019.4 i/s original method: 2850.2 i/s - 536.46x slower ``` ```ruby 5_000.times do |i| MyCompany::MyApp::Business::Accounts::Standard.create!(name: "standard_#{i}") end 5_000.times do |i| MyCompany::MyApp::Business::Accounts::Free.create!(name: "free_#{i}") end puts '====================== .limit(100).to_a =======================' Benchmark.ips do |x| x.report("without .compute_type patch") do MyCompany::MyApp::Business::Accounts::Free.limit(100).to_a end x.report("with .compute_type patch") do MyCompany::MyApp::Business::Accounts::Standard.limit(100).to_a end x.compare! end ``` ``` ====================== .limit(100).to_a ======================= with .compute_type patch: 360.5 i/s without .compute_type patch: 24.7 i/s - 14.59x slower ```
* | | | | | | | | | | | Merge pull request #27543 from ↵Kasper Timm Hansen2017-01-024-41/+50
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_update_counters_of_multiple_records_with_touch Fix update counters of multiple records with touch: true
| * | | | | | | | | | | | Counter cache touching don't need object finding anymoreRyuta Kamizono2017-01-031-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `current_time_from_proper_timezone` and timestamp attributes methods was pushed up to class method.
| * | | | | | | | | | | | Push `current_time_from_proper_timezone` and timestamp attributes methods up ↵Ryuta Kamizono2017-01-032-35/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to class method Actually these methods don't need instantiation.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 08:32:01 +0000