| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |/ / / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Conflicts:
activerecord/lib/active_record/associations/preloader/through_association.rb
activerecord/test/cases/associations/eager_test.rb
|
| |\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
|/| | | | | | | | |
When strong_parameters had been included, this case of update became possible
|
| |/ / / / / / / / |
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
SIGTERM is the correct signal for a graceful exit.
This will hopefully resolve #9761.
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
I don't think this is testing anything useful, and the test code is
exceedingly brittle. It is broken since
34c7e73c1def1312e59ef1f334586ff2f668246e because the test code makes
assumptions about the implementation of PostgreSQLAdapter#active? which
are incorrect after the commit.
I could fix this test but it would be even more brittle (by stubbing the
underlying @connection.connect_poll) and it doesn't test any complex
logic. I conclude that it's not worth it.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Change Standard error when is required bcrypt-ruby and fails
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Allow fixture_path to be a Pathname
|
| |/ / / / / / / |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Adding a bang to method name of raise_on_type_mismatch.
|
| |/ / / / / / / |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Tidying up some require and removing overhead caused by sorting
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
rest of the code the wat the includes are done
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
Fix copy table index test; Change == to ! on false in travis.rb
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Update other counter caches on destroy
|
| | |/ / / / / / / |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Fix missing action_missing
Conflicts:
actionpack/CHANGELOG.md
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
A recent change introduced the assumption that all controller actions
are known beforehand, which is not true when using action_missing.
|
| |\ \ \ \ \ \ \ \ \
| |_|/ / / / / / /
|/| | | | | | | | |
Don't generate a scaffold.css when --no-assets is specified
|
| |/ / / / / / / / |
|
| | | | | | | | | |
|
| | |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
mysql can't handle a parallel thread pinging the connection, so we can
get wrong results or segvs
This reverts commit 7cc588b684f6d1af3e7fab1edfa6715e269e41a2.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Removed unnecessary block
|
| | | | | | | | | |
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
Closes #9824.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix some typos in AR- CHANGELOG, tests, method doc. fixed
|
| | | |/ / / / /
| |/| | | | | |
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix a typo
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Changed the call to .sort.last to .max when computing the migration version
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
do not actually need to sort everything (incurs more cost than just a
simple max).
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Commas aren't comas.
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Type a fixo.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix improperly configured host in generated urls
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If the host in `default_url_options` is accidentally set with a protocol such as
```
host: "http://example.com"
```
then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention.
This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host.
I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted.
This is based off of work in #7415 cc/ @pixeltrix
ATP Action Mailer and Action Pack
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix guides error on error class name
|
| |/ / / / / / /
| | | | | | |
| | | | | | | |
The error that's raised in case the required key is missing it's actually `ActionController::ParameterMissing` not `ActionController::MissingParameter`. It's important to fix so that people reading the guides knows what error to rescue from when needed.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Find() on an association with an inverse will now scan existing in-memory records
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
if the association already holds that record in memory before checking
the database for the specified ids.
|
| |\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
remove unused payloads in blocks in caching instrumentation
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
fix sentence [ci skip]
|
| |/ / / / / / / |
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fixed the repair_validations helper method.
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
it only cleared the validations that created :validate callbacks. This
didn't include the validates created by validates_with, so I've added a
method to clear all validations.
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix warning: mismatched indentatmmismatched indentations at 'end' with 'def'
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
drop an unused hash; change slang to SPECIAL
|
