aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #25638 from kamipo/remove_unused_predicate_builderSean Griffin2016-07-023-19/+3
|\ | | | | Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`
| * Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`Ryuta Kamizono2016-07-023-19/+3
| |
* | Merge pull request #25644 from Edouard-chin/forgotten-doc-removalVipul A M2016-07-021-1/+0
|\ \ | | | | | | `partial` option on the digest method is no more needed [ci skip]:
| * | `partial` option on the digest method is no more needed [ci skip]:Edouard CHIN2016-07-021-1/+0
| | | | | | | | | | | | - `partial` option is not used anymore, this was removed in https://github.com/rails/rails/pull/23724
* | | Merge pull request #25646 from y-yagi/refer_to_rails_command_instead_of_rakeVipul A M2016-07-021-3/+3
|\ \ \ | | | | | | | | refer to rails command instead of rake in doc of `SourceAnnotationExtractor`
| * | | refer to rails command instead of rake in doc of `SourceAnnotationExtractor` ↵yuuji.yaginuma2016-07-021-3/+3
| | | | | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #25222 from vipulnsward/25219-fix-logsMatthew Draper2016-07-023-9/+29
|\ \ \ \ | |_|/ / |/| | | Clean backtrace in IRB
| * | | - Added test for verifying that we treat line number indications from irb as ↵Vipul A M2016-07-011-8/+16
| | | | | | | | | | | | | | | | | | | | | | | | user/lib code - Cleaned up backtrace cleaner test code and removed instaces variables
| * | | Fixes #25219Vipul A M2016-07-012-1/+13
| | | | | | | | | | | | | | | | Add handling of cleaning up backtrace from IRB console in case of errors
* | | | Try the newest bundlerRafael Mendonça França2016-07-021-4/+0
| |/ / |/| |
* | | Merge pull request #25639 from y-yagi/followup_to_25431Rafael França2016-07-021-1/+1
|\ \ \ | | | | | | | | fix task name to remove
| * | | fix task name to removeyuuji.yaginuma2016-07-021-1/+1
|/ / / | | | | | | | | | Follow up to #25431
* | | Merge pull request #25507 from ↵Rafael França2016-07-023-14/+17
|\ \ \ | | | | | | | | | | | | | | | | bquorning/optimize-for-first-result-and-remove-mysql-select_one Remove #select_one from Mysql2Adapter
| * | | Optimize ActiveRecord::Result#lastBenjamin Quorning2016-06-242-1/+7
| | | | | | | | | | | | | | | | | | | | If you only want the last element of a result set, there's no need to create all of hash_rows. Also, add a test.
| * | | Remove MySQL::DatabaseStatements#select_oneBenjamin Quorning2016-06-241-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation from abstract/database_statements.rb seems to work just fine. And with ActiveRecord::Result now implementing an optimized #first method, the performance concerns previously addressed in https://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f should not be an issue.
| * | | Add ActiveRecord::Result#firstBenjamin Quorning2016-06-242-0/+10
| | | | | | | | | | | | | | | | | | | | When you only need the first element of a result set, you shouldn't need to instantiate all of hash_rows.
* | | | Merge pull request #24177 from vipulnsward/rename-testRafael França2016-07-011-1/+1
|\ \ \ \ | | | | | | | | | | Renamed NestedParametersTest to NestedParametersPermitTest
| * | | | - Renamed NestedParametersTest to NestedParametersPermitTest, to indicate ↵Vipul A M2016-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | what we are actually testing in this file
* | | | | Merge pull request #25631 from yahonda/revert_rename_to_ar_internal_metadataRafael França2016-07-012-28/+0
|\ \ \ \ \ | | | | | | | | | | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata"
| * | | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata`"Yasuo Honda2016-07-012-28/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.
* | | | | | Merge pull request #25633 from kamipo/remove_create_table_info_cacheRafael França2016-07-011-6/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove `create_table_info_cache` because it not be reused
| * | | | | | Remove `create_table_info_cache` because it not be reusedRyuta Kamizono2016-07-021-6/+1
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `create_table_info_cache` is used for sharing `create_table_info` both `table_options` and `foreign_keys`. But `foreign_keys` no longer uses `create_table_info_cache` by #25307. No need caching anymore.
* | | | | / Do not run `bundle install` when generating a new plugin.Rafael Mendonça França2016-07-016-103/+112
| |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
* | | | | Merge pull request #25625 from voxik/fix-rails-test-git-layoutRafael França2016-07-011-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Do not depend on Rails git repository layout in ActiveSupport tests.
| * | | | | Do not depend on Rails git repository layout in ActiveSupport tests.Vít Ondruch2016-07-011-2/+2
| | | | | |
* | | | | | Merge pull request #25620 from kamipo/create_without_primary_keyRafael França2016-07-012-1/+9
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
| * | | | | Pass `pk: false` to `connection.insert` explicitly if do not have a primary keyRyuta Kamizono2016-07-012-1/+9
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | Because causing an extra query by `sql_for_insert` for guessing a primary key. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
* | | | | Fix conditional order broken in ea40ec56.Kasper Timm Hansen2016-07-021-2/+2
| | | | |
* | | | | Merge pull request #25344 from matthewd/debug-locksMatthew Draper2016-07-024-5/+172
|\ \ \ \ \ | | | | | | | | | | | | ActionDispatch::DebugLocks
| * | | | | Provide a middleware to debug misbehaving locksMatthew Draper2016-06-104-5/+172
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only intended to be enabled when in use; by necessity, it sits above any reasonable access control.
* | | | | | Merge pull request #24146 from matthewd/latch-as-proxyMatthew Draper2016-07-021-5/+12
|\ \ \ \ \ \ | | | | | | | | | | | | | | Don't inherit from Concurrent::CountDownLatch
| * | | | | | Don't inherit from Concurrent::CountDownLatchMatthew Draper2016-03-111-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That class mangles .new, which interferes with our deprecation warning. More generally, it suggests we shouldn't be subclassing without a very good reason, and avoiding one allocation doesn't seem to meet that criteria. In passing, recommend the simpler Concurrent::Event for the common count=1 case.
* | | | | | | Merge pull request #25615 from tinco/close_hijacked_socketMatthew Draper2016-07-022-0/+15
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | close hijacked i/o socket after use (fixes #25613)
| * | | | | | | close hijacked i/o socket after use (fixes #25613)Tinco Andringa2016-07-012-0/+15
| | | | | | | |
* | | | | | | | Ensure logging on exceptions only includes what we expectMatthew Draper2016-07-021-0/+23
| | | | | | | |
* | | | | | | | Silence DebugExceptions template render logs during exceptionsGenadi Samokovarov2016-07-021-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an exception is raised, those Action View rendering logs are just noise for the end developer. I recently silenced those from Web Console, as we do use Action View rendering in it as well. It used created a half a screen of rendering logs. I think we can save those in this recent push for cleaner development logs. Now, the silencing is a bit hacky and we have a bunch of it now, so we can also invest in turning off the logs directly from Action View objects instead of silencing off the logging stream.
* | | | | | | | Make mutation stand out some more.Kasper Timm Hansen2016-07-011-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Felt that += overwriting the path variable was a little too hidden. Make the outcomes easier to spot with an if-else branch.
* | | | | | | | Merge pull request #25632 from volmer/fix-integration-test-frozen-literalsKasper Timm Hansen2016-07-011-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix request encoding in tests when string literals are frozen
| * | | | | | | | Fix request encoding in tests when string literals are frozenVolmer2016-07-011-1/+1
| | |_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running tests with `--enable-frozen-string-literal` or `# frozen_string_literal: true`, it's currently attempted to mutate the path string in order to append the format, causing a `RuntimeError`. ```ruby get '/posts', as: :json ``` ``` RuntimeError: can't modify frozen String ``` This commit fixes the problem by replacing the mutation with a concatenation, returning a new string.
* | | | | | | | Merge pull request #25600 from pan/constantize-docfixVipul A M2016-07-011-4/+4
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | fix ActiveSupport::Infector.constantize usage API doc [ci skip]
| * | | | | | | fix ActiveSupport::Infector.constantize usage API doc [ci skip]Pan GaoYong2016-06-301-4/+4
| | | | | | | |
* | | | | | | | Add regression test for foreign key schema dump cachingeileencodes2016-07-011-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you had a foreign key set and then decided to add `on_delete: :cascade` later in another migration that migration would run but wouldn't refresh the schema dump. The reason for this was because `create_table_info` caches the statement and sets it to be the same as the original declaration for the foreign key (without the `on_delete: :cascade`. PR #25307 ended up fixing this bug because it removes the check for `create_table_info` and relies on reading from `information_schema`. The fix however was intended to patch another bug. The reason this fixes the issue is we're no longer parsing the regex from the cached `create_table_info`. This regression test is to ensure that the issue does not return if we for some reason go back to using `create_table_info` to set the foreign keys.
* | | | | | | | Merge pull request #25307 from ↵Eileen M. Uchitelle2016-07-015-36/+46
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/extract_foreign_key_action_from_information_schema Extract foreign key action from `information_schema`
| * | | | | | | | Extract foreign key action from `information_schema`Ryuta Kamizono2016-06-074-34/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #25300.
| * | | | | | | | Make `foreign_keys` queries to `SCHEMA`Ryuta Kamizono2016-06-072-2/+2
| | | | | | | | |
* | | | | | | | | Fix release task now that NPM is part of the buildeileencodes2016-07-011-18/+22
| |_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note: this commit looks super weird becuase git. I'm moving the entire NPM section to the part where we actually push the gems/npm package for the reasons below. That's not how the git diff looks though. When we release Rails we run `rake prep_release` which calls `update_versions`. This was updating the NPM version as well. But when we would later run `rake install` to test the installed gem `update_versions` gets called again which causes the install to fail because NPM sees the version is the same as the last run and refuses to continue. If you forget to stash this will then cause the push to RubyGems to fail because `update_versions` is called again and then NPM will not continue because it thinks the version hasn't been changed even though it has. The correct solution would be to not update the NPM verion if it matches the version already in the file but after an hour I could not find a simple way to use NPM to read the current version. Honestly that's not the best way to do it either because say you forget to update something else and then the script thinks it's already been updated. With that in mind I think the best solution is to not update the NPM version until right before we are going to push to NPM because then that won't cause the push to RubyGems to fail.
* | | | | | | | Merge pull request #25618 from kamipo/fix_release_notesRafael França2016-07-011-4/+0
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Deprecation passing of `start` value was removed [ci skip]
| * | | | | | | | Deprecation passing of `start` value was removed [ci skip]Ryuta Kamizono2016-07-011-4/+0
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | ref #18961, #23099.
* | | | | | | | Merge pull request #25582 from alexcameron89/action_controller_baseप्रथमेश Sonpatki2016-07-011-4/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | [ci skip] Add 'params' formatting in ActionController::Base
| * | | | | | | | [ci skip] Add 'params' formatting in ActionController::BaseAlex Kitchens2016-06-301-4/+4
| | | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-17 20:53:17 +0000