| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
| |
transitioning to new association" until a proper fix is found for #10197
|
| |\
| |
| | |
ActiveRecord having clause bug fix
|
| | |
| |
| |
| | |
should be empty.
|
| |\ \
| |/
|/| |
refactor initialization of array
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The changes in b79adc4323 had a bug where if the time in the String
was in standard time but the current time was in daylight savings then
the calculated adjustment was off by an hour.
This commit fixes this and adds extra tests for the following:
* time in string is standard time, current time is standard time
* time in string is standard time, current time is daylight savings
* time in string is daylight savings, current time is standard time
* time in string is daylight savings, current time is daylight savings
Fixes #10306.
|
| | | |
|
| | | |
|
| |\ \
| |/
|/| |
extract arrays to constants in Mapper
|
| | | |
|
| |\ \
| | |
| | | |
Remove redundant variable
|
| | |/ |
|
| |\ \
| |/
|/| |
Use MethodNotAllowed exception rather than UnknownHttpMethod
|
| | | |
|
| |\ \
| | |
| | | |
Created a registry for ActiveSupport::Subscriber queues
|
| |/ /
| |
| |
| | |
subscriber queues. Helps limit the number of thread locals.
|
| |\ \
| | |
| | | |
Also assign nil in dirty nullable_datetime test. Closes #10237
|
| | |/ |
|
| |\ \
| | |
| | | |
Update counter cache when pushing into association
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit fixes a regression bug in which counter_cache columns
were not being updated correctly when newly created records were
being pushed into an assocation. EG:
# this was fine
@post.comment.create!
# this was fine
@comment = Comment.first
@post.comments << @comment
# this would not update counters
@post.comments << Comment.create!
|
| |\ \ \
| |_|/
|/| | |
extract no content response codes to a constant
|
| | | | |
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| |\ \ \
| |/ /
|/| | |
Fixes skipping object callback filters
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This allows you to skip callbacks that are defined by objects, e.g. for
`ActionController`:
skip_after_filter MySpecialFilter
Previously this didn't work due to a bug in how Rails compared callbacks
in `Callback#matches?`. When a callback is compiled, if it's an object
filter (i.e. not a method, proc, etc.), `Callback` now defines a method on
`@klass` that is derived from the class name rather than `@callback_id`.
So, when `skip_callback` tries to find the appropriate callback to
remove, `Callback` can regenerate the method name for the filter
object and return the correct value for `Callback#matches?`.
|
| |\ \ \
| |_|/
|/| | |
extract array to a constant
|
| |/ / |
|
| |\ \
| | |
| | | |
Extract path into variable
|
| |/ / |
|
| |\ \
| | |
| | | |
fix README links in the main README.md
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
neerajdotname/fix-wrong-test-name-and-failure-message
fix wrong test description and failure message
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Added tests for if condition in Active Model callbacks
|
| | |/ / |
|
| |\ \ \
| | | |
| | | | |
Removing tests for deprecated options in active support.
|
| |/ / /
| | |
| | |
| | |
| | | |
+use_full_path+ option was removed in 3b3790a4 and passing the template
handler to render was deprecated in 43d27e91.
|
| |\ \ \
| | | |
| | | | |
fix typos [ci skip]
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Increase readability of ternary statement in build method
|
| |/ / / / |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Object#respond_to? returns singletons and thus we inherit that contract.
The implementation of the predicate is good, but the test is only
checking boolean semantics, which in this case is not enough.
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The entry is basically copy & paste of the commit message, but the CHANGELOG
has a different purpose than Git history, it just communicates what is new:
* No need to explain why did the bug happen (unless it is truly relevant).
* No need to explain how was the bug fixed.
* Whether the user gives new names to columns does not really matter, use of
select to cherry-pick a column for example also presented that behaviour.
Non-selected attributes are the key, either because they were not included
in the selected list, or because they were but with a different alias.
* In the case of an attribute alias, what you really want to depict is that
respond_to? returns false for the original attribute name.
|
| |\ \ \
| |/ /
|/| | |
Typo Fix in AR CHANGELOG [ci skip]
|
| |/ / |
|
| |\ \
| | |
| | | |
fix respond_to? for non selected column
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
fixes #4208
If a query selects only a few columns and gives custom names to
those columns then respond_to? was returning true for the non
selected columns. However calling those non selected columns
raises exception.
post = Post.select("'title' as post_title").first
In the above case when `post.body` is invoked then an exception is
raised since `body` attribute is not selected. Howevere `respond_to?`
did not behave correctly.
pos.respond_to?(:body) #=> true
Reason was that Active Record calls `super` to pass the call to
Active Model and all the columns are defined on Active Model.
Fix is to actually check if the data returned from the db contains
the data for column in question.
|
| |\ \
| | |
| | | |
symbolize_keys => symbolize_keys! on new hash; change sentence
|
