| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Removed deprecated default_scopes?
|
| | |
|
|\ \
| | |
| | | |
s/plugin_new/plugin
|
| | |
| | |
| | |
| | |
| | | |
There are historical reasons that the `plugin` command was `plugin_new`, now those are no longer applicable, we should remove the naming edge case from the project. This PR is based off of comments from #11176
ATP Railties
|
|\ \ \
| | | |
| | | | |
Remove redundant escapes from xml serialization test
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Further clean-up of ActiveSupport::Callbacks
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In #11195 I noticed a trailing comma in the docs, but I decided to
further clean it up.
What I have done:
* Clean up the trailing comma in the docs and some extra whitespace
lines.
* Used `Array#extract` options to factor the repetitive pattern of
`args.last.is_a(Hash) ? ...`
* Renamed the local var `config` to `options` in `define_callbacks`, as
`options` seems to be the de facto name for the options objects.
* Renamed the local var `l` to `line` in `define_callback` (maybe it
meant `lambda` in the context) as single `l` may look like `1` in some
fonts.
|
|\ \ \
| |/ /
|/| | |
Created way of cloning a Rails::Application instance
|
|/ /
| |
| |
| |
| | |
This change provides the ability to create a new application with a
configuration which can be specified.
|
|\ \
| | |
| | | |
updated AS:Callbacks docs, variable namings
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
_ Rename the define_callbacks params to `names`
- in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743
- `define_callbacks` just register names(events), not define the real callback functions.
- Rename the `reset_callbacks` params
|
| | |
| | |
| | |
| | | |
The change is commited at ba552764344bc0a3c25b8576ec11f127ceaa16da
|
|\ \ \
| | | |
| | | | |
Using preferred find_by syntax in guides
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Adding find_by in guide to methods that trigger after_find
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Store a symbol directly inside DISPATCH_CACHE for additional roflscale
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove evals from AM::Validations::Callbacks
|
| | |/
| |/|
| | |
| | | |
follow the same refactor at a63a964a5d1ed02cf0df1b1a33a96ed2a9fa987b
|
|\ \ \
| | | |
| | | | |
Synchronize PostController#create code from 5.6 to others sections in Getting Started guide.
|
| | |/
| |/|
| | |
| | | |
Fixed `permit` using for comments.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove a duplicated section [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Attachments were previously covered so remove the useless part. Just
move a note about multipart headers set when the mail method is
triggered to the kept section.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
jetthoughts/destroy_link_description_for_getting_started
Added clarification for destroy link_to description in 5.14
|
| | |/ /
| |/| | |
|
|\ \ \ \
| |_|_|/
|/| | | |
Typo in Active Record Migrations Guide
|
| |/ / |
|
|/ / |
|
|\ \
| |/
|/| |
Fix `rails plugin --help`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Right now if you run the `rails plugin --help` command it fails because rails expects a command in `railties/lib/rails/commands/plugin.rb` that does not exist because the file is named `plugin_new`. This is the error:
```
ruby-2.0.0-p0 ~/documents/projects/tmp/vanilla (master)
$ rails plugin --help
/Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `require': cannot load such file -- rails/commands/plugin (LoadError)
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `block in require'
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:213:in `load_dependency'
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `require'
from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/railties-4.0.0/lib/rails/commands.rb:49:in `<top (required)>'
from bin/rails:4:in `require'
from bin/rails:4:in `<main>'
```
|
|\ \
| | |
| | | |
provide a more sementic local variables name in ActiveModel::Validation::Clusivity
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
ActiveModel::Validations::Clusivity#include? method
the original name `exclusion` is a bit confusing when using with the method `inclusion_method`
rename it to a more logic neutral name.
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
JonRowe/fix_tags_picking_string_keys_from_non_stringified_options
Fetch value(s) from stringified options in tags that stringify options
|
| | | |
|
|\ \ \
| | | |
| | | | |
remove deprecated implicit join references
|
| | |/
| |/| |
|
|\ \ \
| |/ /
|/| | |
Update a broken link into the fixtures' template [ci skip]
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
request thread to return up the stack before the instance variable is
assigned. Synchronize so that the ivar is assigned before the other
thread can activate.
fixes #10984
|
|\ \
| | |
| | |
| | |
| | | |
wangjohn/documentation_for_railties_initialization_guide
Adding documentation to the Rails initialization guide.
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
nfedyashev/omit_turbolinks_on_javascript_skip_option
Omit turbolinks configuration completely on skip_javascript generator option
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
ActiveRecord find_in_batches should work without logger
When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway.
|
| | | | |
|