| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
destroyed objects and refactor mime responds tests and documentation.
|
| | |
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Consequences:
* It is not possible to always pre-determine the layout before going to ActionView.
This was *already* broken for render :partial => @object, :layout => true. This is
now handled by overriding render_to_body in layouts.rb and manually injecting the
partial's response. This needs to be done in ActionController since ActionController
knows enough to get _layout_for_option. There is probably a better abstraction here.
* As a result, all partial rendering can correctly restrict their layouts to the mime
type of the rendered partial. This could have previously caused a bug in some edge cases.
* If other layout-like options are added, they might need to add special code for the
case of render :partial. We should try to think of an alternate solution, if possible,
but this works for the cases we know of now.
|
|\| | |
|
| | | |
|
| | |
| | |
| | |
| | | |
* TODO: Review ActionController calling render_template for certain partials.
Might we be able to save logic by always delegating to AV's render_partial?
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
in with render
* _render_single_template, which renders a template without layout
* _render_partial_unknown_type, which renders a partial of unknown type
(the entry method for most partial rendering; supports strings, objects, and collections)
* _render_partial_object, which renders a partial for a single object.
* extracted _render_partial_path so it can be used to render the spacer without going
through the public render :partial
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* rename _render_partial to _render_partial_unknown_type to reflect that for this call,
we don't know the type.
* Merge _render_partial_with_block and _render_partial_with_layout to _render_partial
* TODO: Check to see if any more logic can be shared
* TODO: See about streamlining block path so we can get rid of @_proc_for_layout
* Remove @exempt_from_layout as it is no longer needed
|
| | |
| | |
| | |
| | | |
is optional
|
| | |
| | |
| | |
| | |
| | | |
* remove no longer used _array_like_objects
* _render_content_with_layout renamed to _render_content since layout it optional
* remove check for optional layout before _render_content
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
convention
|
| | | |
|
| | |
| | |
| | |
| | | |
their module locations
|
| | | |
|
| | |
| | |
| | |
| | | |
it does not need to be an ActionView instance
|
| |/
| |
| |
| | |
public
|
| |\ |
|
| | | |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Ruby 1.9.2
[#2959 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
| |
| |
| |
| | |
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Joshua Peek <josh@joshpeek.com>
|
| |
| |
| |
| |
| |
| | |
or ".css" onto external urls [#1664 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
| |
| |
| |
| |
| |
| | |
strings with two-digit years, e.g. '1/1/09', are interpreted as modern years" [#2019 state:wontfix]
This reverts commit 55d1d12c32a1b99f3f07d2346b49a63650ba2e9d.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
will reset an attribute to its original value should it have changed.
Signed-off-by: Joshua Peek <josh@joshpeek.com>
|
| |
| |
| |
| |
| |
| | |
attribute method prefixes and/or suffixes. Previously only suffixes were allowed.
Signed-off-by: Joshua Peek <josh@joshpeek.com>
|
| | |
|
| |
| |
| |
| | |
with two-digit years, e.g. '1/1/09', are interpreted as modern years [#2019 state:resolved]
|
| |
| |
| |
| | |
ActiveRecord::Base.default_timezone before serialization. This allows you to use Time.now in find conditions and have it correctly be serialized as the current time in UTC when default_timezone == :utc [#2946 state:resolved]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* convert_content_type! is handled by assign_default_content_type_and_charset!
* set_content_length! should be handled by the endpoint server. Otherwise
each middleware that modifies the body has to do the expensive work of
recalculating content_length.
* convert_language! appears to be legacy. There are no tests for this
* convert_cookies! should be handled by the new HeaderHash in Rack
* Use an integer for .status's internal representation to avoid needing to
do String manipulation just to find out the status
|
| |
| |
| |
| | |
* Significantly simplifies setting and modifying cache control in other areas
|
| | |
|
| |
| |
| |
| |
| |
| | |
[#2661 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
| | |
|
| | |
|