aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Reverted old select_limited_ids_list postgresql fix that caused issues in ↵Rick Olson2006-10-093-3/+8
| | | | | | mysql. Closes #5851 [Rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Removes the ability for eager loaded conditions to be interpolated, since ↵Rick Olson2006-10-099-29/+28
| | | | | | there is no model instance to use as a context for interpolation. #5553 [turnip@turnipspatch.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed test:uncommitted on Windows (backslash issue) (closes #4999) ↵David Heinemeier Hansson2006-10-092-2/+4
| | | | | | [paul@paulbutcher.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (closes #6234)David Heinemeier Hansson2006-10-091-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed migration creation to work with namespaced models, so script/generate ↵David Heinemeier Hansson2006-10-092-0/+5
| | | | | | model Gallery::Image will use create_table :gallery_images #6327 [BobSilva] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed rename_table on SQLite tables with indexes defined (closes #5942) ↵David Heinemeier Hansson2006-10-092-6/+39
| | | | | | [brandon@opensoul.org] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (closes #6040)David Heinemeier Hansson2006-10-091-0/+24
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added timeout option to SQLite3 configurations to deal more gracefully with ↵David Heinemeier Hansson2006-10-095-1/+11
| | | | | | SQLite3::BusyException, now the connection can instead retry for x seconds to see if the db clears up before throwing that exception (closes #6126) [wreese@gmail.com] Added default timeout setting of 5 seconds to SQLite3 database.yml configurations [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (closes #5143)David Heinemeier Hansson2006-10-091-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added update_attributes! which uses save! to raise an exception if a ↵David Heinemeier Hansson2006-10-093-1/+46
| | | | | | validation error prevents saving (closes #6192) [jonathan] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Deprecated add_on_boundary_breaking (use validates_length_of instead) ↵David Heinemeier Hansson2006-10-094-18/+16
| | | | | | (closes #6292) [BobSilva] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Doc fixes (closes #6325)David Heinemeier Hansson2006-10-091-1/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* render_text may optionally append to the response body. render_javascript ↵Jeremy Kemper2006-10-093-4/+34
| | | | | | appends by default. This allows you to chain multiple render :update calls by setting @performed_render = false between them (awaiting a better public API). git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Rename test assertion to prevent shadowing. Closes #6306.Nicholas Seckar2006-10-092-1/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* one render per testJeremy Kemper2006-10-091-16/+36
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that NumberHelper#number_to_delimiter should respect precision of ↵David Heinemeier Hansson2006-10-093-3/+20
| | | | | | higher than two digits (closes #6231) [phallstrom] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that caches_action breaks with file extensions (closes #6257) [Catfish]David Heinemeier Hansson2006-10-092-1/+8
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that FormHelper#radio_button didn't respect an :id being passed in ↵David Heinemeier Hansson2006-10-093-2/+10
| | | | | | (closes #6266) [evansj] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added an html_options hash parameter to javascript_tag() and ↵David Heinemeier Hansson2006-10-094-4/+26
| | | | | | update_page_tag() helpers #6311 [tzaharia] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Also update escaping for prototype rescues [DHH]David Heinemeier Hansson2006-10-091-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that rescue template path shouldn't be hardcoded, then it's easier to ↵David Heinemeier Hansson2006-10-092-1/+3
| | | | | | hook in your own (closes #6295) [mnaberez] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed escaping of backslashes in JavaScriptHelper#escape_javascript (closes ↵David Heinemeier Hansson2006-10-093-1/+4
| | | | | | #6302) [sven@c3d2.de] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that some 500 rescues would cause 500's themselves because the ↵David Heinemeier Hansson2006-10-092-1/+3
| | | | | | response had not yet been generated #6329 [cmselmer] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that assert_select selects the wrong tag by its contents (closes ↵David Heinemeier Hansson2006-10-092-66/+81
| | | | | | #6332) [jgarber] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Deprecation cleanup for rescues (closes #6339) [adam]David Heinemeier Hansson2006-10-091-4/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (closes #6356)David Heinemeier Hansson2006-10-091-1/+9
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Include field:type option for modelsDavid Heinemeier Hansson2006-10-092-1/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added script/generate resource which works just like scaffold_resource, but ↵David Heinemeier Hansson2006-10-0917-60/+252
| | | | | | creates empty placeholders instead of predefined [DHH] Added generated attribute options to script/generate model, like the one found in scaffold_resource and resource [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5236 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added proper USAGE to the scaffold_resource generator [DHH]David Heinemeier Hansson2006-10-081-4/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added proper USAGE to the scaffold_resource generator [DHH]David Heinemeier Hansson2006-10-081-5/+20
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r5515@ks: jeremy | 2006-10-08 13:24:42 -0700Jeremy Kemper2006-10-083-2/+22
| | | | | | | | | #6281 r5516@ks: jeremy | 2006-10-08 13:29:49 -0700 respond_to :html doesn't assume .rhtml. Closes #6281. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* cleanup of local_assigns handling and documentation update (closes #6358) ↵David Heinemeier Hansson2006-10-081-6/+16
| | | | | | [skaes] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* The has_many create method works with polymorphic associations. Closes #6361.Jeremy Kemper2006-10-083-4/+14
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add Base.delete for deleting resources without having to instantiate them firstJamis Buck2006-10-063-0/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Update RUNNING_UNIT_TESTS for current Rake tasks. Closes #6349.Jeremy Kemper2006-10-051-3/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* callbacks that return false should cause save to return falseJamis Buck2006-10-041-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* add a failing test so we can make it happy againJamis Buck2006-10-041-0/+13
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Pull in latest multibyte patch. Closes #6346 [Manfred Stienstra]Michael Koziarski2006-10-048-27/+36
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5224 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add ActiveSupport::Multibyte. Provides String#chars which lets you deal ↵Michael Koziarski2006-10-0315-0/+1390
| | | | | | with strings as a sequence of chars, not of bytes. Closes #6242 [Julian Tarkhanov, Manfred Stienstra & Jan Behrens] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* add response to list of deprecated instance variablesJeremy Kemper2006-10-021-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make #save behavior mimic AR::Base#save (true on success, false on failure)Jamis Buck2006-10-025-12/+13
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* MySQL: introduce Mysql::Result#all_hashes to support further optimization. ↵Jeremy Kemper2006-10-022-10/+43
| | | | | | Closes #5581. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5219 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix issue with #class_inheritable_accessor saving updates to the parent ↵Rick Olson2006-10-023-1/+38
| | | | | | class when initialized with an Array or Hash [mojombo] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5218 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* use instance vars in rescue templates since controller may not be ↵Jeremy Kemper2006-10-022-5/+5
| | | | | | instantiated yet git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* assume the passed headers to the ActiveResource HttpMock Request/Response ↵Rick Olson2006-10-021-2/+2
| | | | | | are hashes [Rick Olson] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* save! shouldn't validate twice. Closes #6324.Jeremy Kemper2006-10-023-2/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Association collections have an _ids reader method to match the existing ↵Jeremy Kemper2006-10-013-1/+47
| | | | | | writer for collection_select convenience (e.g. employee.task_ids). The writer method skips blank ids so you can safely do @employee.task_ids = params[:tasks] without checking every time for an empty list or blank values. References #1887, Closes #5780. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Removed deprecated @request and @response usages.Kent Sibilev2006-10-013-5/+7
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed some deprecation warnings in ActionPack [Rick Olson]Rick Olson2006-09-303-4/+5
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add an attribute reader method for ActiveRecord::Base.observers [Rick Olson]Rick Olson2006-09-302-0/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de