Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | User id instead of quoted_id to prevent double quoting. Fixes failing test ↵ | Robert Pankowecki (Gavdi) | 2011-01-04 | 1 | -1/+1 |
| | | | | for bug #6036. | ||||
* | Added one more failing test for bug #6036 | Robert Pankowecki (Gavdi) | 2011-01-04 | 1 | -0/+6 |
| | |||||
* | Make sure that generator's default banner is showing its namespace | Prem Sichanugrist | 2011-01-01 | 2 | -1/+11 |
| | | | | This will make `rails g rspec:install --help` shows "rails generate rspec:install [options]" and not "rails generate install [options]" | ||||
* | Merge remote branch 'jonleighton/association_fixes' into fuuu | Aaron Patterson | 2011-01-01 | 26 | -255/+260 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | * jonleighton/association_fixes: Rename AssociationReflection#primary_key_name to foreign_key, since the options key which it relates to is :foreign_key Support for :counter_cache on polymorphic belongs_to Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to inherit from it Specify the STI type condition using SQL IN rather than a whole load of ORs. Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. Verify that when has_many associated objects are destroyed via :dependent => :destroy, when the parent is destroyed, the callbacks are run Get rid of extra_conditions param from configure_dependency_for_has_many. I can't see a particularly plausible argument for this being used by plugins, and if they really want they can just redefine the callback or whatever. Note also that before my recent commit the extra_conditions param was completely ignored for :dependent => :destroy. And owner_quoted_id can go too Now we can drop-kick AssociationReflection#dependent_conditions into oblivion. Refactor configure_dependency_for_has_many to use AssociationCollection#delete_all. It was necessary to change test_before_destroy in lifecycle_test.rb so that it checks topic.replies.size *before* doing the destroy, as afterwards it will now (correctly) be 0. | ||||
| * | Rename AssociationReflection#primary_key_name to foreign_key, since the ↵ | Jon Leighton | 2010-12-31 | 16 | -54/+56 |
| | | | | | | | | options key which it relates to is :foreign_key | ||||
| * | Support for :counter_cache on polymorphic belongs_to | Jon Leighton | 2010-12-31 | 3 | -1/+14 |
| | | |||||
| * | Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵ | Jon Leighton | 2010-12-31 | 6 | -120/+127 |
| | | | | | | | | inherit from it | ||||
| * | Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵ | Jon Leighton | 2010-12-31 | 4 | -6/+21 |
| | | | | | | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. | ||||
| * | Verify that when has_many associated objects are destroyed via :dependent => ↵ | Jon Leighton | 2010-12-31 | 2 | -1/+25 |
| | | | | | | | | :destroy, when the parent is destroyed, the callbacks are run | ||||
| * | Get rid of extra_conditions param from configure_dependency_for_has_many. I ↵ | Jon Leighton | 2010-12-31 | 1 | -9/+3 |
| | | | | | | | | can't see a particularly plausible argument for this being used by plugins, and if they really want they can just redefine the callback or whatever. Note also that before my recent commit the extra_conditions param was completely ignored for :dependent => :destroy. | ||||
| * | And owner_quoted_id can go too | Jon Leighton | 2010-12-31 | 3 | -22/+0 |
| | | |||||
| * | Now we can drop-kick AssociationReflection#dependent_conditions into oblivion. | Jon Leighton | 2010-12-31 | 1 | -11/+0 |
| | | |||||
| * | Refactor configure_dependency_for_has_many to use ↵ | Jon Leighton | 2010-12-31 | 2 | -41/+24 |
| | | | | | | | | AssociationCollection#delete_all. It was necessary to change test_before_destroy in lifecycle_test.rb so that it checks topic.replies.size *before* doing the destroy, as afterwards it will now (correctly) be 0. | ||||
* | | render :template is faster than render :file | Santiago Pastorino | 2011-01-01 | 2 | -5/+4 |
| | | |||||
* | | This is not needed anymore | Santiago Pastorino | 2011-01-01 | 1 | -3/+0 |
|/ | |||||
* | Recreate symlink in layouts for tests | Piotr Sarnacki | 2010-12-31 | 1 | -0/+1 |
| | |||||
* | Do not take gems' i18n locales while testing locales paths | Piotr Sarnacki | 2010-12-31 | 1 | -2/+8 |
| | |||||
* | Don't be so picky on MissingTemplate error details, this fails randomly on ↵ | Piotr Sarnacki | 2010-12-31 | 1 | -4/+3 |
| | | | | 1.8.7 because of not ordered hash | ||||
* | added tests for the MissingTemplate exception message. | Nick Sutterer | 2010-12-31 | 1 | -0/+21 |
| | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2010-12-31 | 1 | -1/+13 |
|\ | |||||
| * | Routing guide: clarify what the :as option does for scopes | Ryan Bigg | 2010-12-31 | 1 | -2/+2 |
| | | |||||
| * | Routing guide: move scope documentation down to where it is referenced more ↵ | Ryan Bigg | 2010-12-31 | 1 | -10/+12 |
| | | | | | | | | plainly | ||||
| * | Routing guide: improve documentation for the scope method, demonstrating use ↵ | Ryan Bigg | 2010-12-31 | 1 | -0/+10 |
| | | | | | | | | of named parameters | ||||
* | | ActionController::Base.helpers.sanitize ignores case in protocol | Timothy N. Tsvetkov | 2010-12-30 | 3 | -2/+8 |
| | | | | | | | | | | | | [#6044 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | Make sure Model#touch doesn't try to update non existing columns | Pratik Naik | 2010-12-30 | 2 | -2/+4 |
| | | |||||
* | | contrib_guide.gsub!("aptitude", "apt-get") | Xavier Noria | 2010-12-30 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | It turns out aptitude has been removed from Ubuntu 10.10 and while you can manually install it, apt-get is the blessed package manager. Google for "aptitude removed from Ubuntu" for more details. Thanks to Rafael Mendonça França for pointing this out. | ||||
* | | process_action accepts multiple args, even with Callbacks. | Nick Sutterer | 2010-12-29 | 2 | -1/+22 |
|/ | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2010-12-29 | 21 | -3460/+316 |
|\ | |||||
| * | Fix typo in ActionPack changelog. | Cheah Chu Yeow | 2010-12-29 | 1 | -1/+1 |
| | | |||||
| * | Remove link to outdated Github tag comparison in ActionPack changelog. | Cheah Chu Yeow | 2010-12-29 | 1 | -2/+0 |
| | | |||||
| * | Routing guide: mention that routes are matched from the top down in a note. | Ryan Bigg | 2010-12-29 | 1 | -0/+3 |
| | | |||||
| * | fixed incorrect spacing from 98368546719cf09b3bc2 | Vijay Dev | 2010-12-29 | 1 | -1/+1 |
| | | |||||
| * | fixed examples & minor typos | Vijay Dev | 2010-12-29 | 1 | -7/+7 |
| | | |||||
| * | Added information about invoking migrations in non-default environments to ↵ | Karel Minarik | 2010-12-28 | 1 | -1/+1 |
| | | | | | | | | | | | | NOTE box in the "Getting Started" guide Reason: When the guide already mentions "default environment", I think it is more then appropriate to tell the whole story. | ||||
| * | Adding information and link to guide on customizing generators into "Getting ↵ | Karel Minarik | 2010-12-28 | 1 | -1/+1 |
| | | | | | | | | Started" guide. | ||||
| * | Fixed incorrect instructions for calling the `rails` command explicitely in ↵ | Karel Minarik | 2010-12-28 | 1 | -1/+1 |
| | | | | | | | | the "Getting Started" guide | ||||
| * | Added TIP box with information about the `--database` switch for the ↵ | Karel Minarik | 2010-12-28 | 1 | -0/+2 |
| | | | | | | | | application generator in the "Getting Started" guide | ||||
| * | Fixed incorrect command for displaying options for new application Generator ↵ | Karel Minarik | 2010-12-28 | 1 | -1/+1 |
| | | | | | | | | in Getting Started guide | ||||
| * | There's a couple -> There are a couple | Ryan Bigg | 2010-12-28 | 1 | -1/+1 |
| | | |||||
| * | Init guide: begin down the rabbit warren that is active_record/railtie | Ryan Bigg | 2010-12-28 | 1 | -0/+77 |
| | | |||||
| * | Init: finish coverage of railties/lib/rails.rb | Ryan Bigg | 2010-12-28 | 1 | -0/+7 |
| | | |||||
| * | init guide: Cover the action_dispatch/railtie require from rails.rb | Ryan Bigg | 2010-12-28 | 1 | -0/+112 |
| | | |||||
| * | Remove old initialization guide text. Too much has changed for all of this ↵ | Ryan Bigg | 2010-12-28 | 1 | -3549/+0 |
| | | | | | | | | to be useful. | ||||
| * | init guide: cover active_support/railtie.rb | Ryan Bigg | 2010-12-28 | 1 | -0/+12 |
| | | |||||
| * | Init guide: Segue between rails/version and active_support/railtie requires | Ryan Bigg | 2010-12-28 | 1 | -0/+2 |
| | | |||||
| * | Cover the inherited method from Rails::Railtie being used when I18n::Railtie ↵ | Ryan Bigg | 2010-12-28 | 1 | -1/+33 |
| | | | | | | | | is loaded. | ||||
| * | Init guide: finish covering the process of the i18n_railtie.rb file. | Ryan Bigg | 2010-12-28 | 1 | -0/+20 |
| | | |||||
| * | init guide: active_support/railtie does not require itself, actually ↵ | Ryan Bigg | 2010-12-28 | 1 | -1/+1 |
| | | | | | | | | requires i18n_railtie | ||||
| * | Init guide: finish covering initializers for i18n_railtie, moving on to ↵ | Ryan Bigg | 2010-12-28 | 1 | -0/+41 |
| | | | | | | | | covering after_initialize | ||||
| * | init guide: active_support/inflector/methods is loaded by ↵ | Ryan Bigg | 2010-12-28 | 1 | -5/+13 |
| | | | | | | | | active_support/autoload first. |