Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove duplicated action pack tests added to fix issue with fields_for, ↵ | Carlos Antonio da Silva | 2011-02-12 | 1 | -42/+0 |
| | | | | | | nested attributes and erb Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add block support to button_tag helper | Tom Stuart | 2011-02-12 | 2 | -4/+18 |
| | | | | | | | | | | | | | | | | | | | As per the HTML 4.01 spec: Buttons created with the BUTTON element function just like buttons created with the INPUT element, but they offer richer rendering possibilities: the BUTTON element may have content. For example, a BUTTON element that contains an image functions like and may resemble an INPUT element whose type is set to "image", but the BUTTON element type allows content. Since rich content is the main purpose of the <button> element, it makes sense for the button_tag helper to accept a block. http://www.w3.org/TR/html401/interact/forms.html#edef-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#the-button-element Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | ||||
* | Make type="submit" the default for button_tag helper | Tom Stuart | 2011-02-12 | 2 | -7/+12 |
| | | | | | | | | | | | | "submit" is the default value of the <button> element's type attribute according to the HTML 4.01 and the HTML5 draft specs, so if button_tag is going to have a default, type="submit" is a more sensible choice than type="button". http://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#attr-button-type Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | ||||
* | Updated the json date regex to recognize xmlschema formatted date times ↵ | Josh Kalderimis | 2011-02-12 | 2 | -1/+5 |
| | | | | | | during json decoding. [#3031 state:resolved] Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | ||||
* | key habtm fixtures off table name | Aaron Patterson | 2011-02-11 | 1 | -5/+5 |
| | |||||
* | Fixture class no longer needs a reference to the database connection | Aaron Patterson | 2011-02-11 | 1 | -16/+4 |
| | |||||
* | convert fixtures to a list of hashes to insert | Aaron Patterson | 2011-02-11 | 1 | -2/+6 |
| | |||||
* | fixture should quack like a hash | Aaron Patterson | 2011-02-11 | 1 | -1/+9 |
| | |||||
* | Fixtures class constantizes this value, so no need to do it twice | Aaron Patterson | 2011-02-11 | 1 | -3/+3 |
| | |||||
* | database quoting should take care of this, no need to gsub | Aaron Patterson | 2011-02-11 | 1 | -1/+1 |
| | |||||
* | calculate model class on construction | Aaron Patterson | 2011-02-11 | 1 | -16/+11 |
| | |||||
* | clear cache for all connections when resetting | Aaron Patterson | 2011-02-11 | 1 | -4/+3 |
| | |||||
* | avoid side effects from method calls, localize ivar assignment | Aaron Patterson | 2011-02-11 | 1 | -3/+4 |
| | |||||
* | create fixtures always returns a list, so build a hash from the list | Aaron Patterson | 2011-02-11 | 1 | -10/+2 |
| | |||||
* | create_fixtures() should always return a list | Aaron Patterson | 2011-02-11 | 2 | -9/+9 |
| | |||||
* | fixing variable names | Aaron Patterson | 2011-02-11 | 1 | -4/+10 |
| | |||||
* | use hash defaults to dry up ||= calls | Aaron Patterson | 2011-02-11 | 1 | -27/+22 |
| | |||||
* | refactor fixtures to do less work in the constructor | Aaron Patterson | 2011-02-11 | 2 | -11/+24 |
| | |||||
* | favor composition over inheritence. use AS::OrderedHash rather than omap | Aaron Patterson | 2011-02-11 | 2 | -20/+25 |
| | |||||
* | Fixes an issue when decoding a json string which looks like a date but is ↵ | Josh Kalderimis | 2011-02-11 | 4 | -3/+23 |
| | | | | | | invalid. This DateTime parse error is now caught and the original string is instead passed back [#6286 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add missing deprecation require | Carlos Antonio da Silva | 2011-02-11 | 1 | -0/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove misleading reference to polymorphic_url. | José Valim | 2011-02-11 | 1 | -2/+0 |
| | |||||
* | fixing tests on 1.8, using a list of lists because order is important | Aaron Patterson | 2011-02-10 | 2 | -2/+4 |
| | |||||
* | simplify bind parameter logging | Aaron Patterson | 2011-02-10 | 2 | -4/+2 |
| | |||||
* | bind parameters are logged to debug log | Aaron Patterson | 2011-02-10 | 2 | -6/+48 |
| | |||||
* | test cases for bind parameter logging | Aaron Patterson | 2011-02-10 | 1 | -0/+56 |
| | |||||
* | Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵ | Josh Kalderimis | 2011-02-10 | 7 | -116/+70 |
| | | | | | | the same same. This also changes how safe_join works, if items or the separator are not html_safe they are html_escape'd, a html_safe string is always returned. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Removed Array#safe_join in AS core_ext and moved it to a view helper ↵ | José Valim | 2011-02-10 | 7 | -97/+116 |
| | | | | | | | | with the same same." Applied the wrong version. This reverts commit 98c0c5db50a7679b3d58769ac22cb0a27a62c930. | ||||
* | Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵ | Josh Kalderimis | 2011-02-10 | 7 | -116/+97 |
| | | | | the same same. | ||||
* | Corrected the html_safe implementation for Array. Moved the html safe ↵ | Josh Kalderimis | 2011-02-10 | 2 | -20/+35 |
| | | | | version of join to its own method (safe_join) as not to degrade the performance of join for unrelated html_safe use. [#6298 state:resolved] | ||||
* | Initial html_safe implemention for Array | Paul Hieromnimon | 2011-02-10 | 2 | -0/+60 |
| | |||||
* | log method takes an option list of bind values | Aaron Patterson | 2011-02-09 | 4 | -8/+10 |
| | |||||
* | fanout unsubscribe only accepted one argument, so taking *args here is ↵ | Aaron Patterson | 2011-02-09 | 1 | -2/+2 |
| | | | | probably bad | ||||
* | just use an attr_accessor so we do not pay ||= on every notification call | Aaron Patterson | 2011-02-09 | 2 | -7/+10 |
| | |||||
* | fixing indentation | Aaron Patterson | 2011-02-09 | 1 | -4/+4 |
| | |||||
* | speed up notification publishing by writing the delegate method | Aaron Patterson | 2011-02-09 | 1 | -1/+4 |
| | |||||
* | rawr, mysql, mysql2, why do you hate me. :'( | Aaron Patterson | 2011-02-09 | 1 | -2/+4 |
| | |||||
* | Fixed a bug where ActiveResource::HttpMock would not replace an existing ↵ | Josh Bassett | 2011-02-09 | 2 | -5/+39 |
| | | | | | | response when passing a block to the respond_to method. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Override attributes_protected_by_default when has_secure_password is called. | Tsutomu Kuroda | 2011-02-09 | 4 | -2/+38 |
| | | | | | | | attr_protected should not be called, because it nullifies the mass assignment protection that has been set by attr_accessible. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | removed some duplication from LH issue 5505 regarding AR touch and ↵ | Josh Kalderimis | 2011-02-09 | 2 | -9/+11 |
| | | | | | | optimistic locking [#5505 state:resolved] Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com> | ||||
* | The optimistic lock column should be increased when calling touch | Franck Verrot | 2011-02-09 | 3 | -0/+16 |
| | | | | Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com> | ||||
* | use parenthesis so limit works on all dbs | Aaron Patterson | 2011-02-09 | 1 | -6/+4 |
| | |||||
* | now that the API guidelines are a guide, it is enough to assert that the ↵ | Xavier Noria | 2011-02-09 | 1 | -1/+1 |
| | | | | names of Rails components have a space, no need to say it was checked with David in the past | ||||
* | removing text-format in favor of a more simple solution | Aaron Patterson | 2011-02-09 | 3 | -13/+19 |
| | |||||
* | bugfix for serialized_attributes to be class specific | Raimonds Simanovskis | 2011-02-09 | 2 | -1/+8 |
| | | | | previously serialized_attributes were kept as class attribute of ActiveRecord::Base - if some attribute was defined as serialized in one subclass then it was serialized in all other subclasses as well (if it had the same name) | ||||
* | implementing include? on AM::Errors | Aaron Patterson | 2011-02-09 | 2 | -0/+11 |
| | |||||
* | text-format requires text-hyphen, which needs ruby 1.8 | Piotr Sarnacki | 2011-02-09 | 1 | -3/+1 |
| | |||||
* | we do not need message to be an array | Aaron Patterson | 2011-02-09 | 1 | -9/+8 |
| | |||||
* | Allow limit values to accept an ARel SQL literal. | Ken Collins | 2011-02-09 | 2 | -5/+15 |
| | |||||
* | use map rather than array concatenation | Aaron Patterson | 2011-02-09 | 1 | -9/+4 |
| |