Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix expected queries in relation tests. | Emilio Tagua | 2011-02-15 | 1 | -2/+2 |
| | |||||
* | Don't shadow outer local variable. | Emilio Tagua | 2011-02-15 | 1 | -2/+2 |
| | |||||
* | Run tests without IdentityMap when IM=false is given. | Emilio Tagua | 2011-02-15 | 6 | -15/+23 |
| | |||||
* | Remove identity map from benchmark script. | Emilio Tagua | 2011-02-15 | 1 | -7/+0 |
| | |||||
* | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2011-02-15 | 430 | -9198/+12029 |
|\ | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb | ||||
| * | bad tests are bad | Aaron Patterson | 2011-02-14 | 1 | -18/+0 |
| | | |||||
| * | remove accidental raise! | Aaron Patterson | 2011-02-14 | 1 | -1/+0 |
| | | |||||
| * | removing irrelevant test | Aaron Patterson | 2011-02-14 | 2 | -18/+1 |
| | | |||||
| * | Merge branch 'fixtures' | Aaron Patterson | 2011-02-14 | 1 | -28/+28 |
| |\ | | | | | | | | | | | | | | | | | | | | | | * fixtures: remove unused methods extract database activity out of Fixtures instances extract rows that should be inserted to a method fixtures will return a list of tables that may be effected, delete existing fixtures will delete those tables | ||||
| | * | remove unused methods | Aaron Patterson | 2011-02-14 | 2 | -40/+0 |
| | | | |||||
| | * | extract database activity out of Fixtures instances | Aaron Patterson | 2011-02-14 | 1 | -7/+23 |
| | | | |||||
| | * | extract rows that should be inserted to a method | Aaron Patterson | 2011-02-14 | 1 | -12/+12 |
| | | | |||||
| | * | fixtures will return a list of tables that may be effected, delete existing ↵ | Aaron Patterson | 2011-02-14 | 2 | -6/+30 |
| | | | | | | | | | | | | fixtures will delete those tables | ||||
| * | | Merge remote branch 'jonleighton/association_fixes' | Aaron Patterson | 2011-02-14 | 23 | -117/+171 |
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * jonleighton/association_fixes: Add a transaction wrapper in add_to_target. This means that #build will now also use a transaction. IMO this is reasonable given that the before_add and after_add callbacks might do anything, and this great consistency allows us to abstract out the duplicate code from #build and #create. Inline ensure_owner_is_persisted! as it is only called from one place @target should always be an array Rename add_record_to_target_with_callbacks to add_to_target Don't pass the block through build_record Move create and create! next to build Get rid of create_record as it is not only used in one place Get rid of AssociationCollection#save_record Fix test/cases/connection_pool_test.rb for sqlite3 in-memory db Add interpolation of association conditions back in, in the form of proc { ... } rather than instance_eval-ing strings | ||||
| | * | Add a transaction wrapper in add_to_target. This means that #build will now ↵ | Jon Leighton | 2011-02-14 | 1 | -27/+27 |
| | | | | | | | | | | | | also use a transaction. IMO this is reasonable given that the before_add and after_add callbacks might do anything, and this great consistency allows us to abstract out the duplicate code from #build and #create. | ||||
| | * | Inline ensure_owner_is_persisted! as it is only called from one place | Jon Leighton | 2011-02-14 | 1 | -8/+4 |
| | | | |||||
| | * | @target should always be an array | Jon Leighton | 2011-02-14 | 1 | -1/+2 |
| | | | |||||
| | * | Rename add_record_to_target_with_callbacks to add_to_target | Jon Leighton | 2011-02-14 | 2 | -5/+5 |
| | | | |||||
| | * | Don't pass the block through build_record | Jon Leighton | 2011-02-14 | 1 | -10/+8 |
| | | | |||||
| | * | Move create and create! next to build | Jon Leighton | 2011-02-14 | 1 | -21/+21 |
| | | | |||||
| | * | Get rid of create_record as it is not only used in one place | Jon Leighton | 2011-02-14 | 1 | -8/+7 |
| | | | |||||
| | * | Get rid of AssociationCollection#save_record | Jon Leighton | 2011-02-14 | 5 | -26/+26 |
| | | | |||||
| | * | Fix test/cases/connection_pool_test.rb for sqlite3 in-memory db | Jon Leighton | 2011-02-14 | 1 | -0/+10 |
| | | | |||||
| | * | Add interpolation of association conditions back in, in the form of proc { ↵ | Jon Leighton | 2011-02-14 | 18 | -47/+97 |
| | | | | | | | | | | | | ... } rather than instance_eval-ing strings | ||||
| * | | HabtmFixtures class is no longer needed | Aaron Patterson | 2011-02-14 | 1 | -31/+22 |
| | | | |||||
| * | | Add test to prevent regression on namespace root nested in a resource | Andrew White | 2011-02-14 | 1 | -0/+9 |
| | | | | | | | | | | | | [#6389 state:resolved] | ||||
| * | | Fix named route helper for routes nested inside deeply nested resources | Andrew White | 2011-02-14 | 2 | -2/+10 |
| |/ | | | | | | | [#6416 state:resolved] | ||||
| * | Add notes on how to override the default :id constraint [#5994 state:resolved] | Andrew White | 2011-02-14 | 2 | -1/+12 |
| | | |||||
| * | Remove incorrect assert_recognizes example | Andrew White | 2011-02-14 | 1 | -6/+0 |
| | | |||||
| * | Remove incorrect assert_recognizes example | Andrew White | 2011-02-13 | 1 | -3/+0 |
| | | |||||
| * | Fix assert_recognizes with block constraints [#5805 state:resolved] | Andrew White | 2011-02-13 | 4 | -6/+116 |
| | | |||||
| * | Add missing require | Santiago Pastorino | 2011-02-13 | 1 | -0/+1 |
| | | |||||
| * | Add Date#rfc3339 and Date#iso8601 to AS | Santiago Pastorino | 2011-02-13 | 3 | -0/+17 |
| | | |||||
| * | Remove Relation#& alias for Relation#merge | Ernie Miller | 2011-02-12 | 6 | -14/+12 |
| | | |||||
| * | switch over to Mysql2::Client#ping for the mysql2 connection check | Brian Lopez | 2011-02-12 | 1 | -4/+1 |
| | | |||||
| * | Make gem "ruby-debug19" require ruby-debug | Santiago Pastorino | 2011-02-12 | 1 | -1/+1 |
| | | |||||
| * | added proper require for ruby-debug19 gem to generated Gemfile | Wojciech Wnętrzak | 2011-02-12 | 1 | -1/+1 |
| | | | | | | | | | | | | [#6419 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Allow for the format of time_tag in AP to be changed via an option argument. | Josh Kalderimis | 2011-02-12 | 2 | -8/+16 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Added time_tag helper to AP for HTML5 time tag [#5919 state:resolved] | Sjoerd Andringa | 2011-02-12 | 3 | -2/+41 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Fix table name collision due to incorrect alias count on certain joins. | Ernie Miller | 2011-02-12 | 2 | -4/+11 |
| | | | | | | | | | | | | [#6423 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Applied changes to stylesheet_link_tag from javascript_include_tag which ↵ | Josh Kalderimis | 2011-02-13 | 3 | -14/+38 |
| | | | | | | | | corrects issues with ordering and duplicates. | ||||
| * | This corrects two issues with javascript_include_tag, the order at which ↵ | Josh Kalderimis | 2011-02-13 | 2 | -5/+47 |
| | | | | | | | | | | | | | | | | they are expanded, and removing duplicates. When individual js assets are specified, they will override the order of the same asset specified in an expansion. [#5938 state:resolved] | ||||
| * | Remove duplicated action pack tests added to fix issue with fields_for, ↵ | Carlos Antonio da Silva | 2011-02-12 | 1 | -42/+0 |
| | | | | | | | | | | | | nested attributes and erb Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Add block support to button_tag helper | Tom Stuart | 2011-02-12 | 2 | -4/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per the HTML 4.01 spec: Buttons created with the BUTTON element function just like buttons created with the INPUT element, but they offer richer rendering possibilities: the BUTTON element may have content. For example, a BUTTON element that contains an image functions like and may resemble an INPUT element whose type is set to "image", but the BUTTON element type allows content. Since rich content is the main purpose of the <button> element, it makes sense for the button_tag helper to accept a block. http://www.w3.org/TR/html401/interact/forms.html#edef-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#the-button-element Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | ||||
| * | Make type="submit" the default for button_tag helper | Tom Stuart | 2011-02-12 | 2 | -7/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | "submit" is the default value of the <button> element's type attribute according to the HTML 4.01 and the HTML5 draft specs, so if button_tag is going to have a default, type="submit" is a more sensible choice than type="button". http://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#attr-button-type Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | ||||
| * | Updated the json date regex to recognize xmlschema formatted date times ↵ | Josh Kalderimis | 2011-02-12 | 2 | -1/+5 |
| | | | | | | | | | | | | during json decoding. [#3031 state:resolved] Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com> | ||||
| * | key habtm fixtures off table name | Aaron Patterson | 2011-02-11 | 1 | -5/+5 |
| | | |||||
| * | Fixture class no longer needs a reference to the database connection | Aaron Patterson | 2011-02-11 | 1 | -16/+4 |
| | | |||||
| * | convert fixtures to a list of hashes to insert | Aaron Patterson | 2011-02-11 | 1 | -2/+6 |
| | | |||||
| * | fixture should quack like a hash | Aaron Patterson | 2011-02-11 | 1 | -1/+9 |
| | |