aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Do not use update_column where update_attribute is not interchangeableRafael Mendonça França2012-08-158-39/+32
| | | | | | | | | | | | Revert "Deprecate update_attribute." This reverts commit b081f6b59fb3f15d12043072ad9b331ffd2bc56e. Reason: Since the new deprecation policy we removed the deprecation of update_attribute but we didn't reverted the changes to use update_column. Fixes #7306
* Merge pull request #6073 from daveyeu/restore-state-on-record-invalidRafael Mendonça França2012-08-113-1/+23
| | | | | | Restore state on create when ActiveRecord::RecordInvalid is raised Conflicts: activerecord/CHANGELOG.md
* Merge pull request #7316 from brainopia/backport_fix_session_store_optionsRafael Mendonça França2012-08-115-5/+38
|\ | | | | Backport of "Support cookie jar options for all cookie stores" for 3.2-stable
| * Update changelog to reflect support of cookie jar options for allbrainopia2012-08-111-0/+5
| | | | | | | | session stores
| * Test actual content of permanent cookiebrainopia2012-08-101-1/+1
| |
| * Dont stream back cookie value if it was set to the same valuebrainopia2012-08-102-5/+19
| |
| * Revert "Revert "Merge pull request #6084 from ↵brainopia2012-08-102-0/+14
| | | | | | | | | | | | brainopia/support_for_magic_domain_on_all_stores"" This reverts commit a48ea6800ef712440b08c551f8041feb35de8cb4.
* | [guides] Add info about CHANGELOGs to contributing guidePiotr Sarnacki2012-08-111-0/+25
| |
* | Add CHANGELOG entry for #7286Rafael Mendonça França2012-08-101-0/+5
| |
* | Merge pull request #7286 from kennyj/fix_7191Rafael Mendonça França2012-08-102-13/+28
|/ | | | | | Fix #7191. Remove unnecessary transaction when assigning has_one associations. Conflicts: activerecord/test/cases/associations/has_one_associations_test.rb
* Merge pull request #7309 from amerine/3-2-stableSantiago Pastorino2012-08-091-0/+2
|\ | | | | Add html_escape note to CHANGELOG
| * Add html_escape note to CHANGELOGMark Turner2012-08-091-0/+2
|/
* Merge branch '3-2-8' into 3-2-stableSantiago Pastorino2012-08-0920-21/+49
|\
| * Bump to 3.2.8Santiago Pastorino2012-08-099-9/+9
| |
| * Add release date to CHANGELOGsSantiago Pastorino2012-08-097-7/+7
| |
| * Do not mark strip_tags result as html_safeSantiago Pastorino2012-08-093-3/+10
| | | | | | | | | | | | Thanks to Marek Labos & Nethemba CVE-2012-3465
| * escape select_tag :prompt valuesSantiago Pastorino2012-08-093-2/+15
| | | | | | | | CVE-2012-3463
| * Bump to 3.2.8.rc2Santiago Pastorino2012-08-039-9/+9
| |
| * Add CHANGELOG entrySantiago Pastorino2012-08-031-0/+2
| |
| * More `:rails_env` cleanup.Rafael Mendonça França2012-08-021-6/+6
| | | | | | | | `Rails.env` already use development if ENV["RAILS_ENV"] is not present.
| * Fix html_escape with Ruby 1.8Rafael Mendonça França2012-08-021-15/+26
| |
| * html_escape should escape single quotesSantiago Pastorino2012-08-0212-63/+51
| | | | | | | | | | | | | | | | | | | | | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215 Conflicts: actionpack/test/template/erb_util_test.rb actionpack/test/template/form_tag_helper_test.rb actionpack/test/template/text_helper_test.rb actionpack/test/template/url_helper_test.rb activesupport/lib/active_support/core_ext/string/output_safety.rb
| * Use `:data => { :confirm => "Text" }` syntax instead of `:confirm` atRafael Mendonça França2012-08-022-4/+9
| | | | | | | | | | | | | | the ERB scaffold generator. We are trying to teach the data attributes as best practices and `:confirm` will be deprecated in 4.0.
| * Do not consider the numeric attribute as changed if the old value isRafael Mendonça França2012-08-023-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | zero and the new value is not a string. Before this commit this was the behavior r = Review.find_by_issue(0) r.issue => 0 r.changes => {} r.issue = 0 => 0 r.changed? => true r.changes => {"issue"=>[0,0]} Fixes #7237
| * Fix ActiveSupport integration with Mocha > 0.12.1Mike Gunderloy2012-08-021-1/+3
| | | | | | | | | | | | Mocha 0.12.2 renames the Integration module to MonkeyPatching. This breaks the code Rails uses to retrieve the assertion counter from Mocha.
* | Merge pull request #7299 from iHiD/3-2-stable-storeRafael Mendonça França2012-08-095-2/+22
|\ \ | | | | | | | | | Ported PR #4856 to 3-2-stable.
| * | Add CHANGELOG entryRafael Mendonça França2012-08-091-0/+5
| | |
| * | Backport #7173.Jeremy Walker2012-08-091-2/+4
| | |
| * | Ported PR #4856 to 3-2-stable.Jeremy Walker2012-08-094-2/+15
|/ /
* | Fix CHANGELOG [ci skip]Rafael Mendonça França2012-08-081-1/+4
| |
* | Remove references to old behavior with headers atRafael Mendonça França2012-08-071-4/+3
| | | | | | | | | | | | | | | | | | | | | | ActionDispatch::Integration::ResquestHelpers. The behavior has removed at 4a6f4b92ad2f48dc7906d223fe4708d36624bd50 to increase the compatibility with Rack::Test Closes #7136 [ci skip]
* | Merge pull request #7284 from josh/fix-asset-testsRafael Mendonça França2012-08-071-3/+2
|\ \ | | | | | | Fix asset integration test (3-2-stable)
| * | Fix invalid asset compile assertionsJoshua Peek2012-08-071-3/+2
|/ / | | | | | | Logical paths to compile should require an extension
* | make assertions easier to track downAaron Patterson2012-08-071-9/+17
| |
* | Merge pull request #7283 from josh/bump-sprocketsDavid Heinemeier Hansson2012-08-071-1/+1
|\ \ | | | | | | Allow newer versions of Sprockets
| * | Loosen sprockets version restrictionJoshua Peek2012-08-071-1/+1
|/ /
* | Add CHANGELOG entry for a935c7aRafael Mendonça França2012-08-061-0/+5
| |
* | Merge pull request #5872 from evtuhovich/prepared_statement_fixAaron Patterson2012-08-061-10/+10
| | | | | | | | | | | | Remove prepared statement from system query in postgresql adapter Conflicts: activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
* | Merge pull request #7167 from route/missed_extendJosé Valim2012-08-061-0/+1
| | | | | | | | | | | | | | Missed extend for eager_autoload This backport is trying to fix a bug with eager load ActiveRecord::Associations modules
* | Merge pull request #7276 from sikachu/3-2-stable-js-include-tag-fixRafael Mendonça França2012-08-063-7/+19
|\ \ | | | | | | Do not include application.js if it doesn't exists
| * | Rearrange example output of javascript_include_tagPrem Sichanugrist2012-08-061-2/+2
| | |
| * | Do not include application.js if it doesn't existsPrem Sichanugrist2012-08-063-5/+17
|/ / | | | | | | | | | | Rails were including 'application.js' to the pack when using `javascript_include_tag :all` even there's no application.js in the public directory.
* | Merge pull request #7140 from seamusabshere/patch-1Rafael Mendonça França2012-08-052-2/+10
| | | | | | | | | | | | | | | | Make sure :environment task is executed before db:schema:load or db:structure:load Conflicts: activerecord/CHANGELOG.md
* | Revert "Merge pull request #6084 from ↵Rafael Mendonça França2012-08-052-14/+0
| | | | | | | | | | | | | | | | brainopia/support_for_magic_domain_on_all_stores" This reverts commit 393c652cf63875f2728c04d47b34b2d6ae908186. This commit was supposed to fix a bug but it add more failures.
* | Merge pull request #6084 from brainopia/support_for_magic_domain_on_all_storesJosé Valim2012-08-022-0/+14
| | | | | | | | Support cookie jar options for all cookie stores
* | More `:rails_env` cleanup.Rafael Mendonça França2012-08-021-6/+6
| | | | | | | | `Rails.env` already use development if ENV["RAILS_ENV"] is not present.
* | Fix html_escape with Ruby 1.8Rafael Mendonça França2012-08-021-15/+26
| |
* | html_escape should escape single quotesSantiago Pastorino2012-08-0212-63/+51
| | | | | | | | | | | | | | | | | | | | | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215 Conflicts: actionpack/test/template/erb_util_test.rb actionpack/test/template/form_tag_helper_test.rb actionpack/test/template/text_helper_test.rb actionpack/test/template/url_helper_test.rb activesupport/lib/active_support/core_ext/string/output_safety.rb
* | Use `:data => { :confirm => "Text" }` syntax instead of `:confirm` atRafael Mendonça França2012-08-022-4/+9
| | | | | | | | | | | | | | the ERB scaffold generator. We are trying to teach the data attributes as best practices and `:confirm` will be deprecated in 4.0.
* | Do not consider the numeric attribute as changed if the old value isRafael Mendonça França2012-08-023-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | zero and the new value is not a string. Before this commit this was the behavior r = Review.find_by_issue(0) r.issue => 0 r.changes => {} r.issue = 0 => 0 r.changed? => true r.changes => {"issue"=>[0,0]} Fixes #7237