Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove code duplication. | José Valim | 2011-04-11 | 3 | -20/+27 |
| | |||||
* | No need to rescue here. Invoking the wrong method in an object can happen ↵ | José Valim | 2011-04-11 | 6 | -40/+0 |
| | | | | anywhere if you are not careful. In other words, test your shit. | ||||
* | Revert "Add :use_include option to allow user to explicitly use ↵ | José Valim | 2011-04-11 | 4 | -37/+14 |
| | | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67. | ||||
* | Keep the same API semantics for update/delete as we had for XML (just return ↵ | David Heinemeier Hansson | 2011-04-11 | 1 | -2/+2 |
| | | | | 200 OK, no body) | ||||
* | Cant use inclusion in commands/application.rb as the frameworks havent all ↵ | David Heinemeier Hansson | 2011-04-11 | 2 | -2/+2 |
| | | | | been required yet | ||||
* | pg should define insert_sql so that query cache actually works for inserts | Aaron Patterson | 2011-04-10 | 1 | -2/+1 |
| | |||||
* | Fix failing test case on master | Prem Sichanugrist | 2011-04-10 | 2 | -2/+2 |
| | | | | It turned out that I overlook at some replacements .. | ||||
* | adding pg support notes to the changelog | Aaron Patterson | 2011-04-10 | 1 | -0/+2 |
| | |||||
* | community support for pg < 8.2 has ended, so we can drop support for those ↵ | Aaron Patterson | 2011-04-10 | 1 | -62/+12 |
| | | | | versions | ||||
* | Refactored uniqueness validator to use Arel instead of hardcoded SQL | Brian Cardarella | 2011-04-10 | 1 | -26/+11 |
| | |||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 44 | -52/+108 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Add support for Object#in? and Object#either? in Active Support [#6321 ↵ | Prem Sichanugrist, Brian Morearty, John Reitano | 2011-04-11 | 3 | -0/+74 |
| | | | | | | | | | | | | state:committed] This will allow you to check if an object is included in another object or the list of objects or not. This patch is derived from patch by Brian Morearty and John Reitano on Lighthouse ticket. I've rewrite it and make sure that we support both 'another object' and 'list of objects' version, as it surely be useful to support both. | ||||
* | Remove dead branch code that appeared back in a merge. | José Valim | 2011-04-10 | 1 | -6/+0 |
| | |||||
* | Add :use_include option to allow user to explicitly use `Range#include?` ↵ | Prem Sichanugrist | 2011-04-10 | 4 | -14/+37 |
| | | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option. | ||||
* | Add support for proc or lambda as an option for InclusionValidator, ↵ | Prem Sichanugrist | 2011-04-10 | 7 | -20/+167 |
| | | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator | ||||
* | Add --old-style-hash option to force creating old style hash on Ruby 1.9 | Prem Sichanugrist | 2011-04-10 | 5 | -2/+25 |
| | | | | That means if you don't like the new syntax, you can pass --old-style-hash to force Rails to generate code with hash rockets. | ||||
* | Rails will now generate Ruby 1.9 style hash when running app generator on ↵ | Prem Sichanugrist | 2011-04-10 | 5 | -4/+23 |
| | | | | | | Ruby 1.9.x The new hash syntax of Ruby 1.9 looks more superior, so we decide to switch to it in the places that appropriate. | ||||
* | Rails will now generate Ruby 1.9 style hash when running scaffold_controller ↵ | Prem Sichanugrist | 2011-04-10 | 6 | -19/+50 |
| | | | | | | | | generator on Ruby 1.9.x The new hash syntax of Ruby 1.9 looks more superior, so we decide to switch to it in the places that appropriate. This patch has been requested by DHH. | ||||
* | Make scaffold_controller generator generate code for JSON response instead ↵ | Prem Sichanugrist | 2011-04-10 | 2 | -14/+16 |
| | | | | | | | | of XML It seems like a lot of people are using JSON in their API more than XML nowadays, so Rails should follow that convention by providing the JSON format block in scaffold_controller by default. This patch has been requested by DHH | ||||
* | moving sqlite_adapter_tests to sqlite3_adapter_test so that the tests are ↵ | Aaron Patterson | 2011-04-08 | 2 | -229/+215 |
| | | | | actually run. :bomb: | ||||
* | make turn a soft dependency. generate a Gemfile that contains turn and ↵ | Aaron Patterson | 2011-04-08 | 3 | -7/+14 |
| | | | | require turn if it is available | ||||
* | Make csrf_meta_tags use the tag helper | James Robinson | 2011-04-08 | 2 | -9/+9 |
| | | | | Improved formatting of csrf_helper and improved test coverage | ||||
* | Merge branch 'master' of github.com:rails/rails | Aaron Patterson | 2011-04-07 | 2 | -4/+4 |
|\ | | | | | | | | | | | | | | | | | | | * 'master' of github.com:rails/rails: Cache flash now Revert "Use freeze instead of close!" Revert "Eagerly load Signed and Permanent cookies" cookies here Eagerly load Signed and Permanent cookies Use freeze instead of close! | ||||
| * | Cache flash now | Santiago Pastorino | 2011-04-07 | 1 | -1/+1 |
| | | |||||
| * | Revert "Use freeze instead of close!" | Santiago Pastorino | 2011-04-07 | 3 | -11/+14 |
| | | | | | | | | This reverts commit 29592a7f09dda2e7e1e0a915d9230fe6a9b5c0af. | ||||
| * | Revert "Eagerly load Signed and Permanent cookies" | Santiago Pastorino | 2011-04-07 | 1 | -17/+10 |
| | | | | | | | | This reverts commit dffeda377021ba8691381195f5a2889f8e040b93. | ||||
| * | cookies here | Santiago Pastorino | 2011-04-07 | 1 | -3/+3 |
| | | |||||
| * | Eagerly load Signed and Permanent cookies | Santiago Pastorino | 2011-04-07 | 1 | -10/+17 |
| | | |||||
| * | Use freeze instead of close! | Santiago Pastorino | 2011-04-06 | 3 | -14/+11 |
| | | |||||
* | | many args does not make sense with the current implementation because of how ↵ | Aaron Patterson | 2011-04-06 | 1 | -10/+0 |
| | | | | | | | | `use` works | ||||
* | | getting the flash hash under test | Aaron Patterson | 2011-04-06 | 2 | -0/+104 |
| | | |||||
* | | favor composition over inheritance, have FlashHash delegate to a Hash | Aaron Patterson | 2011-04-06 | 2 | -11/+44 |
|/ | |||||
* | CookieJar should prefer composition over inheritance | Aaron Patterson | 2011-04-06 | 1 | -6/+10 |
| | |||||
* | Delete useless arguments | Santiago Pastorino | 2011-04-06 | 1 | -6/+6 |
| | |||||
* | Delete useless env variable | Santiago Pastorino | 2011-04-06 | 1 | -9/+3 |
| | |||||
* | Add tests to verify that signed and permanent cookies raises if someone tries | Santiago Pastorino | 2011-04-06 | 1 | -0/+51 |
| | | | | | to modify the cookies when it was already streamed back to the client or converted to HTTP headers | ||||
* | Make process reuse the env var passed as argument | Santiago Pastorino | 2011-04-06 | 2 | -5/+12 |
| | |||||
* | raise if someone tries to modify the cookies when it was already streamed ↵ | Santiago Pastorino | 2011-04-06 | 2 | -0/+63 |
| | | | | back to the client or converted to HTTP headers | ||||
* | Add ClosedError message to the initializer | Santiago Pastorino | 2011-04-06 | 3 | -5/+10 |
| | |||||
* | do not return html safe strings from auto_link | Aaron Patterson | 2011-04-05 | 2 | -7/+13 |
| | |||||
* | added find_zone and find_zone! to AS timezones and changed the AS Railtie to ↵ | Josh Kalderimis | 2011-04-05 | 6 | -18/+61 |
| | | | | | | use find_zone! as well as adding Railtie tests Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Raise on invalid timezone | Marc-Andre Lafortune | 2011-04-05 | 3 | -14/+39 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Disable IdentityMap in log tests, it's not important and when running tests ↵ | Emilio Tagua | 2011-04-05 | 1 | -0/+3 |
| | | | | | | rake task it logs more messages in the tested buffer. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | AM register_interceptor and register_observer only constantize if the ↵ | Josh Kalderimis | 2011-04-06 | 1 | -2/+2 |
| | | | | argument is a String | ||||
* | Rename test directory to match code directory | John Firebaugh | 2011-04-06 | 2 | -0/+0 |
| | | | | Hopefully "serializeration" is not an in joke that I missed. | ||||
* | raise if someone tries to modify the flash when it was already streamed back ↵ | Santiago Pastorino | 2011-04-05 | 2 | -1/+69 |
| | | | | to the client or converted to HTTP headers | ||||
* | Destroying records via nested attributes works independent of reject_if: | Durran Jordan | 2011-04-05 | 2 | -0/+9 |
| | | | | | | | | | | - When a :_destroy truthiness is provided in the attributes hash, the record should get destroyed regardless of the result of the proc or method supplied to :reject_if. (If :allow_destroy is true) [#6006 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | remove AM delegating register_observer and register_interceptor to Mail and ↵ | Josh Kalderimis | 2011-04-04 | 4 | -5/+138 |
| | | | | | | instead implement smarter versions allowing for string class names, also added proper Railtie support with tests. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add log message when loading records from Identity Map. | Emilio Tagua | 2011-04-04 | 2 | -1/+17 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use IM when trying to load records using ID. | Emilio Tagua | 2011-04-04 | 6 | -9/+29 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |