aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* add respond_to? to ActionDispatch::Integration::RunnerSven Fuchs2010-11-221-0/+4
| | | | since Runner uses method_missing to delegate to the integration session it also should define respond_to? accordingly
* Removed ids_in_list_limit in favor of in_clause_length defined in ↵Alex Rothenberg2010-11-233-14/+9
| | | | database_limits.rb
* make test more resilient to future changes by notNeeraj Singh2010-11-221-2/+0
| | | | | | | | | | testing the count and not testing the internal value of the registered mime type. Ideally all mime type registration should be cleaned up in teardown. Signed-off-by: José Valim <jose.valim@gmail.com>
* remove select, collect and then inject withNeeraj Singh2010-11-221-1/+1
| | | | | | something better Signed-off-by: José Valim <jose.valim@gmail.com>
* string include method is 10x faster than creatingNeeraj Singh2010-11-221-1/+1
| | | | | | a new regex object every single time Signed-off-by: José Valim <jose.valim@gmail.com>
* Compile regex only onceNeeraj Singh2010-11-221-3/+5
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* move the mime registration code to setup so thatNeeraj Singh2010-11-221-2/+19
| | | | | | | | | | | | | | | it could be cleaned up on teardown. Currently the test code test/controller/mime_responds_test.rb impacts test/dispatch/mime_type_test.rb. dispatch/mime_type_test.rb runs independently fine but when run as part of rake breaks because of new mime types registered in controller/mime_responds_test.rb Signed-off-by: José Valim <jose.valim@gmail.com>
* rename star star to just one starNeeraj Singh2010-11-221-3/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* cleanup Mime::LOOKUP after registering image/gifNeeraj Singh2010-11-221-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* fix testNeeraj Singh2010-11-221-3/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* implement code that handles text/*, appplication/*,Neeraj Singh2010-11-221-1/+16
| | | | | | and image/* Signed-off-by: José Valim <jose.valim@gmail.com>
* test for text/*, application/* and image/*Neeraj Singh2010-11-221-1/+27
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* declare regex as a constantNeeraj Singh2010-11-221-1/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* add the fixture fileNeeraj Singh2010-11-221-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* do not assume that there is no space betweenNeeraj Singh2010-11-222-1/+5
| | | | | | leading */* and comma Signed-off-by: José Valim <jose.valim@gmail.com>
* failing test for #6022Neeraj Singh2010-11-221-0/+34
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* current code ignores http header "Accept" if itNeeraj Singh2010-11-222-1/+7
| | | | | | | | | | | has ....,*/* . It is possible to a device to send request such that */* appear at the beginning of the "Accept" header. This patch ensures that "Accept" header is ignored for such cases too. Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove unused constantSantiago Pastorino2010-11-221-2/+0
|
* There's no need for ternary op hereSantiago Pastorino2010-11-221-1/+1
|
* Remove unneeded metaprogramming and method generation in favor of direct ↵Santiago Pastorino2010-11-221-24/+10
| | | | definition
* Ensure that app generator is not loaded twice to get rid of warningsPiotr Sarnacki2010-11-221-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Do not create table_name_prefix method on isolated module if the method ↵Piotr Sarnacki2010-11-222-2/+23
| | | | | | already exists. Signed-off-by: José Valim <jose.valim@gmail.com>
* realigns a series of hash arrowsXavier Noria2010-11-211-10/+10
|
* documents <%== in the AS guideXavier Noria2010-11-211-0/+6
|
* Spanish for "project" is "proyecto"Xavier Noria2010-11-211-2/+2
|
* use_accept_header is no longer supportedNeeraj Singh2010-11-211-1/+1
|
* copy-edits d773ef8Xavier Noria2010-11-211-1/+1
|
* fix some grammar issues with section 2.5Jamison Dance2010-11-211-1/+1
|
* Mention the case that `render` will return nil if given `:collection` is nil ↵Prem Sichanugrist2010-11-211-0/+5
| | | | or empty when rendering partial.
* Spelling mistake: "Projecto" instead of "projeto"nosolopau2010-11-211-2/+2
|
* i18n guide: fix external link to rack localeJaime Iniesta2010-11-211-1/+1
|
* Fix code for customize the error messages html adding a .html_safe of 8.3 ↵Léo Hackin2010-11-211-2/+2
| | | | section
* unscoped takes care of named_scopes tooNeeraj Singh2010-11-211-2/+1
|
* i18n guide: this is not longer a problemJaime Iniesta2010-11-211-1/+1
|
* i18n guide: remove link to external page about 'How to encode the current ↵Jaime Iniesta2010-11-211-1/+1
| | | | locale in the URL' as it no longer exists
* i18n guide: it's activerecord.errors.messages.record_invalid (instead of ↵Jaime Iniesta2010-11-211-9/+9
| | | | 'invalid'), and messagges typo
* Minor fix on Rails:Railtie documentationzhengjia2010-11-211-2/+2
|
* remove old school validations and replaced with new validates method. ↵eparreno2010-11-215-36/+36
| | | | Pending: fix active_record guide
* Ensure calling reset session twice does not raise errors.José Valim2010-11-201-0/+12
|
* removed an AR method which wasn't used internally, had no tests, and had no docsJosh Kalderimis2010-11-201-4/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* class inheritable attributes is used no more! all internal use of class ↵Josh Kalderimis2010-11-2017-55/+91
| | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com>
* I18n is always loaded on boot by Active Model or Action Pack, so no need for ↵José Valim2010-11-201-1/+0
| | | | supporting lazy hooks.
* applies API conventions to the RDoc of json_encodeXavier Noria2010-11-201-10/+12
| | | | | | | | * Examples running with the text are preferred over separate Example sections. * No need to call puts, in # => we show the return value, not STDOUT. * Say explicitly that double quotes are removed. * Specify that we are talking \uXXX, rather than, say, HTML entities.
* Fix indentationSantiago Pastorino2010-11-201-24/+23
|
* Avoid range object creationSantiago Pastorino2010-11-201-1/+1
|
* do not require ruby-debug automatically. please require it if you have ↵Aaron Patterson2010-11-194-30/+0
| | | | declared it as a dependency
* guides: gives clear instructions for feedback, removes links to the now ↵Xavier Noria2010-11-1930-70/+37
| | | | archived LH project
* wtf vimAaron Patterson2010-11-191-1/+1
|
* fisting typeo, thanks @vinibaggioAaron Patterson2010-11-191-1/+1
|
* adding documentation for reversible migrationsAaron Patterson2010-11-192-1/+43
|