Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #3507 from jmazzi/issue-3503 | Jeremy Kemper | 2011-11-03 | 2 | -2/+21 |
| | | | | Preserve SELECT columns on the COUNT for finder_sql when possible | ||||
* | Stub find_template so that when handle_render_error is called in ↵ | Jon Leighton | 2011-11-03 | 1 | -0/+3 |
| | | | | | | ActionView::Template, we get to see the actual underlying error rather than a NoMethodError. This shows an encoding bug on Ruby 1.9.3. | ||||
* | Fix #3271. | Jon Leighton | 2011-11-03 | 3 | -1/+14 |
| | | | | | | | | Building the conditions of a nested through association could potentially modify the conditions of the through and/or source association. This is a Bad Thing. | ||||
* | Memoize through association | Jon Leighton | 2011-11-03 | 1 | -8/+11 |
| | |||||
* | Remove all revelant through records. | Jon Leighton | 2011-11-03 | 3 | -9/+29 |
| | | | | | | | | | If a record is removed from a has_many :through, all of the join records relating to that record should also be removed from the through association's target. (Previously the records were removed in the database, but only one was removed from the in-memory target array.) | ||||
* | Fix adding multiple instances of the same record to a has_many :through. | Jon Leighton | 2011-11-03 | 3 | -21/+57 |
| | | | | Fixes #3425. | ||||
* | Fix #3247. | Jon Leighton | 2011-11-03 | 3 | -2/+13 |
| | | | | | Fixes creating records in a through association with a polymorphic source type. | ||||
* | Merge pull request #3494 from sinisterchipmunk/usage-erb | José Valim | 2011-11-02 | 4 | -1/+13 |
|\ | | | | | treat USAGE as an ERB template | ||||
| * | treat USAGE as an ERB template | Colin MacKenzie IV | 2011-11-02 | 4 | -1/+13 |
|/ | |||||
* | Revert "Disable 1.9.3 builds until upgraded from -preview1 to -rc1" | Jeremy Kemper | 2011-11-01 | 1 | -1/+1 |
| | | | | This reverts commit 8a6acc17bb8badf70e300f599bf0440ee197028c. | ||||
* | this should never return nil, so no use for "try" | Aaron Patterson | 2011-10-31 | 1 | -1/+1 |
| | |||||
* | Ensure that the format isn't applied twice to the cache key, else it becomes ↵ | Christopher Meiklejohn | 2011-10-31 | 2 | -1/+14 |
| | | | | impossible to target with expire_action. | ||||
* | assert_match takes a regexp and a string in that order | Vijay Dev | 2011-10-31 | 1 | -1/+1 |
| | |||||
* | Merge pull request #3477 from rud/stable-migrations-version-order-rebased | José Valim | 2011-10-31 | 2 | -1/+10 |
|\ | | | | | dump_schema_information: explicitly order inserts into schema_migrations | ||||
| * | dump_schema_information: explicitly order inserts into schema_migrations table | Laust Rud Jacobsen | 2011-10-31 | 2 | -1/+10 |
|/ | | | | | | | This change reduces churn in the db/development_structure.sql file when using :sql as active_record.schema_format, and makes comparing diffs much easier. Test ensures the output SQL-statements are lexically ordered by version. | ||||
* | Merge pull request #3469 from kennyj/dont_use_old_code | Santiago Pastorino | 2011-10-30 | 1 | -3/+4 |
|\ | | | | | Refactor ActiveSupport::Cache::FileStore. | ||||
| * | Refactor ActiveSupport::Cache::FileStore. used method and deleted duplicate ↵ | kennyj | 2011-10-30 | 1 | -3/+4 |
|/ | | | | code. | ||||
* | Merge pull request #3468 from kennyj/fix_a_document_for_compress_limit | Vijay Dev | 2011-10-30 | 1 | -1/+1 |
|\ | | | | | fix a document for :compress_threshold. DEFAULT_COMPRESS_LIMIT is 16K. | ||||
| * | fix a document for :compress_threshold. DEFAULT_COMPRESS_LIMIT is 16K. | kennyj | 2011-10-30 | 1 | -1/+1 |
|/ | |||||
* | prefer qualified constant "name" to "reference expression", much simpler | Xavier Noria | 2011-10-30 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-10-30 | 6 | -7/+10 |
|\ | |||||
| * | Updated links to authentication plugins. | Joost Baaij | 2011-10-28 | 1 | -1/+1 |
| | | | | | | | | | | | | Removed mention of restful_authentication. Added devise and authlogic. Also mention Rails 3.1 built-in logic. | ||||
| * | Fix a little typo | Henare Degan | 2011-10-26 | 1 | -1/+1 |
| | | |||||
| * | Adds missing closing regex slashes. | mjy | 2011-10-25 | 1 | -2/+2 |
| | | |||||
| * | add namespacing when referring to ActionController::RedirectBackError | Nick Howard | 2011-10-25 | 1 | -2/+2 |
| | | |||||
| * | Added a note that optimistic locking also needs a hidden field to function ↵ | Joost Baaij | 2011-10-25 | 1 | -0/+3 |
| | | | | | | | | across web workers. | ||||
| * | note that after_initialize is run for rake tasks | Bruce Adams | 2011-10-24 | 1 | -1/+1 |
| | | |||||
* | | fixes a typo (thanks to Alexey Vakhov) | Xavier Noria | 2011-10-30 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #3464 from kennyj/avoid_to_call_twice | Santiago Pastorino | 2011-10-29 | 1 | -8/+5 |
|\ \ | | | | | | | avoided to call `Marshal.dump` twice | ||||
| * | | avoided to call twice | kennyj | 2011-10-30 | 1 | -8/+5 |
| | | | |||||
* | | | defines Module#qualified_const_(defined?|get|set) and String#deconstantize | Xavier Noria | 2011-10-29 | 10 | -13/+311 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit also implements a faster version of #demodulize I was unable to isolate with git add --patch. Not a big fan of the name #deconstantize. It complements #demodulize getting rid of the rightmost constant, hence the name, but it is unrelated to the well-known #constantize. So unsure. Could not come with anything better, please feel free to rename. | ||||
* | | | Merge pull request #3463 from kennyj/fix_document_for_cache | Santiago Pastorino | 2011-10-29 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | fix a document for race_condition_ttl. ActiveSupport::Cache::MemoryCache isn't exist. | ||||
| * | | | fix a document for race_condition_ttl. ActiveSupport::Cache::MemoryCache ↵ | kennyj | 2011-10-30 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | isn't exist | ||||
* | | | | Removing db/seeds.rb is fine. Don't blow up. | Jeremy Kemper | 2011-10-29 | 2 | -2/+8 |
| |/ / |/| | | |||||
* | | | Merge pull request #3462 from kennyj/remove_deprecated_code | José Valim | 2011-10-29 | 1 | -2/+0 |
|\ \ \ | |/ / |/| | | removed a reference to SynchronizedMemoryStore and CompressedMemCacheStore | ||||
| * | | removed reference to SynchronizedMemoryStore and CompressedMemCacheStore ↵ | kennyj | 2011-10-30 | 1 | -2/+0 |
|/ / | | | | | | | (the remaining code from 9cafc28874) | ||||
* | | Merge pull request #3337 from htanata/fix_rake_routes_for_controller_only_route | José Valim | 2011-10-29 | 2 | -9/+18 |
|\ \ | | | | | | | Remove trailing "#" on rake routes for controller only routes | ||||
| * | | On inpsect routes, show :controller and :action to indicate dynamic. | Hendy Tanata | 2011-10-29 | 2 | -9/+18 |
| | | | |||||
* | | | Merge pull request #3460 from arunagw/method_redefine_warning_removed | Xavier Noria | 2011-10-29 | 1 | -0/+1 |
|\ \ \ | | | | | | | | | method redefined warning removed! | ||||
| * | | | method redefined warning removed! | Arun Agrawal | 2011-10-29 | 1 | -0/+1 |
|/ / / | |||||
* | | | Merge pull request #3459 from arunagw/running_test_doc_fix | Vijay Dev | 2011-10-29 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | ActiveRecord is no more in controller directory. | ||||
| * | | | ActiveRecord is no more in controller directory. | Arun Agrawal | 2011-10-29 | 1 | -1/+1 |
| | | | | |||||
* | | | | let demodulize do less work, and add tests | Xavier Noria | 2011-10-29 | 2 | -1/+5 |
|/ / / | | | | | | | | | | This is also faster on 1.9. | ||||
* | | | Merge pull request #3456 from pwim/documentation-fix | José Valim | 2011-10-27 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Add missing type to number_field_tag documentation | ||||
| * | | | Add missing type to number_field_tag documentation | Paul McMahon | 2011-10-28 | 1 | -1/+1 |
|/ / / | |||||
* | | | clear statement cache when tables are altered | Aaron Patterson | 2011-10-27 | 1 | -0/+6 |
| | | | |||||
* | | | Added failing test case for changing schema in migration not clearing the ↵ | Joe Van Dyk | 2011-10-27 | 1 | -0/+12 |
|/ / | | | | | | | prepared statement cache | ||||
* | | Merge pull request #3449 from arunagw/checks_for_instance_writers | José Valim | 2011-10-27 | 1 | -1/+2 |
|\ \ | | | | | | | More checks for instance writers. | ||||
| * | | More checks for instance writers. | Arun Agrawal | 2011-10-27 | 1 | -1/+2 |
|/ / | |||||
* | | Merge pull request #3448 from arunagw/instance_disable_fix | José Valim | 2011-10-27 | 1 | -1/+2 |
|\ \ | | | | | | | Test fix Allow instances to disable record_timestamps |