Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove 'warning: ambiguous first argument' when running ActionPack tests | Sebastian Martinez | 2011-03-29 | 2 | -4/+4 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Change exists? so that it doesn't instantiate records [#6127 state:resolved] | Andrew White | 2011-03-29 | 2 | -4/+15 |
| | |||||
* | Move mapper_test to the appropriate location | Prem Sichanugrist | 2011-03-29 | 1 | -0/+0 |
| | | | | | | It seems like in 89c5b9aee7d7db95cec9e5a934c3761872ab107e Aaron actually put the test in action_dispatch folder. However, there's already a `test/dispatch` directory which I think it's more appropriate. Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | ||||
* | Update the wildcard route to be non-greedy by default, therefore be able to ↵ | Prem Sichanugrist | 2011-03-29 | 5 | -3/+59 |
| | | | | | | | | match the (.:format) segment [#6605 state:resolved] After some discussion with Andrew White, it seems like this is a better approach for handling a wildcard route. However, user can still bring back the old behavior by supplying `:format => false` to the route. Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | ||||
* | Fix examples | David Heinemeier Hansson | 2011-03-28 | 2 | -2/+2 |
| | |||||
* | Added Base.http_basic_authenticate_with to do simple http basic ↵ | David Heinemeier Hansson | 2011-03-28 | 3 | -14/+69 |
| | | | | authentication with a single class method call [DHH] | ||||
* | make sure we have an active database connection before running each ↵ | Aaron Patterson | 2011-03-28 | 2 | -5/+10 |
| | | | | connection management test | ||||
* | adding active_connections? to the connection pool for finding open connections | Aaron Patterson | 2011-03-28 | 2 | -0/+39 |
| | |||||
* | adding active_connection? to the connection pool | Aaron Patterson | 2011-03-28 | 2 | -0/+14 |
| | |||||
* | testing app delegation from the ConnectionManagement middleware | Aaron Patterson | 2011-03-28 | 1 | -3/+20 |
| | |||||
* | namespacing connection management tests. :heart: | Aaron Patterson | 2011-03-28 | 1 | -18/+22 |
| | |||||
* | sql logger ignores schema statements | Aaron Patterson | 2011-03-28 | 3 | -2/+32 |
| | |||||
* | Bring #reorder back | Sebastian Martinez | 2011-03-28 | 4 | -3/+13 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Engines that use isolate_namespace with nested modules should set correct ↵ | Rolf Timmermans | 2011-03-28 | 2 | -2/+41 |
| | | | | module prefix for their routes. | ||||
* | Added new #update_column method. | Sebastian Martinez | 2011-03-27 | 14 | -21/+132 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | let these heredocs flow with the code | Xavier Noria | 2011-03-28 | 1 | -14/+15 |
| | |||||
* | Make edge and dev options use edge mysql2 | Santiago Pastorino | 2011-03-27 | 1 | -6/+14 |
| | |||||
* | Revert "Removed #update_attribute method. New #update_column method." | Sebastian Martinez | 2011-03-27 | 13 | -78/+80 |
| | | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-03-27 | 3 | -9/+10 |
|\ | |||||
| * | AR validations and callbacks guide: put update_attribute back | Xavier Noria | 2011-03-27 | 1 | -0/+2 |
| | | |||||
| * | A little minor rephrasing for improved readability. | mhutchin | 2011-03-27 | 1 | -1/+1 |
| | | |||||
| * | Minor typo fix. | mhutchin | 2011-03-27 | 1 | -1/+1 |
| | | |||||
| * | Updated guides for new #update_column. | Sebastian Martinez | 2011-03-26 | 1 | -2/+2 |
| | | |||||
| * | Proc objects for cache_path for caches_action no longer need controller ↵ | Ryan Bigg | 2011-03-26 | 1 | -7/+6 |
| | | | | | | | | object, nor to use send when calling routing helpers | ||||
* | | Fix documentation typo | Prem Sichanugrist | 2011-03-28 | 1 | -1/+1 |
| | | |||||
* | | Add controller-specific `force_ssl` method to force web browser to use HTTPS ↵ | Prem Sichanugrist | 2011-03-28 | 6 | -0/+144 |
| | | | | | | | | | | | | | | | | protocol This would become useful for site which sometime transferring sensitive information such as account information on particular controller or action. This featured was requested by DHH. | ||||
* | | s/with/when/ | Xavier Noria | 2011-03-27 | 1 | -1/+1 |
| | | |||||
* | | Add `config.force_ssl` configuration which will load `Rack::SSL` middleware ↵ | Prem Sichanugrist | 2011-03-27 | 9 | -18/+40 |
| | | | | | | | | | | | | | | | | if set to true This will allow user to be able to force all requests to be under HTTPS protocol. This commit was a request from DHH. Special thanks to Josh Peek as well for making `Rack::SSL`. | ||||
* | | fixes a couple of regexps, the suite showed warnings about them | Xavier Noria | 2011-03-27 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A couple of things worth mentioning here: - "{" is a metacharacter, should be escaped if it is meant to match a "{". The code worked, though, because the regexp engine is tolerant to this, but issued warnings. - gsub accepts a string as first argument. That's the best idiom to use when your pattern has no metacharacters, since gsub interprets the string as an exact substring to look for, rather than a regexp. The benefit is that your pattern is crystal clear and needs no backslashes. | ||||
* | | Fix alias_method, add test | David Heinemeier Hansson | 2011-03-27 | 2 | -1/+2 |
| | | |||||
* | | cleaning up typecast test a little | Aaron Patterson | 2011-03-26 | 1 | -6/+8 |
| | | |||||
* | | refactoring tz to a variable rather than repeating it | Aaron Patterson | 2011-03-26 | 1 | -2/+4 |
| | | |||||
* | | Allow FormHelper#form_for to specify the :method as a direct option instead ↵ | David Heinemeier Hansson | 2011-03-26 | 3 | -4/+36 |
| | | | | | | | | of through the :html hash [DHH] | ||||
* | | adding a test for attributes after type cast. thanks nragaz. :heart: | Aaron Patterson | 2011-03-26 | 1 | -0/+17 |
| | | |||||
* | | Make JavaScriptHelper#j() an alias for JavaScriptHelper#escape_javascript() ↵ | David Heinemeier Hansson | 2011-03-26 | 2 | -0/+7 |
| | | | | | | | | -- note this then supersedes the Object#j() method that the JSON gem adds within templates using the JavaScriptHelper [DHH] | ||||
* | | Removed #update_attribute method. New #update_column method. | Sebastian Martinez | 2011-03-26 | 13 | -80/+78 |
|/ | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-03-26 | 1 | -3/+3 |
|\ | |||||
| * | impact recent updates to #first! and #last! methods | Sebastian Martinez | 2011-03-25 | 1 | -3/+3 |
| | | |||||
* | | removes unnecessary selfs, and mentions that first! and last! take no ↵ | Xavier Noria | 2011-03-26 | 1 | -4/+6 |
|/ | | | | arguments in their API docs | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-03-25 | 1 | -0/+34 |
|\ | |||||
| * | Update AR querying guide with #first! and #last! new methods | Sebastian Martinez | 2011-03-25 | 1 | -0/+34 |
| | | |||||
* | | No arguments for first! and last! | Pratik Naik | 2011-03-25 | 1 | -4/+4 |
| | | |||||
* | | comment typo fix | Josh Susser | 2011-03-25 | 1 | -2/+2 |
| | | |||||
* | | fixing whitespace errors. :bomb: | Aaron Patterson | 2011-03-25 | 1 | -2/+2 |
| | | |||||
* | | correction to the outputted controller name in the diagnostics error ↵ | Josh Kalderimis | 2011-03-24 | 2 | -1/+17 |
| | | | | | | | | | | | | template, test included Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | add #first! and #last! to models & relations | Josh Susser | 2011-03-24 | 2 | -0/+34 |
| | | |||||
* | | Fix filter :only and :except with implicit actions | Andrew White | 2011-03-23 | 2 | -12/+17 |
| | | | | | | | | | | | | | | The method_name argument is "default_render" for implicit actions so use the action_name attribute to determine which callbacks to run. [#5673 state:resolved] | ||||
* | | Add a failing test case for an implicit action with a before filter. | Manfred Stienstra | 2011-03-23 | 3 | -0/+24 |
| | | | | | | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | ||||
* | | Fix before_type_cast for timezone aware attributes by caching converted ↵ | Adam Meehan | 2011-03-23 | 2 | -19/+16 |
| | | | | | | | | value on write. Also remove read method reload arg on timezone attributes. | ||||
* | | Make clearing of HABTM join table contents happen in an after_destory callback. | Murray Steele | 2011-03-23 | 1 | -12/+12 |
| | | | | | | | | The old method of redefining destroy meant that clearing the HABTM join table would happen as long as the call to destroy succeeded. Which meant if there was a before_destroy that stopped the instance being destroyed using normal means (returning false, raising ActiveRecord::Rollback) rather than exceptional means the join table would be cleared even though the instance wasn't destroyed. Doing it in an after_destroy hook avoids this and has the advantage of happening inside the DB transaction too. |