Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Accept :remote as symbol in link_to options | Riley | 2012-10-06 | 3 | -1/+12 |
| | | | | | Accept either :remote or 'remote' in both the html_options and (url_)options hash arguments to link_to. | ||||
* | Merge pull request #7848 from senny/3415_assert_template_has_nil_variable | Rafael Mendonça França | 2012-10-06 | 3 | -3/+23 |
| | | | | | | can't pass :locals to #assert_template without a view test case (#3415) Conflicts: actionpack/CHANGELOG.md | ||||
* | Merge pull request #7850 from ↵ | Rafael Mendonça França | 2012-10-06 | 3 | -5/+14 |
| | | | | | | | | | senny/5920_postgres_adapter_table_with_capital_letters postgres, quote table names when fetching the primary key (#5920) Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb | ||||
* | Merge pull request #6978 from frodsan/count_nosql_unsaved_parent | Rafael Mendonça França | 2012-10-04 | 5 | -0/+37 |
| | | | | Count returns 0 without querying if parent is not saved | ||||
* | Merge pull request #7836 from lihanli/error-msg-update | Rafael Mendonça França | 2012-10-03 | 2 | -2/+6 |
|\ | | | | | Update supported ruby versions error message in ruby_version_check.rb | ||||
| * | Update supported ruby versions error message in ruby_version_check.rb | lihan | 2012-10-03 | 2 | -2/+6 |
|/ | |||||
* | Refactor | Santiago Pastorino | 2012-10-03 | 1 | -5/+3 |
| | | | | | Conflicts: activerecord/lib/active_record/counter_cache.rb | ||||
* | Merge pull request #7822 from lulalala/reset-counter-cache-for-has-many-through | Rafael Mendonça França | 2012-10-02 | 5 | -4/+29 |
| | | | | | | | Fix reset_counters crashing on has_many :through associations. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/counter_cache.rb | ||||
* | Merge pull request #7797 from senny/7459_prefix_tempalte_assertion_variables | Rafael Mendonça França | 2012-10-01 | 3 | -23/+29 |
| | | | | | | | | | prefix TemplateAssertions ivars. Closes #7459 Conflicts: actionpack/lib/action_controller/test_case.rb actionpack/lib/action_view/test_case.rb | ||||
* | Merge pull request #7789 from senny/7777_resource_functions_modify_options | Rafael Mendonça França | 2012-10-01 | 3 | -2/+27 |
| | | | | resource and resources do no longer modify passed options | ||||
* | Merge pull request #6450 from iHiD/resource_generator_routes_master | Rafael Mendonça França | 2012-10-01 | 3 | -7/+116 |
| | | | | | | | | Master branch: Fixed generated whitespace in routes when using namespaced resource. Merge pull request #7811 from iHiD/resource_generator_routes_master Fix the build (Broken scaffold routes test) | ||||
* | Since File instance doesn't respond to #open use a double to test the | Rafael Mendonça França | 2012-09-30 | 3 | -5/+4 |
| | | | | behavior added at c53e5def08f7a289a92a8e5f79dcd7caa5c3a2fb | ||||
* | Asset manifest includes aliases for foo.js -> foo/index.js and vice versa. ↵ | Jeremy Kemper | 2012-09-30 | 4 | -22/+43 |
| | | | | Bump Sprockets requirements from 2.1+ to 2.2+ and let it answer "should we compile this asset?" for us. | ||||
* | Merge pull request #7802 from steveklabnik/issue_7799 | Xavier Noria | 2012-09-30 | 1 | -1/+1 |
|\ | | | | | Fix reference to code sample in Getting Started. | ||||
| * | Fix reference to code sample in Getting Started. | Steve Klabnik | 2012-09-30 | 1 | -1/+1 |
|/ | | | | Fixes #7799. | ||||
* | New CHANGELOG entries always in the top [ci skip] | Rafael Mendonça França | 2012-09-30 | 1 | -6/+6 |
| | |||||
* | Merge pull request #7659 from HugoLnx/template_error_no_matches_rebased | Rafael Mendonça França | 2012-09-30 | 4 | -6/+55 |
| | | | | | | | REBASED: fixing assert_template bug when template matches expected, but not ends with Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_controller/test_case.rb | ||||
* | Merge pull request #7786 from yabawock/3-2-stable | Rafael Mendonça França | 2012-09-29 | 3 | -1/+14 |
|\ | | | | | Backport "Don't paramify ActionDispatch::Http::UploadedFile in tests" | ||||
| * | Don't paramify ActionDispatch::Http::UploadedFile in tests | Tim Vandecasteele | 2012-09-29 | 3 | -1/+14 |
| | | | | | | | | | | | | | | | | | | | | To test uploading a file without using fixture_file_upload, a posted ActionDispatch::Http::UploadedFile should not be paramified (just like Rack::Test::UploadedFile). (Rack::Test::UploadedFile and ActionDispatch::Http::UploadedFile don't share the same API, tempfile is not accessible on Rack::Test::UploadedFile as discussed in https://github.com/brynary/rack-test/issues/30) | ||||
* | | Merge pull request #7785 from okcwest/3-2-stable | Aaron Patterson | 2012-09-28 | 4 | -6/+13 |
|\ \ | |/ |/| | backport 68677ffb8298105eb9d3efa26d928dd88cc5e006 | ||||
| * | backport 68677ffb8298105eb9d3efa26d928dd88cc5e006 | Evan Petrie | 2012-09-28 | 4 | -6/+13 |
| | | |||||
* | | Hashrocket for 1.8 support | Jeremy Kemper | 2012-09-28 | 1 | -2/+2 |
| | | |||||
* | | Shush uninitialized @_layout warning | Jeremy Kemper | 2012-09-28 | 1 | -1/+1 |
|/ | |||||
* | Shush syntax warnings | Jeremy Kemper | 2012-09-28 | 1 | -3/+3 |
| | |||||
* | Tune up Rails::Rack::Logger. Only put space between requests in development ↵ | Jeremy Kemper | 2012-09-27 | 2 | -20/+29 |
| | | | | | | | logs. Conflicts: railties/test/application/rack/logger_test.rb | ||||
* | Add logger.push_tags and .pop_tags to complement logger.tagged | Jeremy Kemper | 2012-09-27 | 3 | -18/+69 |
| | | | | | | | | | Avoid memory leak from unflushed logs on other threads leaving tags behind. Conflicts: activesupport/CHANGELOG.md activesupport/lib/active_support/tagged_logging.rb activesupport/test/tagged_logging_test.rb | ||||
* | Log newlines separately to ensure the 'Started GET ...' line has a tag on ↵ | Jeremy Kemper | 2012-09-27 | 1 | -1/+2 |
| | | | | the same line | ||||
* | Only apply log tags if the logger supports it | Jeremy Kemper | 2012-09-27 | 1 | -1/+1 |
| | |||||
* | Merge pull request #7684 from jrochkind/connection_pool_timeout_key_backport | Rafael Mendonça França | 2012-09-25 | 4 | -5/+39 |
|\ | | | | | ConnectionPool accepts spec key 'checkout_timeout' (Backport) | ||||
| * | ConnectionPool accepts spec key 'checkout_timeout' | Jonathan Rochkind | 2012-09-24 | 4 | -5/+39 |
| | | | | | | | | | | | | | | Backport of #6441 cb6f83935 . Old 'wait_timeout' is still supported, but conflicts with mysql2 using that spec key for different thing. 'checkout_timeout' can now be used taking precedence for ConnectionPool over 'wait_timeout'. | ||||
* | | Fix invalid ruby 1.8 syntax | Rafael Mendonça França | 2012-09-21 | 1 | -4/+5 |
|/ | |||||
* | Merge pull request #7723 from steveklabnik/backport_3554 | Rafael Mendonça França | 2012-09-21 | 4 | -5/+23 |
|\ | | | | | Backport #3544 to 3-2-stable | ||||
| * | Merge pull request #3544 from amatsuda/_field_changed | Aaron Patterson | 2012-09-21 | 4 | -5/+23 |
|/ | | | | | | | | Rename field_changed? to _field_changed? so that users can create a field named field Conflicts: activerecord/lib/active_record/core.rb activerecord/test/cases/dirty_test.rb | ||||
* | Revert "Revert "Respect `config.digest = false` for `asset_path`"" | Rafael Mendonça França | 2012-09-20 | 3 | -1/+20 |
| | | | | | | This reverts commit 54f55746a70a7091341e84236498203118a7fbb4. Reason: the last commit fixed the failing case | ||||
* | Explictly set the assets digest option to false | Rafael Mendonça França | 2012-09-20 | 1 | -2/+5 |
| | |||||
* | Revert "Respect `config.digest = false` for `asset_path`" | Rafael Mendonça França | 2012-09-20 | 3 | -20/+1 |
| | | | | | | | | | | | | This reverts commit 1ac19c11792a745cd654f02dfaed8e93f95b3c70. Conflicts: actionpack/CHANGELOG.md Reason: This is causing failures in the railties build. See http://travis-ci.org/#!/rails/rails/jobs/2491787 Related with #7672 | ||||
* | Revert "backport fair connection pool 02b2335563 to 3-2-stable" | Rafael Mendonça França | 2012-09-20 | 7 | -311/+51 |
| | | | | | | | | | | | | | This reverts commit 0693e079708a52b777f2b7872b8e3d467b880a0d. Revert "Cache columns metadata to avoid extra while testing" This reverts commit a82f1e3f5d11c8dfba9f4c911745ec40a7965216. Reason: This is causing failures in the postgresql build. See http://travis-ci.org/#!/rails/rails/builds/2485584 Related with #7675 | ||||
* | Merge pull request #7718 from kennyj/fix_6962-32 | Rafael Mendonça França | 2012-09-20 | 3 | -1/+16 |
|\ | | | | | [3-2-stable] Fix #6962. AS::TimeWithZone#strftime responds incorrectly to %:z and %::z format strings. | ||||
| * | Fix #6962. AS::TimeWithZone#strftime responds incorrectly to %:z and %::z ↵ | kennyj | 2012-09-20 | 3 | -1/+16 |
|/ | | | | format strings. | ||||
* | Load the environment after creating the database | Jeremy Kemper | 2012-09-19 | 1 | -2/+2 |
| | | | | | Conflicts: activerecord/lib/active_record/railties/databases.rake | ||||
* | Merge pull request #7668 from Draiken/fix_issue_6497 | Rafael Mendonça França | 2012-09-19 | 3 | -1/+18 |
| | | | | | | Removing to_shorthand to fix #6497 Conflicts: actionpack/CHANGELOG.md | ||||
* | Cache columns metadata to avoid extra while testing | Rafael Mendonça França | 2012-09-18 | 3 | -1/+11 |
| | |||||
* | Merge pull request #7686 from steveklabnik/add_upgrade_note | Rafael Mendonça França | 2012-09-18 | 1 | -0/+122 |
|\ | | | | | Add upgrading note to 3.1 release notes. | ||||
| * | Add upgrading note to 3.1 release notes. | Steve Klabnik | 2012-09-18 | 1 | -0/+122 |
|/ | | | | See #7685. | ||||
* | Merge pull request #7672 from wagenet/asset_path_digest_fix | Rafael Mendonça França | 2012-09-18 | 3 | -1/+20 |
|\ | | | | | Respect `config.digest = false` for `asset_path` | ||||
| * | Respect `config.digest = false` for `asset_path` | Peter Wagenet | 2012-09-17 | 3 | -1/+20 |
|/ | | | | | | | Previously, the `asset_path` internals only respected the `:digest` option, but ignored the global config setting. This meant that `config.digest = false` could not be used in conjunction with `config.compile = false` this corrects the behavior. | ||||
* | Merge pull request #7675 from jrochkind/fair_conn_pool_backport | Rafael Mendonça França | 2012-09-17 | 4 | -50/+300 |
|\ | | | | | backport fair connection pool 02b2335563 to 3-2-stable | ||||
| * | backport fair connection pool 02b2335563 to 3-2-stable | Jonathan Rochkind | 2012-09-17 | 4 | -50/+300 |
|/ | |||||
* | log 404 status when ActiveRecord::RecordNotFound was raised (#7646) | Yves Senn | 2012-09-17 | 4 | -3/+27 |
| | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_controller/log_subscriber.rb | ||||
* | Merge pull request #7661 from ernie/build-join-records-on-unsaved-hmt | Rafael Mendonça França | 2012-09-17 | 3 | -0/+25 |
| | | | | Fix collection= on hm:t join models when unsaved |